Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Hive Image to commit b1ac27b248 - ARO-5063 #3662

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Bump Hive Image to commit b1ac27b248 - ARO-5063 #3662

merged 1 commit into from
Jul 8, 2024

Conversation

s-fairchild
Copy link
Collaborator

@s-fairchild s-fairchild commented Jul 3, 2024 •
edited
Loading

Which issue this PR addresses:

ARO-5063

Fixes

What this PR does / why we need it:

Hive image version bump to https://quay.io/repository/app-sre/hive/manifest/sha256:9afa7b28b60a438deef634f7d55a6e298279690fed5fe532109207d88c6b356b.
Hive commit: b1ac27b248159f179abf8c7e03e6ada5f17e86c0

Associated RPConfig PR #10395556

Test plan for issue:

Tested by deploying this hive version to shared aks cluster in australiaeast.

HIVE_IMAGE_COMMIT_HASH="b1ac27b248"

hive is already installed in the namespace
would you like to reapply the configs? (y/N): y
customresourcedefinition.apiextensions.k8s.io/checkpoints.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterclaims.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterdeploymentcustomizations.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterdeployments.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterdeprovisions.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterimagesets.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterpools.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterprovisions.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterrelocates.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clusterstates.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/dnszones.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/hiveconfigs.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/machinepoolnameleases.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/machinepools.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/selectorsyncidentityproviders.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/selectorsyncsets.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/syncidentityproviders.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/syncsets.hive.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clustersyncleases.hiveinternal.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/clustersyncs.hiveinternal.openshift.io configured
customresourcedefinition.apiextensions.k8s.io/fakeclusterinstalls.hiveinternal.openshift.io configured
secret/hive-global-pull-secret configured
hiveconfig.hive.openshift.io/hive configured
configmap/additional-install-log-regexes created
serviceaccount/hive-operator unchanged
clusterrole.rbac.authorization.k8s.io/hive-operator-role configured
clusterrolebinding.rbac.authorization.k8s.io/hive-operator-rolebinding configured
deployment.apps/hive-operator configured
deployment.apps/hive-operator condition met
deployment.apps/hive-controllers condition met
pod/hive-clustersync-0 condition met

Hive is installed.

Is there any documentation that needs to be updated for this PR?

How to test deployment to aks shared cluster needs some added steps: https://msazure.visualstudio.com/AzureRedHatOpenShift/_wiki/wikis/ARO.wiki/635070/Hive-Deploy-ARO-Pipelines
I will update this document, and the associated scripts in docs/hive.md in a follow up PR.

How do you know this will function as expected in production?

Tested by deploying this hive version to shared aks cluster in australiaeast.

@s-fairchild s-fairchild added dependencies Pull requests that update a dependency file chainsaw Pull requests or issues owned by Team Chainsaw labels Jul 3, 2024
@s-fairchild s-fairchild mentioned this pull request Jul 3, 2024
Closed
@s-fairchild s-fairchild changed the title Bump Hive Image to commit b1ac27b248159f179abf8c7e03e6ada5f17e86c0 - … Bump Hive Image to commit b1ac27b248 - ARO-5063 Jul 3, 2024
@s-fairchild s-fairchild marked this pull request as ready for review July 3, 2024 17:57
@s-fairchild s-fairchild mentioned this pull request Jul 3, 2024
Merged
mociarain
mociarain previously approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mociarain
Copy link
Collaborator

/azp run ci

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Please rebase pull request.

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Jul 8, 2024
@s-fairchild s-fairchild force-pushed the s-fairchild/ARO-5063-hive-bump branch from f2bb0e8 to d9c8921 Compare July 8, 2024 17:23
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Jul 8, 2024
@cadenmarchese
Copy link
Collaborator

/azp run ci,e2e

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cadenmarchese cadenmarchese merged commit a69a160 into master Jul 8, 2024
21 checks passed
@mociarain mociarain deleted the s-fairchild/ARO-5063-hive-bump branch July 9, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadenmarchese cadenmarchese cadenmarchese approved these changes

@mociarain mociarain mociarain left review comments

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@jaitaiwan jaitaiwan Awaiting requested review from jaitaiwan jaitaiwan is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig is a code owner

@tiguelu tiguelu Awaiting requested review from tiguelu tiguelu is a code owner

@SrinivasAtmakuri SrinivasAtmakuri Awaiting requested review from SrinivasAtmakuri SrinivasAtmakuri is a code owner

@AldoFusterTurpin AldoFusterTurpin Awaiting requested review from AldoFusterTurpin

Assignees
No one assigned
Labels
chainsaw Pull requests or issues owned by Team Chainsaw dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-fairchild @mociarain @cadenmarchese