Override cast_to_fp8 in te.module.linear #120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug in TE integration.
Currently we only override te.cpp_extensions.cast_to_fp8 with our own cat_to_fp8 in msamp.te.extension.
We also need to override te.module.linear.cast_to_fp8. Otherwise, it will use the original function which does not support ScalingTensor and will raise an exception in Megatron-LM
Major Revision