Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some bugs for latest TE #160

Merged
merged 2 commits into from
Feb 22, 2024
Merged

fix some bugs for latest TE #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eadca11
fix bug for non first microbatch in te
tocean Feb 21, 2024
1b0d2cf
use transformer engine v1.1
tocean Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dockerfile/torch1.14-cuda11.8.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ RUN cd third_party/msccl && \
make install
# cache TE build to save time in CI
RUN python3 -m pip install --upgrade pip && \
python3 -m pip install git+https://github.com/NVIDIA/TransformerEngine.git@stable
python3 -m pip install git+https://github.com/NVIDIA/TransformerEngine.git@v1.1

ADD . .
RUN python3 -m pip install . && \
Expand Down
2 changes: 1 addition & 1 deletion dockerfile/torch2.1-cuda12.2.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ RUN cd third_party/msccl && \
make install
# cache TE build to save time in CI
RUN python3 -m pip install --upgrade pip && \
python3 -m pip install git+https://github.com/NVIDIA/TransformerEngine.git@stable
python3 -m pip install git+https://github.com/NVIDIA/TransformerEngine.git@v1.1

ADD . .
RUN python3 -m pip install . && \
Expand Down
2 changes: 1 addition & 1 deletion msamp/te/modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def set_fp8_weights(self):
weight_cast_attr = f'weight{i}_fp8'
weight_transpose_attr = f'weight{i}_t_fp8'

if (hasattr(self, weight_cast_attr) and getattr(self, weight_cast_attr).shape == shape):
if (hasattr(self, weight_cast_attr) and getattr(self, weight_cast_attr)._data.shape == shape):
return

setattr(
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ classifiers=[
]
dependencies = [
"torch",
"transformer-engine@git+https://github.com/NVIDIA/TransformerEngine.git@stable",
"transformer-engine@git+https://github.com/NVIDIA/TransformerEngine.git@v1.1",
"colorlog>=6.7.0",
"deepspeed==0.13.1",
"mpi4py",
Expand Down
5 changes: 4 additions & 1 deletion tests/te/test_te_replacer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,5 +164,8 @@ def test_fp8_ddp_with_te(self):
fp8_format = Format.HYBRID
fp8_recipe = DelayedScaling(fp8_format=fp8_format, amax_history_len=16, amax_compute_algo='max')
with te.fp8_autocast(enabled=True, fp8_recipe=fp8_recipe):
output = model(x, attention_mask=None)
output = model(x, attention_mask=None, is_first_microbatch=True)
output.sum().backward()
with te.fp8_autocast(enabled=True, fp8_recipe=fp8_recipe):
output = model(x, attention_mask=None, is_first_microbatch=False)
output.sum().backward()
Loading