Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Install image-gc configurable will sane defaults #1410

Merged
merged 6 commits into from
Sep 8, 2017

Conversation

nalthoff
Copy link
Contributor

@nalthoff nalthoff commented Sep 6, 2017

What this PR does / why we need it:

This enhances the k8s cluster definition to allow the user to set custom values for --image-gc-high-threshold and --image-gc-low-threshold. If the user doesn't set the values, the default k8s values are explicity set (85/80)

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1374

Special notes for your reviewer:

Documentation updated as well. Unit tests were not written, but if needed please let me know where/how

Release note:

NONE

@msftclas
Copy link

msftclas commented Sep 6, 2017

@nalthoff,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@SaaldjorMike
Copy link
Contributor

SaaldjorMike commented Sep 6, 2017

According to https://kubernetes.io/docs/admin/kubelet/ the default high threshold is:

--image-gc-high-threshold int32 The percent of disk usage after which image garbage collection is always run. (default 85)

but according to the docs at https://kubernetes.io/docs/concepts/cluster-administration/kubelet-garbage-collection/ it seems that it is 90%?

image-gc-high-threshold, the percent of disk usage which triggers image garbage collection. Default is 90%.

Did I miss something or is one of those pages out of date?

EDIT: Apparently it was previously lowered from 90% to 85%, see kubernetes/kubernetes#40432

@nalthoff
Copy link
Contributor Author

nalthoff commented Sep 6, 2017

@SaaldjorMike Yup. I dug into the defaults for 1.5, 1.6 and 1.7 and decided to go with the 1.7 defaults for all of them since they were pretty similar.

@nalthoff
Copy link
Contributor Author

nalthoff commented Sep 7, 2017

@lachie83 Here is the PR for the issue you created for me.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nalthoff and @SaaldjorMike !

@jackfrancis jackfrancis merged commit 7cf8d6d into Azure:master Sep 8, 2017
@lachie83
Copy link
Member

lachie83 commented Sep 9, 2017

Thanks for taking care of this @nalthoff. Very much appreciated!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install image-gc configurable will sane defaults
5 participants