This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Adding more descriptions and clarifications to Windows tests #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #3470 +/- ##
=======================================
Coverage 55.84% 55.84%
=======================================
Files 105 105
Lines 15889 15889
=======================================
Hits 8874 8874
Misses 6270 6270
Partials 745 745 |
julienstroheker
pushed a commit
to julienstroheker/acs-engine
that referenced
this pull request
Jul 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Comments, accurate bug numbers and readable log output are good.
I also moved the Windows test container image into a var, to be updated later for multi-OS version support.