Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Kubernetes: add —no-negcache to dnsmasq config #3564

Closed
wants to merge 2 commits into from

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Jul 26, 2018

What this PR does / why we need it: WIP to test if this fixes some custom upstream resolver cluster scenarios

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #3534 fixes #2999

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Kubernetes: add —no-negcache to dnsmasq config

@ghost ghost assigned jackfrancis Jul 26, 2018
@acs-bot
Copy link

acs-bot commented Jul 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 26, 2018

Codecov Report

Merging #3564 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3564      +/-   ##
==========================================
- Coverage   55.49%   55.43%   -0.06%     
==========================================
  Files         105      105              
  Lines       16038    16036       -2     
==========================================
- Hits         8900     8890      -10     
- Misses       6386     6394       +8     
  Partials      752      752

@jackfrancis
Copy link
Member Author

Adding a fixes #2999 here as there's a chance this addresses that issue.

@jackfrancis
Copy link
Member Author

preferring #3515

@ghost ghost removed the in progress label Jul 27, 2018
@jackfrancis jackfrancis deleted the kube-dns-no-negcache branch July 27, 2018 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-dns-v20 deployment Pods are unable to resolve DNS for services both internally and externally.
2 participants