Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes 1.14.0 #876

Merged
merged 5 commits into from
Mar 25, 2019

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Mar 25, 2019

Reason for Change:

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.14.md

Issue Fixed:

Requirements:

  • Windows artifacts uploaded to acsmirror blob store
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mboersma
Copy link
Member Author

I'll rebase this after #873 merges and then run tests.

@mboersma
Copy link
Member Author

mboersma commented Mar 25, 2019

/azp run pr-e2e

I lied, I want to see the test results and I am not patient.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mboersma
Copy link
Member Author

The 1.14 known issues mentions this:

There is a known issue coredns/coredns#2629 in CoreDNS 1.3.1, wherein if the Kubernetes API shuts down while CoreDNS is connected, CoreDNS will crash. The issue is fixed in CoreDNS 1.4.0 in coredns/coredns#2529.

But the Docker image k8s.gcr.io/coredns:1.4.0 is not available, only k8s.gcr.io/coredns.1.3.1 as is mentioned elsewhere throughout the release notes. So we'll use that.

@mboersma
Copy link
Member Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #876 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #876   +/-   ##
=======================================
  Coverage   68.29%   68.29%           
=======================================
  Files         115      115           
  Lines       16938    16938           
=======================================
  Hits        11567    11567           
  Misses       4613     4613           
  Partials      758      758

@mboersma
Copy link
Member Author

There was one failure on the first run. I'm rebasing from master now.

@mboersma
Copy link
Member Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackfrancis
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label Mar 25, 2019
@jackfrancis jackfrancis merged commit 5ce9196 into Azure:master Mar 25, 2019
@acs-bot
Copy link

acs-bot commented Mar 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma mentioned this pull request Mar 27, 2019
5 tasks
@mboersma mboersma deleted the add-k8s-1.14.0 branch March 29, 2019 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants