add test for error deserialization in op with param name 'models' #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
approved these changes
Nov 9, 2020
iscai-msft
commented
Nov 10, 2020
legacy/routes/errorStatusCodes.js
Outdated
| models_param = req.query['models'] | ||
| if (models_param == 'value1') { | ||
| res.status(500).json(sadCasper); | ||
| coverage['sendErrorWithParamNameModels']++; |
There was a problem hiding this comment.
make it optional, since this might be python specific
…into add_operation_with_error_model_and_param_model * 'master' of https://github.com/Azure/autorest.testserver: add test for first response no items, second response with items (#235)
lmazuel
approved these changes
Nov 10, 2020
iscai-msft
deleted the
add_operation_with_error_model_and_param_model
branch
iscai-msft
added a commit
that referenced
this pull request
Nov 11, 2020
…into special_paging * 'master' of https://github.com/Azure/autorest.testserver: add test for error deserialization in op with param name 'models' (#234) add test for first response no items, second response with items (#235)
|
I think if we are adding tests to the test server they should be useful for every language. This seems to be more of a python-specific test that other languages would have to implement without much benefit. I see two things we can do here:
|
|
I see @pakrym, sorry I merged this before you could comment. The more I read your message the more it makes sense. Opened an issue to transfer this to the autorest python repo (so far we don't have any swaggers specific to that repo so need to set that up). In the meantime, it's tagged as optional coverage, so it shouldn't break any languages if they choose not to implement it |
iscai-msft
added a commit
that referenced
this pull request
Nov 24, 2020
…into multiapi_diff_signatures * 'master' of https://github.com/Azure/autorest.testserver: Pass through program exit code when using start-autorest-express (#240) fix value retval (#237) add test for error deserialization in op with param name 'models' (#234) add test for first response no items, second response with items (#235) bump version after failing to in no op swagger addition (#231) add swagger for no operations (#230)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python ran into an issue for (error) model deserialization when our operation had an input parameter named
models.(python ex). Adding test to make sure other languages don't run into this conflict. Making this optional coverage, since right now it seems p specific to how python deserializes models. Other languages shouldn't have a problem passing the test though