Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement node labels #1346

Merged
merged 2 commits into from
Mar 4, 2020
Merged

implement node labels #1346

merged 2 commits into from
Mar 4, 2020

Conversation

xizha162
Copy link
Contributor

@xizha162 xizha162 commented Mar 3, 2020

Implement node labels. Bascially porting the same PR in official CLI:
Azure/azure-cli#12418

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/xizhamsft/azure-cli-extensions.git@xizha-nodelabels#subdirectory=src/$EXT&egg=$EXT"

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 4, 2020

aks

@yungezz
Copy link
Member

yungezz commented Mar 4, 2020

HI @xizhamsft could you pls sync with master branch then this PR ready to merge.

@yungezz yungezz merged commit e6976a4 into Azure:master Mar 4, 2020
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants