Add new child resources IPAM + VNV to existing CLI ext 'virtual-network-manager' #7989

danlope · 2024-09-17T20:49:04Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-09-17T20:49:07Z

❌Azure CLI Extensions Breaking Change Test

❌network-manager

rule cmd_name rule_message suggest_message

❌ 1010 - ParaPropUpdate network manager security-admin-config create cmd network manager security-admin-config create update parameter network_manager_name: updated property options from ['--name', '--network-manager-name', '-n'] to ['--manager-name', '--network-manager-name'] please change property options from ['--manager-name', '--network-manager-name'] to ['--name', '--network-manager-name', '-n'] for parameter network_manager_name of cmd network manager security-admin-config create

❌ 1010 - ParaPropUpdate network manager security-admin-config update cmd network manager security-admin-config update update parameter network_manager_name: updated property options from ['--name', '--network-manager-name', '-n'] to ['--manager-name', '--network-manager-name'] please change property options from ['--manager-name', '--network-manager-name'] to ['--name', '--network-manager-name', '-n'] for parameter network_manager_name of cmd network manager security-admin-config update

⚠️ 1011 - SubgroupAdd network manager ipam-pool sub group network manager ipam-pool added

⚠️ 1006 - ParaAdd network manager security-admin-config create cmd network manager security-admin-config create added parameter network_group_address_space_aggregation_option

⚠️ 1010 - ParaPropUpdate network manager security-admin-config create cmd network manager security-admin-config create update parameter configuration_name: updated property options from ['--configuration-name'] to ['--configuration-name', '--name', '-n']

⚠️ 1006 - ParaAdd network manager security-admin-config update cmd network manager security-admin-config update added parameter network_group_address_space_aggregation_option

⚠️ 1010 - ParaPropUpdate network manager security-admin-config update cmd network manager security-admin-config update update parameter configuration_name: updated property options from ['--configuration-name'] to ['--configuration-name', '--name', '-n']

⚠️ 1011 - SubgroupAdd network manager verifier-workspace sub group network manager verifier-workspace added

azure-client-tools-bot-prd · 2024-09-17T20:49:10Z

Hi @danlope,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2024-09-17T20:49:19Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2024-09-17T20:50:07Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

danlope · 2024-09-17T20:52:20Z

src/network-manager/azext_network_manager/tests/latest/test_network_scenario.py

                 checks=[self.check('access', 'Allow'),
                         self.check('direction', 'Inbound'),
-                         self.check('kind', 'Custom'),
+                         #self.check('kind', 'Custom'), # todo: not needed? 


todo: need 'kind'?

github-actions · 2024-09-17T20:53:17Z

Hi @danlope

Release Suggestions

Module: network-manager

Update VERSION to 2.0.0 in src/network-manager/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

danlope · 2024-09-17T20:56:48Z

src/network-manager/azext_network_manager/tests/latest/test_network_scenario.py

@@ -157,6 +158,7 @@ def test_network_manager_security_admin_config_crud(self, resource_group):
                 '--scope-accesses "SecurityAdmin" "Connectivity" '
                 '--network-manager-scopes subscriptions={sub} -l eastus2 --resource-group {rg}')

+        #todo


danlope · 2024-09-17T20:57:02Z

src/network-manager/azext_network_manager/tests/latest/test_network_scenario.py

@@ -213,19 +215,19 @@ def test_network_manager_admin_rule_crud(self, virtual_network, resource_group):
                 '--applies-to-groups network-group-id={sub}/resourceGroups/{rg}/providers/Microsoft.Network/networkManagers/{manager_name}/networkGroups/{group_name}')

        self.cmd('network manager security-admin-config rule-collection rule create -g {rg} --network-manager-name {manager_name} --configuration-name {config_name} --rule-collection-name {collection_name} '
-                 '--rule-name {rule_name} --kind "Custom" --protocol "Tcp" --access "Allow" --priority 32 --direction "Inbound"',
+                 '--rule-name {rule_name} --protocol "Tcp" --access "Allow" --priority 32 --direction "Inbound"',


todo: kind?

AllyW · 2024-09-19T08:00:38Z

❌Azure CLI Extensions Breaking Change Test

❌network-manager

rule
cmd_name
rule_message
suggest_message

❌ 1010 - ParaPropUpdate
network manager security-admin-config create
cmd network manager security-admin-config create update parameter network_manager_name: updated property options from ['--name', '--network-manager-name', '-n'] to ['--manager-name', '--network-manager-name']
please change property options from ['--manager-name', '--network-manager-name'] to ['--name', '--network-manager-name', '-n'] for parameter network_manager_name of cmd network manager security-admin-config create

❌ 1010 - ParaPropUpdate
network manager security-admin-config update
cmd network manager security-admin-config update update parameter network_manager_name: updated property options from ['--name', '--network-manager-name', '-n'] to ['--manager-name', '--network-manager-name']
please change property options from ['--manager-name', '--network-manager-name'] to ['--name', '--network-manager-name', '-n'] for parameter network_manager_name of cmd network manager security-admin-config update

⚠️ 1011 - SubgroupAdd
network manager ipam-pool
sub group network manager ipam-pool added

⚠️ 1006 - ParaAdd
network manager security-admin-config create
cmd network manager security-admin-config create added parameter network_group_address_space_aggregation_option

⚠️ 1010 - ParaPropUpdate
network manager security-admin-config create
cmd network manager security-admin-config create update parameter configuration_name: updated property options from ['--configuration-name'] to ['--configuration-name', '--name', '-n']

⚠️ 1006 - ParaAdd
network manager security-admin-config update
cmd network manager security-admin-config update added parameter network_group_address_space_aggregation_option

⚠️ 1010 - ParaPropUpdate
network manager security-admin-config update
cmd network manager security-admin-config update update parameter configuration_name: updated property options from ['--configuration-name'] to ['--configuration-name', '--name', '-n']

⚠️ 1011 - SubgroupAdd
network manager verifier-workspace
sub group network manager verifier-workspace added

@danlope your pr removed option -n for parameter network_manager_name of cmd network manager security-admin-config create. This is a breaking change and please confirm this change.

Tests passing for both IPAM and VNV

d19fbda

danlope requested review from necusjz, kairu-ms and jsntcy as code owners September 17, 2024 20:49

azure-client-tools-bot-prd bot added this to the September 2024 (2024-10-08) milestone Sep 17, 2024

microsoft-github-policy-service bot requested a review from yonzhan September 17, 2024 20:49

microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Sep 17, 2024

microsoft-github-policy-service bot assigned necusjz Sep 17, 2024

microsoft-github-policy-service bot added the Network label Sep 17, 2024

danlope commented Sep 17, 2024

View reviewed changes

revert routing changes

6ae6a2f

danlope commented Sep 17, 2024

View reviewed changes

danlope added 4 commits September 17, 2024 16:30

Merge branch 'main' into feature-ipam-vnv-2024-01-01-preview

077077f

update HISTORY.rst

b726c44

update version in HISTORY.rst

42707d3

corrected to prev version in HISTORY.rst

e0b8d82

AllyW added the preview release extension module as preview label Sep 19, 2024

AllyW added minor release extension module with version minor upgraded skip-cal-version and removed skip-cal-version preview release extension module as preview minor release extension module with version minor upgraded labels Sep 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new child resources IPAM + VNV to existing CLI ext 'virtual-network-manager' #7989

Add new child resources IPAM + VNV to existing CLI ext 'virtual-network-manager' #7989

danlope commented Sep 17, 2024

azure-client-tools-bot-prd bot commented Sep 17, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Sep 17, 2024

yonzhan commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

danlope Sep 17, 2024

github-actions bot commented Sep 17, 2024 •

edited

Loading

danlope Sep 17, 2024

danlope Sep 17, 2024

AllyW commented Sep 19, 2024

Add new child resources IPAM + VNV to existing CLI ext 'virtual-network-manager' #7989

Are you sure you want to change the base?

Add new child resources IPAM + VNV to existing CLI ext 'virtual-network-manager' #7989

Conversation

danlope commented Sep 17, 2024

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented Sep 17, 2024 • edited Loading

azure-client-tools-bot-prd bot commented Sep 17, 2024

yonzhan commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

CodeGen Tools Feedback Collection

danlope Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 17, 2024 • edited Loading

Release Suggestions

Module: network-manager

Notes

danlope Sep 17, 2024

Choose a reason for hiding this comment

danlope Sep 17, 2024

Choose a reason for hiding this comment

AllyW commented Sep 19, 2024

azure-client-tools-bot-prd bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading