Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email communication service - Send command - added an optional parameter wait-until and added a new command get email request status. #8005

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

v-vprasannak
Copy link
Contributor

Email communication service -

  1. Send command added an optional parameter "wait-until".
  2. Added command to get email request status

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

1. Send command added an optional parameter "waitUntil".
2. Added command to get email request status
Copy link

azure-client-tools-bot-prd bot commented Sep 20, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️communication
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd communication email send cmd communication email send added parameter waitUntil
⚠️ 1011 - SubgroupAdd communication email status sub group communication email status added

Copy link

Hi @v-vprasannak,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 20, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 20, 2024
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Sep 20, 2024

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 20, 2024
}
}

operationId = str(uuid.uuid4())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we accept an operation id from the client today?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are accepting an operation ID from the client. However, to support the "wait until" parameter, the operation ID is not displayed in the result when the operation is initiated. Therefore, we are generating the operation ID programmatically.

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants