Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} set the node vm size to empty string when the cluster sku name is automatic #8007

Open
wants to merge 55 commits into
base: main
Choose a base branch
from

Conversation

xmzhao0822
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create -g -n --sku automatic

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Sep 20, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@xmzhao0822 xmzhao0822 changed the title Set the node vm size to empty string when the cluster sku name is automatic {AKS} Set the node vm size to empty string when the cluster sku name is automatic Sep 20, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 20, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@xmzhao0822 xmzhao0822 changed the title {AKS} Set the node vm size to empty string when the cluster sku name is automatic {AKS} set the node vm size to empty string when the cluster sku name is automatic Sep 20, 2024
Copy link

@xmzhao0822
Copy link
Contributor Author

Note: The failing check doesn't seem that due to my code change. I tested when I pulled the latest main branch and run command azdev style azext_aks_preview without any code change, it also throws some errors like this:

************* Module azext_aks_preview.aks_diagnostics
azure-cli-extensions/src/aks-preview/azext_aks_preview/aks_diagnostics.py:48:0: R0917: Too many positional arguments (10/5) (too-many-positional-arguments)
azure-cli-extensions/src/aks-preview/azext_aks_preview/aks_diagnostics.py:258:0: R0917: Too many positional arguments (9/5) (too-many-positional-arguments)
************* Module azext_aks_preview.custom
azure-cli-extensions/src/aks-preview/azext_aks_preview/custom.py:205:0: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
azure-cli-extensions/src/aks-preview/azext_aks_preview/custom.py:262:0: R0917: Too many positional arguments (19/5) (too-many-positional-arguments)

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Queued live test to validate the change, test passed!

  • test_aks_automatic_sku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants