Skip to content

Commit

Permalink
[App Config] BREAKING CHANGE: Support app service slots (#20850)
Browse files Browse the repository at this point in the history
* [AppConfig] Support app service slots

* Restore deleted line

* Testing

* Testing recording

Co-authored-by: Jason Anderson <jason.ra@microsoft.com>
  • Loading branch information
Jasonra102 and Jason Anderson committed Jan 4, 2022
1 parent 42bedd5 commit b857fa3
Show file tree
Hide file tree
Showing 3 changed files with 1,171 additions and 1,987 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -404,8 +404,9 @@ def __read_kv_from_app_service(cmd, appservice_account, prefix_to_add="", conten
try:
key_values = []
from azure.cli.command_modules.appservice.custom import get_app_settings
slot = appservice_account.get('resource_name') if appservice_account.get('resource_type') == 'slots' else None
settings = get_app_settings(
cmd, resource_group_name=appservice_account["resource_group"], name=appservice_account["name"], slot=None)
cmd, resource_group_name=appservice_account["resource_group"], name=appservice_account["name"], slot=slot)
for item in settings:
key = prefix_to_add + item['name']
if validate_import_key(key):
Expand Down Expand Up @@ -485,9 +486,10 @@ def __write_kv_to_app_service(cmd, key_values, appservice_account):
else:
non_slot_settings.append(name + '=' + value)
# known issue 4/26: with in-place update, AppService could change slot-setting true/false incorrectly
slot = appservice_account.get('resource_name') if appservice_account.get('resource_type') == 'slots' else None
from azure.cli.command_modules.appservice.custom import update_app_settings
update_app_settings(cmd, resource_group_name=appservice_account["resource_group"],
name=appservice_account["name"], settings=non_slot_settings, slot_settings=slot_settings)
name=appservice_account["name"], settings=non_slot_settings, slot_settings=slot_settings, slot=slot)
except Exception as exception:
raise CLIError("Failed to write key-values to appservice: " + str(exception))

Expand Down
Loading

0 comments on commit b857fa3

Please sign in to comment.