Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trusted Launch - DiskRP CLI #17599

Closed
khyewei opened this issue Apr 7, 2021 · 13 comments · Fixed by #17775
Closed

Trusted Launch - DiskRP CLI #17599

khyewei opened this issue Apr 7, 2021 · 13 comments · Fixed by #17775
Assignees
@qwordy
Labels
Compute az vm/vmss/image/disk/snapshot feature-request Service Team Support Request

Comments

@khyewei
Copy link

khyewei commented Apr 7, 2021

Resource Provider
Microsoft.compute\disk

Description of Feature or Work Requested
Release DiskRP CLI for Trusted Launch public preview.

// more details on SecurityType

Minimum API Version Required
2020-12

Swagger Link
Azure/azure-rest-api-specs#12796

Target Date
ASAP
@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Apr 7, 2021
@yungezz
Copy link
Member

yungezz commented Apr 8, 2021

#16692

@yungezz yungezz added the Compute az vm/vmss/image/disk/snapshot label Apr 8, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Apr 8, 2021
@xfz11 xfz11 assigned qwordy and unassigned xfz11 Apr 12, 2021
@qwordy
Copy link
Member

qwordy commented Apr 19, 2021

@khyewei I provide two solutions.
(1) --security-type, enum type, value is TrustedLaunch
(2) --enable-trusted-launch, bool type, value is true or false
Which one do you prefer? If there are more security types in the future, (1) is better.

@khyewei
Copy link
Author

khyewei commented Apr 19, 2021

(1) --security-type, enum, value: TrustedLaunch

cc: @anshulsolanki21

@qwordy
Copy link
Member

qwordy commented Apr 20, 2021

@khyewei I got an error. Could you have a look? Thanks!

azure.core.pipeline.policies._universal: Request URL: 'https://management.azure.com/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/fy/providers/Microsoft.Compute/disks/d5?api-version=2020-12-01'
azure.core.pipeline.policies._universal: Request method: 'PUT'
azure.core.pipeline.policies._universal: Request body:
azure.core.pipeline.policies._universal: {"location": "westus", "tags": {}, "sku": {"name": "Premium_LRS"}, "properties": {"creationData": {"createOption": "FromImage", "imageReference": {"id": "/Subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/Providers/Microsoft.Compute/Locations/westus/Publishers/Canonical/ArtifactTypes/VMImage/Offers/UbuntuServer/Skus/18.04-LTS/Versions/18.04.202002180"}}, "securityProfile": {"securityType": "TrustedLaunch"}}}
azure.core.pipeline.policies._universal: Response content:
azure.core.pipeline.policies._universal: {
  "error": {
    "code": "InvalidParameter",
    "message": "The value of parameter securityType is invalid.",
    "target": "securityType"
  }
}

@qwordy qwordy mentioned this issue Apr 20, 2021
Merged
3 tasks
@khyewei
Copy link
Author

khyewei commented Apr 20, 2021 via email

@khyewei
Copy link
Author

khyewei commented Apr 20, 2021 via email

@khyewei
Copy link
Author

khyewei commented Apr 20, 2021 via email

@qwordy
Copy link
Member

qwordy commented Apr 21, 2021

Thank you @khyewei. I got same error. I used Ubuntu 18.04 latest version and set Hyper V generation to V2.

azure.core.pipeline.policies._universal: Request body:
azure.core.pipeline.policies._universal: {"location": "westus", "tags": {}, "sku": {"name": "Premium_LRS"}, "properties": {"hyperVGeneration": "V2", "creationData": {"createOption": "FromImage", "imageReference": {"id": "/Subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/Providers/Microsoft.Compute/Locations/westus/Publishers/Canonical/ArtifactTypes/VMImage/Offers/UbuntuServer/Skus/18.04-LTS/Versions/18.04.202104150"}}, "securityProfile": {"securityType": "TrustedLaunch"}}}

@khyewei
Copy link
Author

khyewei commented Apr 21, 2021 via email

@khyewei
Copy link
Author

khyewei commented Apr 21, 2021 via email

@khyewei
Copy link
Author

khyewei commented Apr 21, 2021 via email

@khyewei
Copy link
Author

khyewei commented Apr 22, 2021 via email

@khyewei
Copy link
Author

khyewei commented Apr 22, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwordy qwordy

Labels
Compute az vm/vmss/image/disk/snapshot feature-request Service Team Support Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Compute] disk create: Trusted launch; [Compute] disk create: Hibernation qwordy/azure-cli
4 participants
@qwordy @yungezz @khyewei @xfz11