{ACS} az aks create/update: Add parameter --auto-upgrade-channel to support auto upgrade
#18825
Conversation
charliedmcb
requested review from
andyliuliming,
Juliehzl,
zhoxing-ms and
zqingqing1
as code owners
charliedmcb
changed the title
|
acs |
charliedmcb
changed the title
zhoxing-ms
changed the title
zhoxing-ms
changed the title
| @@ -202,6 +203,7 @@ def load_arguments(self, _): | |||
| validator=validate_load_balancer_idle_timeout) | |||
| c.argument('outbound_type', arg_type=get_enum_type([CONST_OUTBOUND_TYPE_LOAD_BALANCER, | |||
| CONST_OUTBOUND_TYPE_USER_DEFINED_ROUTING])) | |||
| c.argument('auto_upgrade_channel', arg_type=get_enum_type([CONST_RAPID_UPGRADE_CHANNEL, CONST_STABLE_UPGRADE_CHANNEL, CONST_PATCH_UPGRADE_CHANNEL, CONST_NODE_IMAGE_UPGRADE_CHANNEL, CONST_NONE_UPGRADE_CHANNEL])) | |||
There was a problem hiding this comment.
Do we need to declare the default value here? Such as
arg_type=get_enum_type(...),..., default='xxx'
There was a problem hiding this comment.
@xhl873, assuming the answer is no. There was no default before.
There was a problem hiding this comment.
Can we use upgrade channel none as the default?
There was a problem hiding this comment.
So, nil is used for unspecified, and upgrade channel none is used if the customer wants to turn it off.
We could make upgrade channel none the default for create, since there is nothing it would be turning off, but for update adding upgrade channel none as the default would make any update call turn off autoupgrade for the customer unless they specified it on each call.
I talked with Xiahe about this as we agreed that just adding a default like this for create did not make sense.
There was a problem hiding this comment.
The updated model includes an enum value for unspecified
There was a problem hiding this comment.
I could see making unspecified the default. Although, rejecting nil in place of a new unspecified value at this point would still break the preview CLI, and current behavior of the REST API if customers were using it directly. (ok, because autoupgrader is not GA yet?)
There was a problem hiding this comment.
Also, using unspecified over nil adds another channel to track where nil could be used, but I get the argument around removing the reliance on nil values.
There was a problem hiding this comment.
Not sure it matters too much, we can convert the nil to unspecified in RP ( or keep using nil )
zhoxing-ms
changed the title
az aks create/update: Add parameter --auto-upgrade-channel to support auto upgrade
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@charliedmcb Could you please resolve the CLI style issue? |
|
Please solve these comments and CI issues in time today, otherwise this PR will miss the release of this sprint and can only be released in the next sprint (09-07) |
…aderToCLI"" This reverts commit ec9cd69.
…aderToCLI"" This reverts commit 0ef331c.
…AutoupgraderToCLI""" This reverts commit cd47cb0.
…b/addingAutoupgraderToCLI"""" This reverts commit 8d8f80f.
This reverts commit 71456b1.
This reverts commit da3ff65.
This reverts commit ed4e903.
This reverts commit 71456b1.
|
Plan to have this ready for review tomorrow |
|
@zhoxing-ms after this commit, all the "update" scenario will be broken for our AKS. |
…hannel` to support auto upgrade (Azure#18825)" This reverts commit 6918b29.
zhoxing-ms
changed the title
az aks create/update: Add parameter --auto-upgrade-channel to support auto upgradeaz aks create/update: Add parameter --auto-upgrade-channel to support auto upgrade
… crash with latest RP (Azure#19293)" This reverts commit 1660877.
…grade-channel to support auto upgrade (with fix) (#19297) redo auto upgrade channel change.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.