[Packaging] Add CI job to build Mariner RPM #20584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The artifact won't be built because Build.Reason doesn't include |
Sure .. Updating :) also this wont work as we are blocked on:
|
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
mfrw
force-pushed
the
mfrw/create-mariner-rpm
branch
from
216f2da
to
36bcb23
Compare
jiasli
reviewed
Dec 2, 2021
3 tasks
jiasli
changed the title
jiasli
reviewed
Dec 6, 2021
Comment on lines
+682
to
+696
| - job: BuildYumPackageMariner | ||
| displayName: Build Yum Package Mariner | ||
| pool: | ||
| vmImage: 'ubuntu-20.04' | ||
| steps: | ||
| - task: Bash@3 | ||
| displayName: 'Build Rpm Package: Mariner' | ||
| inputs: | ||
| targetType: 'filePath' | ||
| filePath: scripts/release/rpm/pipeline_mariner.sh | ||
| - task: PublishPipelineArtifact@0 | ||
| displayName: 'Publish Artifact: yum-mariner' | ||
| inputs: | ||
| TargetPath: $(Build.ArtifactStagingDirectory) | ||
| ArtifactName: yum-mariner |
There was a problem hiding this comment.
To be honest, I dislike using yum and rpm interchangeably (as it already is). This makes it difficult to understand for newcomers.
jiasli
approved these changes
Dec 6, 2021
wangzelin007
approved these changes
Dec 6, 2021
jiasli
pushed a commit
to jiasli/azure-cli
that referenced
this pull request
Dec 6, 2021
(cherry picked from commit a7ca2bf)
|
Thank you @jiasli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Muhammad Falak R Wani falakreyaz@gmail.com
Description
Adds a new build step in the CI to create Mariner RPM.
Testing Guide
Tested the script locally.
History Notes
Add Build job in CI for Mariner Rpm.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.
This PR Depends on:
%{_lib}tolib64#20574