[App Service] az staticwebapp functions link: Add new parameter --environment-name to support setting the environment name of static site

[tobiasdiez]

Related command

az staticwebapp functions link

Description

Currently, az staticwebapp functions link doesn't provide a way to link a certain environment/deployment slot to an existing function app. This functionality is however available through the web interface, and with this PR will be also available through the cli.

Testing Guide

Run az staticwebapp functions link as you normally would, but with an additional argument environment-name parameter. Afterwards, the function app should be linked only to that environment.

Note: I've not yet managed to test this myself, since I was running the code in codespaces and had troubles with the authentication.

History Notes

[Appservice] az staticwebapp functions link: Add environment-name parameter

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

• I adhere to the Error Handling Guidelines.

[ghost]

Thank you for your contribution tobiasdiez! We will review the pull request and get back to you soon.

[yonzhan]

Appservice

[StrawnSC]

@tobiasdiez, did you try running the rewritten command locally? When I try it, fails with the exception TypeError: request() got an unexpected keyword argument 'environment_name'.
It looks like the SDK function begin_register_user_provided_function_app_with_static_site doesn't take an environment_name parameter. You would need to find a different SDK function that takes a parameter for the environment

[tobiasdiez]

Thanks for testing it. I have to admit I couldn't figure out how to test the change myself. How does one do it?

For the SDK function, the parameter environment_name is available, at least in the more recent versions:
https://github.com/Azure/azure-sdk-for-python/blob/7eeaca97c41bc18ec66f325eef5e6910efde6e12/sdk/appservice/azure-mgmt-web/azure/mgmt/web/v2022_03_01/aio/operations/_static_sites_operations.py#L1882

Edit: I overlooked that the function with the _build suffix is needed. Fixed now.

[zhoxing-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[zhoxing-ms]

@tobiasdiez Could you please resolve those CI issues?

[zhoxing-ms]

@mock.patch("azure.cli.command_modules.appservice.static_sites.show_app")

def test_functions_link(self, *args, **kwargs):
functionapp_name = "functionapp"
functionapp_resource_id = "/subscriptions/sub/resourceGroups/{}/providers/Microsoft.Web/sites/{}".format(
self.rg1, functionapp_name
)
link_user_function(self.mock_cmd, self.name1, self.rg1, functionapp_resource_id)
E TypeError: link_user_function() missing 1 required positional argument: 'environment_name'

@tobiasdiez Could you please resolve the CI issues?

[tobiasdiez]

Oh, I missed that one. Should be fixed now.

[zhoxing-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[StrawnSC]

Looks good to me, but we should commit @zhoxing-ms's suggestion and fix the CI

[zhoxing-ms]

@tobiasdiez Any update? Please note that since we will launch the release of this sprint the day after tomorrow. If you cannot address all the comments tomorrow, we will have to postpone the release of this PR to the next sprint (02-07)

[tobiasdiez]

Sorry for the late reaction and thanks @zhoxing-ms for the reminder. I've now committed your suggestion, so hopefully it should be ready to go now!

[zhoxing-ms]

@StrawnSC Could you please help review this PR again? If there are no other questions here, please help approve it