Refactor session state storage #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yugangw-msft Here's my updated version of the session state storage |
|
@BurtBiel thanks. The change look good, but let us chat to see whether it can incorporate with my commit for account management, because we are updating same file with similar functionalities :-) |
|
Yugang also did refactoring work in this file and it doesn't make sense to reset his work for this change. Closing PR |
derekbekoe
pushed a commit
that referenced
this pull request
Feb 7, 2017
* Add batch data plane commands: -- Add custom commands -- Add auto execution data plane codes -- Import mgmt commands experience * Added file stream support * bug fixes * Fixed regex raw strings * Added support for JSON input * Custom and type validation (#4) * Additional validation and parsing * Some cleanups * Minor code refinements * Fix pylint errors and get rid unused codes. * List and type validation (#5) * list and type validation * Remove auth kwargs * Fixed typo * clean pylint error and add data plane command test. * Bug fixes (#6) * Remove auth kwargs * Bug fixes * Fixed kwargs * Move the update pool command to custom command. * Add custom commands test cases * Tests and delete confirmation (#7) * Added some tests * Bug fixes * Added tests to sln * Delete confirmation * Some pylint cleanup * More tests and fixes (#8) * Fix pylint and test errors. * Following PEP8 complaint. * Use this decroator on doc transfer * Deferred imports for performance (#9) * streamlined imports * pylint fixes * Renamed AzureDataPlaneCommand * PyLint and PEP8 clean up. * Use single parameter for storage account id and name. * Review feedback + help fixes (#10) * node-user -> node user * Review feedback * More feedback fixes * pep fixes * fixed underscore * More touch ups * Review fixes (#11) * Command refinements * More command feedback * Test fixes * More tests * Add enum list for vmsize and thumbprint algorithm. * Streamlined commands (#13) * streamlined commands * Updated tests * Fixed arg loading test * Further command refinements (#14) * support silent args * Fixed pool error message * Further command editing * last fixes * Fixed tests (#15) * Change the coding style.
tibortakacs
added a commit
to tibortakacs/azure-cli
that referenced
this pull request
Aug 7, 2020
* Only use credential cache if it is available * Pass tenant id to Identity properly * Use the client id and scopes properly in client factory * Accept single string scope (not a bug but good to have) Co-authored-by: Tibor Takacs <titakac@microsoft.com>
DaeunYim
added a commit
to DaeunYim/azure-cli
that referenced
this pull request
Sep 9, 2020
sterling local context update and more meru test scenarios added
Closed
ReaNAiveD
pushed a commit
to ReaNAiveD/azure-cli
that referenced
this pull request
Nov 17, 2023
…mentdb [Add] Add command group `microsoft.documentdb/databaseaccounts`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed profile class in favor of methods, updated commands to reference new format