Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization: Fixes DocumentClientException being thrown on write operations #1909

Merged
merged 3 commits into from
Oct 6, 2020

Conversation

ealsur
Copy link
Member

@ealsur ealsur commented Oct 6, 2020

Pull Request Template

Description

When a wrong key is used for a Write operation, the client was throwing a DocumentClientException instead of a CosmosException.

Read path was not being affected (it was correctly throwing CosmosException).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Closing issues

Closes #1906

@ealsur ealsur added the bug Something isn't working label Oct 6, 2020
@ealsur ealsur self-assigned this Oct 6, 2020
@ealsur
Copy link
Member Author

ealsur commented Oct 6, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@j82w j82w merged commit 67a2c58 into master Oct 6, 2020
@j82w j82w deleted the users/ealsur/authfix branch October 6, 2020 21:37
@ghost
Copy link

ghost commented Dec 15, 2021

Closing due to in-activity, pease feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CosmosClient with wrong key throws DocumentClientException instead of CosmosException
2 participants