-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] OpenTelemetry: Adds diagnostics for network level requests #3718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
aavasthy
changed the title
[Internal] Open Telemetry: Adding diagnostics for network level requests
[Internal] OpenTelemetry: Adding diagnostics for network level requests
Feb 21, 2023
aavasthy
changed the title
[Internal] OpenTelemetry: Adding diagnostics for network level requests
[Internal] OpenTelemetry: Adds diagnostics for network level requests
Feb 21, 2023
sourabh1007
reviewed
Feb 21, 2023
sourabh1007
reviewed
Feb 21, 2023
Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs
Outdated
Show resolved
Hide resolved
sourabh1007
reviewed
Feb 21, 2023
…://github.com/Azure/azure-cosmos-dotnet-v3 into users/aavasthy/distributedTracing_diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR adds open telemetry support to the SDK for network level requests for both HTTP and TCP requests.
It adds Operation level ActivityId(Parent id for network level activities) as part of diagnostics log.
This is a draft PR and would have the following once updated Direct package is included:
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #3459