-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initializing Dockerfile for .NET isolated project does not honor existing TFM #3800
Initializing Dockerfile for .NET isolated project does not honor existing TFM #3800
Conversation
…ting TFM (#3771) -> Add Check for dotnet worker runtime and get the targetframework from the FunctionApp root directory.
Can we please add tests for this code path as well? I understand we don't have existing test for this action. but you should be able to create one similar to the StartHostActionTests and other action tests. |
Get the Project Root Element from the ProjectFile Path and gets the value of Target Framework
Hi @kshyju, I saw some tests are added in the InitTests.cs class (contains all cli test cases of Init action) for the Init action. Do I need to create a new class similar to StartHostActionTests to add tests or need to add it the InitTests.cs? |
Oh okay, then you can add to the existing test file. |
Hi @kshyju added tests for my changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please tweak DetermineTargetFramework
method as needed and use that.
Hi @kshyju done changes in DetermineTargetFramework method by adding optional parameter (ProjectFileName) to it. |
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more minor comments.
Hi @kshyju, review the changes for the latest commit |
Issue describing the changes in this PR
resolves #3771
-> This PR checks the current worker runtime of function app is dotnet and gets the target framework from the directory of function app, locating to the project file(.csproj). later in the method used to configure the Docker file
Pull request checklist