adding prop and condition for OperationalInsightsEndpointResourceId #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nickcandy
reviewed
Apr 16, 2024
added 2 commits
April 16, 2024 11:32
…ndrewpethel/azure-powershell-common into feature/SilverXPRegionAgnostic
Nickcandy
previously approved these changes
Apr 16, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Nickcandy
reviewed
Apr 17, 2024
msJinLei
requested changes
Apr 17, 2024
msJinLei
approved these changes
May 9, 2024
isra-fel
approved these changes
May 9, 2024
There was a problem hiding this comment.
@andrewpethel thanks a lot for the contribution! This will be included in the upcoming milestone.
|
[heart] Ryan Pethel reacted to your message:
…________________________________
From: Jin Lei ***@***.***>
Sent: Thursday, May 9, 2024 6:06:52 AM
To: Azure/azure-powershell-common ***@***.***>
Cc: Ryan Pethel ***@***.***>; Author ***@***.***>
Subject: Re: [Azure/azure-powershell-common] adding prop and condition for OperationalInsightsEndpointResourceId (PR #414)
@msJinLei approved this pull request.
—
Reply to this email directly, view it on GitHub<#414 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A62P5UWY2DWS3O3TWIUAF5LZBMG7ZAVCNFSM6AAAAABFXGREV2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBXGIYTCOJWHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task:
Update Azure.PowerShell.Common so that the Add-AzEnvironment auto discovery feature is agnostic for Sovereign Clouds.
Problem Description:
The cmdlet's current implementation relies on the ExtendedProperties setting the OperationalInsightsEndpoint on the active AzureEnvironment. For user-added environments, such as those added via Add-AzEnvironment, both the -OperationalInsightsEndpoint and -OperationalInsightsEndpointResourceID parameters must be defined for the Invoke command to work. This requirement is documented, but could be clearer and more user-friendly.
Proposed Solution:
This PR updates the MapArmToAzureEnvironment method to auto-populate the OperationalInsightsEndpoint and OperationalInsightsEndpointResourceId values, following a pattern similar to Synapse. This update would leverage the auto-discovery feature used with Add-AzEnvironment. By implementing this change, we can improve the robustness of the cmdlet and enhance the user experience for those working with custom Azure environments, namely Sovereign Clouds.
All tests pass (updated screenshot -- April 24, 2024):