Add new properties in the IOutputSanitizer #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeryEarly
reviewed
Jul 22, 2024
| namespace Microsoft.WindowsAzure.Commands.Common.Sanitizer | ||
| { | ||
| public interface IOutputSanitizer | ||
| { | ||
| bool RequireSecretsDetection { get; } | ||
|
|
||
| IEnumerable<string> IgnoredModules { get; } |
There was a problem hiding this comment.
why IEnumerable not HashSet?
There was a problem hiding this comment.
Just want to keep the interface definition more flexible and enumeration is the necessary feature of the collection. In the implementation, I will use string array instead as IgnoredModules and IgnoredCmdlets are both small lists while HashSet is efficient for large list and looks like a bit heavy for this scenario.
VeryEarly
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IgnoredModules and IgnoredCmdlets to bypass unnecessary modules and/or cmdlets for secrets detection.