Set UserAgent for ARM telemetry #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
approved these changes
Aug 22, 2024
| AzureSession.Instance.ClientFactory.AddUserAgent(hostEnv); | ||
| } | ||
| } | ||
| catch (Exception) |
There was a problem hiding this comment.
If we are try-catch AddUserAgent(), does it make sense to wrap all AddUserAgent() calls in it?
There was a problem hiding this comment.
If we are try-catch
AddUserAgent(), does it make sense to wrap allAddUserAgent()calls in it?
Here is AzureSession.Instance.ClientFactory.AddUserAgent(hostEnv);. Below is ClientFactory.RemoveUserAgent(hostEnv);. The Client part is UserAgent += string.Format(" {0}", hostEnv); I can't merge them together.
dolauli
approved these changes
Aug 23, 2024
YanaXu
commented
Aug 23, 2024
| AzureSession.Instance.ClientFactory.RemoveUserAgent(hostEnv); | ||
| } | ||
| } | ||
| catch (Exception) |
There was a problem hiding this comment.
I add a catch here just in case the env var is not OK for setting UserAgent, we'll ignore it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to set UserAgent for ARM request in case of SDK-based cmdlets.
And it fixes the bug of dumplicated CommandName and ParameterSetName.