Virtual Network Gateway NAT feature changes #14685

Khushboo-Baheti · 2021-04-05T18:07:39Z

Description

In Virtual Network Gateway deployments a customer might have hundreds of connections. Due to various reasons such as merger & acquisition or reseller hosting, multiple of these connections might have duplicate IP Address ranges configured. There are also scenarios where customers prefer to hide branch address range from other branches. These customer scenarios can be addressed with Source NAT transforms at any of the On-premise that connects to a virtual network Gateway. For NAT’ing the On-premise branches (Locla Network Gateways), the customer may apply NAT config at the Connection level and for NAT’ing the VNET ranges the customer may apply the NAT config at the Virtual Network Gateway level.

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  - https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/884
- the markdown help files have been regenerated using the commands listed here

This reverts commit 8dbb8a2.

BethanyZhou · 2021-04-06T06:34:37Z

Hi @Khushboo-Baheti , our CI failed due to following build errors.

D:\a\1\s\src\Network\Network\VirtualNetworkGateway\VirtualNetworkGatewayNatRule\VirtualNetworkGatewayNatRuleBaseCmdlet.cs(38,106): error CS0234: The type or namespace name 'VirtualNetworkGatewayNatRule' does not exist in the namespace 'Microsoft.Azure.Management.Network.Models' (are you missing an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
D:\a\1\s\src\Network\Network\VirtualNetworkGateway\VirtualNetworkGatewayNatRule\VirtualNetworkGatewayNatRuleBaseCmdlet.cs(30,16): error CS0246: The type or namespace name 'IVirtualNetworkGatewayNatRulesOperations' could not be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]

I suspect upgrading sdk to newest one will fix these errors, could you have a look?

Khushboo-Baheti · 2021-04-06T23:27:34Z

Hi @Khushboo-Baheti , our CI failed due to following build errors.

D:\a\1\s\src\Network\Network\VirtualNetworkGateway\VirtualNetworkGatewayNatRule\VirtualNetworkGatewayNatRuleBaseCmdlet.cs(38,106): error CS0234: The type or namespace name 'VirtualNetworkGatewayNatRule' does not exist in the namespace 'Microsoft.Azure.Management.Network.Models' (are you missing an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
D:\a\1\s\src\Network\Network\VirtualNetworkGateway\VirtualNetworkGatewayNatRule\VirtualNetworkGatewayNatRuleBaseCmdlet.cs(30,16): error CS0246: The type or namespace name 'IVirtualNetworkGatewayNatRulesOperations' could not be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]

I suspect upgrading sdk to newest one will fix these errors, could you have a look?

@BethanyZhou Yes upgrading SDK will fix this I used unsigned SDK build for local testing - https://dev.azure.com/nrp-swagger/swagger-stack/_build/results?buildId=272&view=results My SDK changes - https://github.com/Azure/azure-rest-api-specs/pull/13481/files
I am not sure how to update published SDK for Network-February-Release. Can you please help me here

BethanyZhou · 2021-04-07T08:49:57Z

@Satya-anshu is uploading a unsigned SDK as local feed. I believe merging network-february into your branch could help you case if the SDK is uploaded.

This reverts commit 7f69613.

Khushboo-Baheti · 2021-04-08T19:16:56Z

Thanks a lot @BethanyZhou for guiding @Satya-anshu SDK doesn't have my changes. I have updated local-feed with the latest SDK. I have updated Network.CSproj and NetworkTest.CSProj Do I need to update any other files ?

BethanyZhou · 2021-04-09T02:12:28Z

@Khushboo-Baheti , Sure, please update all files referred to this SDK.

Khushboo-Baheti · 2021-04-10T06:26:43Z

@BethanyZhou I have updated PRs with all the required changes. Can you please look into this. Thanks

BethanyZhou · 2021-04-12T04:46:34Z

Hi @Khushboo-Baheti , please suppress following issues in /tools/StaticAnalysis/Exceptions/Az.Network/SignatureIssues.csv

"D:\a\1\s\artifacts\Debug\Az.Network\Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.VirtualNetworkGateway.NewAzureVirtualNetworkGatewayNatRule","New-AzVirtualNetworkGatewayNatRule","1","8100","New-AzVirtualNetworkGatewayNatRule Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
"D:\a\1\s\artifacts\Debug\Az.Network\Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.VirtualNetworkGateway.UpdateAzureVirtualNetworkGatewayNatRule","Update-AzVirtualNetworkGatewayNatRule","1","8100","Update-AzVirtualNetworkGatewayNatRule Does not support ShouldProcess but the cmdlet verb Update indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"

BethanyZhou

There needs further discussion about EnableBgpRouteTranslationForNatFlag and DisableBgpRouteTranslationForNatFlag, please go back to https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/884 and take a look

Khushboo-Baheti · 2021-04-13T00:31:29Z

@BethanyZhou 2 of the checks are failing with following error and I am not sure how to fix this. Can you please help - 2021-04-12T20:45:44.9752026Z Segmentation fault (core dumped)
2021-04-12T20:45:44.9847054Z /home/vsts/work/1/s/build.proj(182,5): error MSB3073: The command "dotnet sln /home/vsts/work/1/s/artifacts/Azure.PowerShell.sln add "/home/vsts/work/1/s/src/RecoveryServices/RecoveryServices/RecoveryServices.csproj"" exited with code 139.
2021-04-12T20:45:45.0181779Z ##[error]Error: The process '/usr/bin/dotnet' failed with exit code 1
2021-04-12T20:45:45.0204032Z Info: Azure Pipelines hosted agents have been updated and now contain .Net 5.x SDK/Runtime along with the older .Net Core version which are currently lts. Unless you have locked down a SDK version for your project(s), 5.x SDK might be picked up which might have breaking behavior as compared to previous versions. You can learn more about the breaking changes here: https://docs.microsoft.com/en-us/dotnet/core/tools/ and https://docs.microsoft.com/en-us/dotnet/core/compatibility/ . To learn about more such changes and troubleshoot, refer here: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/build/dotnet-core-cli?view=azure-devops#troubleshooting

Khushboo-Baheti · 2021-04-13T00:32:29Z

There needs further discussion about EnableBgpRouteTranslationForNatFlag and DisableBgpRouteTranslationForNatFlag, please go back to Azure/azure-powershell-cmdlet-review-pr#884 and take a look

I have updated issue and also updated this PR as per your suggestions. Thanks

BethanyZhou · 2021-04-14T02:06:56Z

src/Network/Network/VirtualNetworkGateway/UpdateAzureVirtualNetworkGatewayCommand.cs

+
+        [Parameter(
+            Mandatory = false,
+            HelpMessage = "Flag to enable and disable BgpRouteTranslationForNat on this VirtualNetworkGateway.")]


I believe its help message should be updated also.

@BethanyZhou I have updated help message as per your suggestion. Thanks

BethanyZhou · 2021-04-14T02:10:56Z

@BethanyZhou Beisi Zhou FTE 2 of the checks are failing with following error and I am not sure how to fix this. Can you please help - 2021-04-12T20:45:44.9752026Z Segmentation fault (core dumped)
2021-04-12T20:45:44.9847054Z /home/vsts/work/1/s/build.proj(182,5): error MSB3073: The command "dotnet sln /home/vsts/work/1/s/artifacts/Azure.PowerShell.sln add "/home/vsts/work/1/s/src/RecoveryServices/RecoveryServices/RecoveryServices.csproj"" exited with code 139.
2021-04-12T20:45:45.0181779Z ##[error]Error: The process '/usr/bin/dotnet' failed with exit code 1
2021-04-12T20:45:45.0204032Z Info: Azure Pipelines hosted agents have been updated and now contain .Net 5.x SDK/Runtime along with the older .Net Core version which are currently lts. Unless you have locked down a SDK version for your project(s), 5.x SDK might be picked up which might have breaking behavior as compared to previous versions. You can learn more about the breaking changes here: https://docs.microsoft.com/en-us/dotnet/core/tools/ and https://docs.microsoft.com/en-us/dotnet/core/compatibility/ . To learn about more such changes and troubleshoot, refer here: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/build/dotnet-core-cli?view=azure-devops#troubleshooting

Forget about Segmentation fault. This is a known and random issue about the environment of our CI pipelines. Just use /azp run to restart all pipelines.

BethanyZhou

LGTM

Khushboo-Baheti · 2021-04-14T18:05:05Z

Thanks @BethanyZhou for approval. Please let me know if anything is required by my side. Do I need to ping all reviewers and take approval from them ?

BethanyZhou · 2021-04-15T02:09:56Z

@Khushboo-Baheti Will merge

erich-wang · 2021-04-15T02:15:02Z

Force merge due of known CI issue.

…ection in ResourceGraph (#15165) * Onboard DigitalTwins to Private Link Common Cmdlets (#14613) * Onboard DigitalTwins to Private Link Common Cmdlets * Removed the change log * Added DigitalTwins in lexicographical order * Adding Private Range (No SNAT) Support to Firewall Policies (#14577) * Add Azure Route Server CRUD cmdlets to deprecate Virtual Router cmdlets (#14036) * change name from virtual router to route server * add test records * fix warning * delete unused import * no snat private ranges * adding private range in firewall policies * using AzPSArgumentException instead of PSArgumentException * using Resources.resx for AzPSArgumentException * reverting changes in Resources.Designer.cs that is not related to my code * adding help instruction for set-AzFirewallPolicy * updated changeLog Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com> * Added a new property "FlowTimeout" to Virtual Network (#14665) * Adding new property to Virtual Network FlowTimeoutInMinutes * Reverting local SDK changes * Added recorded test and updated help files, changed FlowTimeoutInMinutes to FlowTimeout * Update src/Network/Network/VirtualNetwork/NewAzureVirtualNetworkCommand.cs Removing Abbreviation of mins and expanding to minutes Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * Updated FlowTimeout Description * Generated New Test Recording and updated PS Test script * Adding local SDK for FlowTimeout * Update the Network sdk version in test projects * Update the Network sdk version in test projects * Updated FlowTimeout Description * Update the Network sdk version in test projects Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * Virtual Network Gateway NAT feature changes (#14685) * workingCode * VNGCommands * ConnChanges * Format * helpFiles * tests * changeLog * Revert "changeLog" This reverts commit 8dbb8a2. * ChangeLogMd * fixing csProj * Revert "Revert "changeLog"" This reverts commit 7f69613. * Fixing nupkg * TestCsProj * testRecords * fixing comments * Fixing Comments Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Support for Preferred Routing Gateway for Virtual Hub (#14761) * Fixed Azure Vnet peering build fix for new SDK * Added support for VPN or ER selection * Added default display * Bug fixes * Updated change log * Reverting VNET Peering change mismatch with SDK * Fixed help file * correcting document example 1 of New-AzFirewallPolicyRuleCollectionGroup (#14777) * Added more detailed description about GroupId in New-AzPrivateLinkServiceConnection (#14786) Co-authored-by: Beisi Zhou <bez@microsoft.com> * Fix (#14791) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Added support for getting a single private link resource (#14785) * Added support for getting a single private link resource * update help file * Update src/Network/Network/help/Get-AzPrivateLinkResource.md * Update src/Network/Network/help/Get-AzPrivateLinkResource.md Co-authored-by: Beisi Zhou <bez@microsoft.com> * Exposing two read-only properties of Application Gateway client certificate (#14784) * expose two read-only client cert properties * update appgw senario test to cover two new read-only properties of client cert * create zonal public ip referred by appgw with zone redundancy * update session record * update ChangeLog * use cert chain name from appgw * check client cert properties from appgw output * update test case and record * Gateway Loadbalancer (#14683) * new branch * fix * fix * fix * fix * fix * try restart json * replace file Co-authored-by: matyang222 <matthew.yang@microsoft.com> * Add new properties a new commandlet to support the address space update in peered vNets (#14730) * Changes for adding new commandlet for sync operation * Reverting the unintended change related to flow timeout * Updating with the SDK that has the newer fields Updating with the SDK that has the newer fields * Updating the networking SDK for all references Updating the networking SDK for all references * Added Parameter Set & Updated Changelog.md & Recorded PS Test * Minor update to changelog.md file and removed comment from VirtualNetworkTests.cs * Added default parameter set and ShouldSupportProcess=false * Added default parameter set and ShouldSupportProcess=false * Sync-AzVirtualNetworkPeering.md Help file * Updated links in help files * Minor spacing issue in help files hyperlink * Changed synopsis and description from comment to actual string * Added Sync-AzVirtualNetworkPeering to StaticAnalysis exception to ignore the shouldProcess error * Updating build steps * Setting supportsshouldprocess = true in sync-azvnetpeering * Reverting the Signature Issues Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com> * Gateway LoadBalancer property ParameterSetName requirement removal (#15108) * fix * fix Co-authored-by: matyang222 <matthew.yang@microsoft.com> * Upgrade PowerShell to 7.0.6 (#15113) Upgrade Linux Image of CI pipeline to Ubuntu 20.04 Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * Fix the random failure in CI pipeline (#15153) Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * Release Az 4.1.1 (#15150) * Release Az.Resources 4.1.1 (#15149) * [Resource] Fixed issue that property is cleaned by [#15134]. (#15136) * Az.Resources 4.1.1 release * Update version of Az.Accounts in psd1 Co-authored-by: LucasYao93 <53558334+LucasYao93@users.noreply.github.com> * Update ChangeLog.md Co-authored-by: LucasYao93 <53558334+LucasYao93@users.noreply.github.com> * [Storage] Fix oauthCopySameAccount (#15152) * Update Az.SecurityInsights help files (#15144) * Updating Az.SecurityInsights help files * Update Get-AzSentinelAlertRule.md * typo in examples resourcegroup parameter (#15146) * Update the dependencies for Az.Accounts (#15154) * Fix the issue that static analysis cannot find SupportsShouldProcess in cmdlet (#15155) Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * [Az.DiskPool] First preview availability of Az.DiskPool (#15128) * First availability of Az.DiskPool * supress error * remove unnecessary suppress * Code changes for provisioning Server & ManagedInstance with AD Only Authentication & External Administrator Properties (#15151) * Rebase master * Update Changelog * Switch to singular noun * Fix bug * Check for administrator object * Fix test * Release notes of Az.DiskPool v0.1.0 (#15160) * correct the way to download keyvault certificate (#15163) * Remove duplicate list item in Get-AzKeyVault (#15167) * cmdlets for new compute resource: SSH Public Key (#15120) * four cmdlets * location to follow resource group * add supportshouldprocess * update test * update key save location * capitalization * change * change * add two new parameter sets * ReadScale default to null on Set-AzSqlDatabase (#15168) * Updated api version (#15169) * [**URGENT**] Fix for Set-AzSqlServer and Set-AzSqlInstance cmdlets (#15176) * Fix for Set cmdlets * comma * update changelog.md * Update ChangeLog.md Co-authored-by: Dingmeng Xue <dixue@microsoft.com> * Using FQDN when connecting to nodes and enabling Arc (#15174) -Using fqdn while connecting to cluster and nodes. -Using AAD retries in Arc AAD application setup. -Returning ErrorDetails in PS output stream for WAC to handle incase of RegisteredButArcFailed. * Adding Cross Tenant DS move (#15185) updated help text added new CRR regions Co-authored-by: Dingmeng Xue <dixue@microsoft.com> * Add SecretManagement tag to module (#15187) * [HDInsight] Support new azure monitor feature (#15068) * Support new azure monitor feature * Change the cmdlet name Get/Enable/Disable-AzHDInsightMonitor to Get/Enable/Disable-AzHDInsightAzureMonitor * Update the help doc and sdk version and add tests * Add online version link * Add related test * Change setbynameparameterset to bynameparameterset * Change the parameter set names to verb+ByName|ResourceId|InputObject style Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com> * Hotfix for the issue on windows powershell (#15189) * Hotfix for the issue on windows powershell * Bump version for Az.DiskPool OOB * Adding CMK changes for PS cmdlets (#15122) * Adding CMK changes for PS cmdlets * Add UMI. Address comments * Added UMI related config * Fix build error * Fix static analysis errors * UMI related fix. * Fix test and build issues * Update with UMI scenarios * Fix generated files * Fix identity issue * Fix failing test * Modified help files. Modified changelog.md * Update AzureSqlDatabaseTransparentDataEncryptionCommunicator.cs Remove legacy codes Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> * Polish changelog for upcoming release (#15191) * Provide certificate file login method (#14738) * Use certificate file as input * Address review comments * Change underline behavior of adding IP configuration to route server (#15194) * fix day 1 behavior for route server * record and log * Az.StackHCI - Pass GraphAccessToken to Connect-AzAccount (#15193) New-AzRoleAssignment Cmdlet needs graph token, so during Connect-AzAccount pass GraphAccessToken * [Storage] Removed StorageFileDataSmbShareOwner from value set of DefaultSharePermission (#15190) * Revert "Az.StackHCI - Pass GraphAccessToken to Connect-AzAccount (#15193)" (#15201) This reverts commit e1f82c9. * 47 update version (#15172) * Add Deep delete options for Disks and NICs (#15177) * DeleteOptions for Disks and NetworkInterfaces * DeleteOption fixes * Upgrade to Microsoft.Azure.Management.Compute Version 47.0.0 * Updated help files * temporyr change to move Compute package to version 47 Co-authored-by: Bashar Gharaibeh <basharghar@live.com> * fix blank space issue (#15206) * [ApplicationInsights] Fixed ApplicationInsightsLinkedStorageAccount CRUD command that complain missing resourcegroupName when using InputObject (#15166) * [ApplicationInsights] ApplicationInsightsLinkedStorageAccount CRUD command that complain missing resourcegroupName when using InputObject [#14848]. * Update ChangeLog.md * [ApplicationInsights] Add CRUD test cases of the LinkedStorageAccount for pipeline. Co-authored-by: Dingmeng Xue <dixue@microsoft.com> * Az.StackHCI - Pass GraphAccessToken to Connect-AzAccount (#15193) (#15203) New-AzRoleAssignment Cmdlet needs graph token, so during Connect-AzAccount pass GraphAccessToken Co-authored-by: digot007 <digot@microsoft.com> * should not try to use existed module version for new modules (#15217) * Fixed null subscriptions exception, added change log * Added output type fix and updated tests Changes from PR #15125 * regenerated ps1xml, updated examples * Updated md file for the output type and changelog * added breaking change issues csv after rebasing with master * added parenthesses to csv to fix parsing issue Co-authored-by: anakarparida <43203370+anakarparida@users.noreply.github.com> Co-authored-by: kenchenMicrosoft <72167895+kenchenMicrosoft@users.noreply.github.com> Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com> Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com> Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> Co-authored-by: wyunchi-ms <yunwang@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: arvenka <arvenka@microsoft.com> Co-authored-by: Beisi Zhou <bez@microsoft.com> Co-authored-by: biaogao <biga@microsoft.com> Co-authored-by: Matthew Yang <79727592+matyang22@users.noreply.github.com> Co-authored-by: matyang222 <matthew.yang@microsoft.com> Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com> Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> Co-authored-by: Dingmeng Xue <dixue@microsoft.com> Co-authored-by: LucasYao93 <53558334+LucasYao93@users.noreply.github.com> Co-authored-by: Wei Wei <weiwei@microsoft.com> Co-authored-by: Tiander Turpijn <tiandert@microsoft.com> Co-authored-by: srozemuller <43162899+srozemuller@users.noreply.github.com> Co-authored-by: strehan1993 <70013163+strehan1993@users.noreply.github.com> Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: bradrich-msft <53872276+bradrich-msft@users.noreply.github.com> Co-authored-by: Mikhail <mitryakh@microsoft.com> Co-authored-by: digot007 <digot@microsoft.com> Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com> Co-authored-by: aim-for-better <zhenyu.zhou@microsoft.com> Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com> Co-authored-by: viparek <78561564+viparek@users.noreply.github.com> Co-authored-by: Adam Sandor <adsandor@microsoft.com> Co-authored-by: basharg <basharg@microsoft.com> Co-authored-by: Bashar Gharaibeh <basharghar@live.com> Co-authored-by: Xiaogang <xidi@microsoft.com> Co-authored-by: makharch <makharch@microsoft.com>

* Onboard DigitalTwins to Private Link Common Cmdlets (#14613) * Onboard DigitalTwins to Private Link Common Cmdlets * Removed the change log * Added DigitalTwins in lexicographical order * Adding Private Range (No SNAT) Support to Firewall Policies (#14577) * Add Azure Route Server CRUD cmdlets to deprecate Virtual Router cmdlets (#14036) * change name from virtual router to route server * add test records * fix warning * delete unused import * no snat private ranges * adding private range in firewall policies * using AzPSArgumentException instead of PSArgumentException * using Resources.resx for AzPSArgumentException * reverting changes in Resources.Designer.cs that is not related to my code * adding help instruction for set-AzFirewallPolicy * updated changeLog Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com> * Added a new property "FlowTimeout" to Virtual Network (#14665) * Adding new property to Virtual Network FlowTimeoutInMinutes * Reverting local SDK changes * Added recorded test and updated help files, changed FlowTimeoutInMinutes to FlowTimeout * Update src/Network/Network/VirtualNetwork/NewAzureVirtualNetworkCommand.cs Removing Abbreviation of mins and expanding to minutes Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * Updated FlowTimeout Description * Generated New Test Recording and updated PS Test script * Adding local SDK for FlowTimeout * Update the Network sdk version in test projects * Update the Network sdk version in test projects * Updated FlowTimeout Description * Update the Network sdk version in test projects Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * Virtual Network Gateway NAT feature changes (#14685) * workingCode * VNGCommands * ConnChanges * Format * helpFiles * tests * changeLog * Revert "changeLog" This reverts commit 8dbb8a2. * ChangeLogMd * fixing csProj * Revert "Revert "changeLog"" This reverts commit 7f69613. * Fixing nupkg * TestCsProj * testRecords * fixing comments * Fixing Comments Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Support for Preferred Routing Gateway for Virtual Hub (#14761) * Fixed Azure Vnet peering build fix for new SDK * Added support for VPN or ER selection * Added default display * Bug fixes * Updated change log * Reverting VNET Peering change mismatch with SDK * Fixed help file * correcting document example 1 of New-AzFirewallPolicyRuleCollectionGroup (#14777) * Added more detailed description about GroupId in New-AzPrivateLinkServiceConnection (#14786) Co-authored-by: Beisi Zhou <bez@microsoft.com> * Fix (#14791) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Added support for getting a single private link resource (#14785) * Added support for getting a single private link resource * update help file * Update src/Network/Network/help/Get-AzPrivateLinkResource.md * Update src/Network/Network/help/Get-AzPrivateLinkResource.md Co-authored-by: Beisi Zhou <bez@microsoft.com> * Exposing two read-only properties of Application Gateway client certificate (#14784) * expose two read-only client cert properties * update appgw senario test to cover two new read-only properties of client cert * create zonal public ip referred by appgw with zone redundancy * update session record * update ChangeLog * use cert chain name from appgw * check client cert properties from appgw output * update test case and record * Gateway Loadbalancer (#14683) * new branch * fix * fix * fix * fix * fix * try restart json * replace file Co-authored-by: matyang222 <matthew.yang@microsoft.com> * Add new properties a new commandlet to support the address space update in peered vNets (#14730) * Changes for adding new commandlet for sync operation * Reverting the unintended change related to flow timeout * Updating with the SDK that has the newer fields Updating with the SDK that has the newer fields * Updating the networking SDK for all references Updating the networking SDK for all references * Added Parameter Set & Updated Changelog.md & Recorded PS Test * Minor update to changelog.md file and removed comment from VirtualNetworkTests.cs * Added default parameter set and ShouldSupportProcess=false * Added default parameter set and ShouldSupportProcess=false * Sync-AzVirtualNetworkPeering.md Help file * Updated links in help files * Minor spacing issue in help files hyperlink * Changed synopsis and description from comment to actual string * Added Sync-AzVirtualNetworkPeering to StaticAnalysis exception to ignore the shouldProcess error * Updating build steps * Setting supportsshouldprocess = true in sync-azvnetpeering * Reverting the Signature Issues Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com> * [Az.RecoveryServices.Backup] fixed sql CRR and security issue with SQL restore (#14599) * fixing sql restore, breaking change * Fixed TestCases * Move migrate to release-2021-05-25 (#15050) * Move Migrate to release-2021-05-25 * Update Changelog.md Co-authored-by: azurepowershell <azurepowershell@ms.com> * Move kusto to release-2021-05-25 (#15046) * Move Kusto to release-2021-05-25 * Add change log for kusto * Clean en-us from kusto help (#15048) * Suppress breaking change warnings for kusto (#15051) Co-authored-by: azurepowershell <azurepowershell@ms.com> Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> * Correct the version (#15053) Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * Fixes: #14884: `Set-AzWebAppSlot` to set FtpsState, #14998:`Set-AzWeb… (#15011) (#15055) * Fixes: #14884: `Set-AzWebAppSlot` to set FtpsState, #14998:`Set-AzWebApp` to set the AppSettings, #15005: `Set-AzAppServicePlan` to keep existing Tags when adding new Tags * Build issue fixed * Update ChangeLog.md * Build fix Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> Co-authored-by: Kota Sudhakar Reddy <60102891+Kotasudhakarreddy@users.noreply.github.com> * Fix issues for AzPreview and update description of Az.psd1 (#15052) * Fix link typo in warning message (#15045) Co-authored-by: Dingmeng Xue <dixue@microsoft.com> Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> * Remove the logic to update psd1 in artifacts. (#15057) Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * Application Gateway AutoScale Example (#15071) * Add Example # 2 Example to convert an Application Gateway from Manual Scaling to AutoScale. * Added Example Added an additional example to the New-AzApplicationGatewayAutoscaleConfiguration cmdlet. * Update ChangeLog.md Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> * Remove the reference to container instance project in network solution (#15073) * release-2021-05-25 (#15069) Suppresses the issue of static analysis * [DataFactroy] Updated ADF .Net SDK version to 4.19.0 (#15074) * [DataFactroy] Updated ADF .Net SDK version to 4.18.0 * [DataFactroy] Updated ADF .Net SDK version to 4.19.0 Co-authored-by: Yabo Hu <yabhu@microsoft.com> Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> * [App Service] Set-AzWebAppSlot defaults AlwaysOn to false [#15066] (#15077) * Add HighAvailabilityReplicaCount to New-AzSqlDatabaseSecondary (#15079) * Add HA replica param * Update ChangeLog.md Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> * Update SignalR module (#15085) * Update SignalR SDK to 1.1.2-preview * Add "Trace" to networkAcl and allow empty list * Add resource group name and resource name completers * Obsolete PSSignalRResource.HostNamePrefix * Add test * update help files * Update change log * Update ChangeLog.md Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> * Fix the breaking change issues. (#15090) Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * Update doc around supportability (#15075) Force merge it due to timeout of macOS * release-2021-05-25 * Update changelog * update changelog * Updated document to remove unsupported platform PowerShell Core 6 * Refined document * Added support for PowerShell 7.1.3 Co-authored-by: Erich(Renyong) Wang <eriwan@microsoft.com> Co-authored-by: Damien Caro <dcaro@microsoft.com> * Add migration guide for Az.6.0 (#15088) * Add migration guide for Az.6.0 * Update Az.6.0.0-migration-guide.md * Hide subscription id * Fix migration guide Co-authored-by: wyunchi-ms <yunwang@microsoft.com> Co-authored-by: Dingmeng Xue <dixue@microsoft.com> * [Az.EventHub] Get-AzEventHub accepts pipeline input from Get-AzEventHubNamespace. (#13732) * Modified to accept pipeline input from Get-AzEventHubNamespace * Successful Test Records * Updating Help markdown files and changelog.md * Added Static Analyser exception * Correcting breaking change * [Aks]Fix the issue Aks cannot be update in Automation Runbook. (#15109) * Fix the issue Aks cannot be update in Automation Runbook. * Fix the issue Aks cannot be update in Automation Runbook. Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * Update Set-AzNotificationHubsNamespace.md (#15103) Hi team, Proposing to add the -SkuTier parameter to the examples, since the command fails with "Set-AzNotificationHubsNamespace: The request content was invalid and could not be deserialized: Required property 'name' not found in 'sku'." if it is not provided. * SQL Ledger Cmdlets (#14997) * ledger changes + changes for new SDK version * adding tests, updating cmdlets * adding tests, fixing cmdlets * adding comments to locations model * adding to changelog.md * adding markdowe help files * fixing merge problems with backup restore resources * updating help file for new-azsqldatabase * rerecording tests * removing EnableLedger from Set-AzureSqlDatabase * removing extra parameter * adding whatif text * upgrading Microsoft.Azure.Management.Sql to 1.52 * fixing online version link * adding audit action group for ledger * adding default parameter set * adding default parameter set * adding -EnableLedger description to new-azsqldatabase help file * adding ResourceIdentityWithUserAssignedIdentities to breaking changes ignore list * adding breaking change message * fixing type name * adding using directive * updating breaking changes message * testing updating TestDatabaseDataMaskingPrivilegedUsersChanges test * adding first batch of test re-records * adding more re-recordings * more changes for re-recording * adding re-recordings, adding ignore api version to some tests * adding ignore API version to instance pools test * removing ignore API version from Auditing * adding auditing tests, removing database override from vulnerability assessment test * addding test re-recordings * updating version to newest SDK, removing breaking change warnings * adding server crud test re-records, instance pool crud tests to ignore managed instance changes * adding skip to managed instance tests * Commenting out instance pool, adding vulnerability assessment tests * Adding more test rescordings, skipping tests * reverting unneeded file changes * Update ChangeLog.md * rerecording test * update changelog * ledger changes + changes for new SDK version * adding tests, updating cmdlets * adding tests, fixing cmdlets * adding comments to locations model * adding to changelog.md * adding markdowe help files * fixing merge problems with backup restore resources * updating help file for new-azsqldatabase * rerecording tests * removing EnableLedger from Set-AzureSqlDatabase * removing extra parameter * adding whatif text * upgrading Microsoft.Azure.Management.Sql to 1.52 * fixing online version link * adding audit action group for ledger * adding default parameter set * adding default parameter set * adding -EnableLedger description to new-azsqldatabase help file * adding ResourceIdentityWithUserAssignedIdentities to breaking changes ignore list * adding breaking change message * fixing type name * adding using directive * updating breaking changes message * testing updating TestDatabaseDataMaskingPrivilegedUsersChanges test * adding first batch of test re-records * adding more re-recordings * more changes for re-recording * adding re-recordings, adding ignore api version to some tests * adding ignore API version to instance pools test * removing ignore API version from Auditing * adding auditing tests, removing database override from vulnerability assessment test * addding test re-recordings * updating version to newest SDK, removing breaking change warnings * adding server crud test re-records, instance pool crud tests to ignore managed instance changes * adding skip to managed instance tests * Commenting out instance pool, adding vulnerability assessment tests * Adding more test rescordings, skipping tests * reverting unneeded file changes * rerecording test * Update ChangeLog.md * update changelog * re-recording named secondary test after rebase Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> * Update Set-AzNetworkInterface.md (#15112) fix spelling of fourth in three places. * AzPreview use latest Az.Accounts version (#15111) * AzPreview use latest Az.Accounts version * Update RunVersionController.ps1 Co-authored-by: Dingmeng Xue <dixue@microsoft.com> * [NetAppFiles] Update to api-version 2021-02-01 updates (#15104) * Apply 2021-02-01 updates * Remove accidental comment Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com> * Enable short policy names for mi mw (#15105) * Allow short policy names for MI update/create * Update test * Record test * Remove unnecessary ; * Update changelog * Update Test Deployments to allow the user to specify a deployment name (#15082) * Update TestAzureSubscriptionDeploymentCmdlet.cs * For TestAzureSubscriptionDeployment - If deployment name is null, then generate the name, otherwise, pass the deployment name * Allow to specify deployment name for validate on management group, subscription, and tenant deployments * changelog Allow naming the deployment when testing deployments [#11497] * change help message * Update-MarkdownHelpModule Co-authored-by: Jonathan Reynes <joreynes@microsoft.com> * [Storage] Support NFS and SmbMultichannel (#15130) * [Storage] Support NFS * [Storage] Support EnableSmbMultichannel * fix PR review comments * [Az.Resources Policy] Add -NonComplianceMessage to Set/New-AzPolicyAssignment (#15060) * Model changes * Update help docs * Re-record tests * Fix examples * Addressing mentat9 comments * Gateway LoadBalancer property ParameterSetName requirement removal (#15108) * fix * fix Co-authored-by: matyang222 <matthew.yang@microsoft.com> * [Resource] Fixed issue that property is cleaned by [#15134]. (#15136) * Add validation trigger setting to pipelines (#15143) * add configuration in yarm file for test. * Updated yml file for CI. * Upgrade PowerShell to 7.0.6 (#15113) Upgrade Linux Image of CI pipeline to Ubuntu 20.04 Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * Fix the random failure in CI pipeline (#15153) Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * Release Az 4.1.1 (#15150) * Release Az.Resources 4.1.1 (#15149) * [Resource] Fixed issue that property is cleaned by [#15134]. (#15136) * Az.Resources 4.1.1 release * Update version of Az.Accounts in psd1 Co-authored-by: LucasYao93 <53558334+LucasYao93@users.noreply.github.com> * Update ChangeLog.md Co-authored-by: LucasYao93 <53558334+LucasYao93@users.noreply.github.com> * [Storage] Fix oauthCopySameAccount (#15152) * Update Az.SecurityInsights help files (#15144) * Updating Az.SecurityInsights help files * Update Get-AzSentinelAlertRule.md * typo in examples resourcegroup parameter (#15146) * Update the dependencies for Az.Accounts (#15154) * Fix the issue that static analysis cannot find SupportsShouldProcess in cmdlet (#15155) Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * [Az.DiskPool] First preview availability of Az.DiskPool (#15128) * First availability of Az.DiskPool * supress error * remove unnecessary suppress * Code changes for provisioning Server & ManagedInstance with AD Only Authentication & External Administrator Properties (#15151) * Rebase master * Update Changelog * Switch to singular noun * Fix bug * Check for administrator object * Fix test * Release notes of Az.DiskPool v0.1.0 (#15160) * correct the way to download keyvault certificate (#15163) * Remove duplicate list item in Get-AzKeyVault (#15167) * cmdlets for new compute resource: SSH Public Key (#15120) * four cmdlets * location to follow resource group * add supportshouldprocess * update test * update key save location * capitalization * change * change * add two new parameter sets * ReadScale default to null on Set-AzSqlDatabase (#15168) * Updated api version (#15169) * [**URGENT**] Fix for Set-AzSqlServer and Set-AzSqlInstance cmdlets (#15176) * Fix for Set cmdlets * comma * update changelog.md * Update ChangeLog.md Co-authored-by: Dingmeng Xue <dixue@microsoft.com> * Using FQDN when connecting to nodes and enabling Arc (#15174) -Using fqdn while connecting to cluster and nodes. -Using AAD retries in Arc AAD application setup. -Returning ErrorDetails in PS output stream for WAC to handle incase of RegisteredButArcFailed. * Adding Cross Tenant DS move (#15185) updated help text added new CRR regions Co-authored-by: Dingmeng Xue <dixue@microsoft.com> * Add SecretManagement tag to module (#15187) * [HDInsight] Support new azure monitor feature (#15068) * Support new azure monitor feature * Change the cmdlet name Get/Enable/Disable-AzHDInsightMonitor to Get/Enable/Disable-AzHDInsightAzureMonitor * Update the help doc and sdk version and add tests * Add online version link * Add related test * Change setbynameparameterset to bynameparameterset * Change the parameter set names to verb+ByName|ResourceId|InputObject style Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com> * Hotfix for the issue on windows powershell (#15189) * Hotfix for the issue on windows powershell * Bump version for Az.DiskPool OOB * Adding CMK changes for PS cmdlets (#15122) * Adding CMK changes for PS cmdlets * Add UMI. Address comments * Added UMI related config * Fix build error * Fix static analysis errors * UMI related fix. * Fix test and build issues * Update with UMI scenarios * Fix generated files * Fix identity issue * Fix failing test * Modified help files. Modified changelog.md * Update AzureSqlDatabaseTransparentDataEncryptionCommunicator.cs Remove legacy codes Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> * Polish changelog for upcoming release (#15191) * Provide certificate file login method (#14738) * Use certificate file as input * Address review comments * Change underline behavior of adding IP configuration to route server (#15194) * fix day 1 behavior for route server * record and log * Az.StackHCI - Pass GraphAccessToken to Connect-AzAccount (#15193) New-AzRoleAssignment Cmdlet needs graph token, so during Connect-AzAccount pass GraphAccessToken * [Storage] Removed StorageFileDataSmbShareOwner from value set of DefaultSharePermission (#15190) * Revert "Az.StackHCI - Pass GraphAccessToken to Connect-AzAccount (#15193)" (#15201) This reverts commit e1f82c9. * 47 update version (#15172) * Add Deep delete options for Disks and NICs (#15177) * DeleteOptions for Disks and NetworkInterfaces * DeleteOption fixes * Upgrade to Microsoft.Azure.Management.Compute Version 47.0.0 * Updated help files * temporyr change to move Compute package to version 47 Co-authored-by: Bashar Gharaibeh <basharghar@live.com> * fix blank space issue (#15206) * [ApplicationInsights] Fixed ApplicationInsightsLinkedStorageAccount CRUD command that complain missing resourcegroupName when using InputObject (#15166) * [ApplicationInsights] ApplicationInsightsLinkedStorageAccount CRUD command that complain missing resourcegroupName when using InputObject [#14848]. * Update ChangeLog.md * [ApplicationInsights] Add CRUD test cases of the LinkedStorageAccount for pipeline. Co-authored-by: Dingmeng Xue <dixue@microsoft.com> * Az.StackHCI - Pass GraphAccessToken to Connect-AzAccount (#15193) (#15203) New-AzRoleAssignment Cmdlet needs graph token, so during Connect-AzAccount pass GraphAccessToken Co-authored-by: digot007 <digot@microsoft.com> * should not try to use existed module version for new modules (#15217) * Delete obsoleted libs from local feed (#15215) * fix issue caused by blank (#15210) * Add edge zone parameter to virtual network cmdlet (#15196) * Update virtual network cmdlet * Create PSExtendedLocation.cs * Unit test is working * Add session record * Fix help message and change formatting * Update test session record * Add catch block to test * Fix build error introduced during rebase * UT metadata * Run commands synchronously and upload new test session record * Fix static analysis issue Co-authored-by: Will Ehrich <william.ehrich@microsoft.com> * Add retirement notice (#15227) * Add retirement notice * Added a note on module retirement Co-authored-by: Damien Caro <dcaro@microsoft.com> * [Synapse] - new cmdlets for Spark job definition (#15156) * Save current status * Save current status * Upgrade artfacts to 1.0.0-preview.9 * Save current status * Remvoe SQL script * Add example files * Update examples * Update changelog * Remove rename parameter set * Fix changelog * Fix online version * Suppresses breaking change issues * Remove serialized cmdlets config files for Synapse Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> * add cmdlet open-azsurveylink (#15205) * add cmdlet open-azsurveylink * move new cmdlet under feedback folder * remove white space * add help markdown for new cmdlet * update common version * suppress signature issue * update parent class * update namespace for share assembly * upgrade common version * add example * fix help markdown * add required assembly * Remove Write-Host leaking file share credentials (#15225) * Remove Write-Host leaking file share credentials Removed a Write-Host command that printed the Azure file share credentials when calling `New-AzContainerGroupVolumeObject` as reported in #15224. * Update Changelog.md Co-authored-by: Dingmeng Xue <dixue@microsoft.com> * First version of DataDog (#15218) * Fix for output type and null subscriptions collection in ResourceGraph (#15135) * Fixed null subscriptions exception, added change log * Added output type fix and updated tests Changes from PR #15125 * regenerated ps1xml, updated examples * Updated md file for the output type and changelog * added breaking change issues csv after rebasing with master * added parenthesses to csv to fix parsing issue Co-authored-by: makharch <makharch@microsoft.com> * Move DataDog to master * Add DataDog to documentation/azure-powershell-modules.md * Add SignatureIssues.csv for skip static analysis pipeline. Co-authored-by: fenwickt <69487545+fenwickt@users.noreply.github.com> Co-authored-by: makharch <makharch@microsoft.com> Co-authored-by: azurepowershell <azurepowershell@ms.com> Co-authored-by: wyunchi-ms <yunwang@microsoft.com> * Add edge zone parameter to create network interface cmdlet (#15184) * Add edge zone parameter to create network interface cmdlet * Regenerate new network interface help file Co-authored-by: Will Ehrich <william.ehrich@microsoft.com> * Gateway Load Balancer Cross tenant issue fix (#15195) * fix * name fix * put await next to create update Co-authored-by: matyang222 <matthew.yang@microsoft.com> * Update Get-AzRecoveryServicesAsrRecoveryPoint Description (#15222) Added information about the order of recovery points in the array. * Updating the description of parameter RecoveryPoint in Start-AzRecoveryServicesAsrUnplannedFailoverJob (#15223) Updating Description of RecoveryPoint parameter - to let customers know what would happen if it is not specified. * Update Get-AzSynapseTriggerRun.md (#15231) The current example throws an errors ``` Cannot bind parameter 'RunStartedAfter'. Cannot convert value "[DateTimeOffset]2018-09-01T21:00" to type "System.DateTimeOffset". Error: "String was not recognized as a valid DateTime." ``` * fixed Disable SQL AG AutoProtection (#15241) * Add edge zone parameter to public ip prefix cmdlet (#15240) * Add edge zone parameter to public ip prefix cmdlet * Update documentation * Add test session record * Update change log * Fix changelog Co-authored-by: Will Ehrich <william.ehrich@microsoft.com> * Enable viewing of Public IP address extended location (#15230) * Add edge zone parameter to public ip address cmdlet * Style issue * Simple change to retrigger CI * Fix indentation issue * Updated change log Co-authored-by: Will Ehrich <william.ehrich@microsoft.com> Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> * change the branch name from master to main (#15238) * Fix typo in changelog (#15252) * Release-2021-06-15 (#15255) * Release 2021-06-15 RC3 (#15253) * Update change log of Blockchain * Polish change log of Blockchain * Update Get-AzSynapsePipelineRun.md by adding more examples covering more scenarios (#15232) * Update Get-AzSynapsePipelineRun.md * Update Get-AzSynapsePipelineRun.md * [Storage] Support secure SMB and NFSV3 (#15209) * [Storage] Support NFSV3 in create account * [Storage] Support secure SMB Co-authored-by: anakarparida <43203370+anakarparida@users.noreply.github.com> Co-authored-by: kenchenMicrosoft <72167895+kenchenMicrosoft@users.noreply.github.com> Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com> Co-authored-by: Satya-anshu <70507845+Satya-anshu@users.noreply.github.com> Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com> Co-authored-by: wyunchi-ms <yunwang@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: arvenka <arvenka@microsoft.com> Co-authored-by: Beisi Zhou <bez@microsoft.com> Co-authored-by: biaogao <biga@microsoft.com> Co-authored-by: Matthew Yang <79727592+matyang22@users.noreply.github.com> Co-authored-by: matyang222 <matthew.yang@microsoft.com> Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com> Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com> Co-authored-by: Xiaogang <xidi@microsoft.com> Co-authored-by: azurepowershell <azurepowershell@ms.com> Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> Co-authored-by: Kota Sudhakar Reddy <60102891+Kotasudhakarreddy@users.noreply.github.com> Co-authored-by: erich-wang <eriwan@microsoft.com> Co-authored-by: Dingmeng Xue <dixue@microsoft.com> Co-authored-by: sohaibMSFT <84540426+sohaibMSFT@users.noreply.github.com> Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> Co-authored-by: Jingshu923 <52914166+Jingshu923@users.noreply.github.com> Co-authored-by: Yabo Hu <yabhu@microsoft.com> Co-authored-by: bradrich-msft <53872276+bradrich-msft@users.noreply.github.com> Co-authored-by: yzt <zityang@microsoft.com> Co-authored-by: Damien Caro <dcaro@microsoft.com> Co-authored-by: B Harsha Kashyap <hakashya@microsoft.com> Co-authored-by: Tiago Antunes <11945717+tiantun@users.noreply.github.com> Co-authored-by: rewongmicrosoft <57964114+rewongmicrosoft@users.noreply.github.com> Co-authored-by: Scott <S-T-S@users.noreply.github.com> Co-authored-by: Auðunn <audunn@netapp.com> Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com> Co-authored-by: Ivan Kulezic <72797230+kukislav@users.noreply.github.com> Co-authored-by: Jonathan Reynes <19974635+jontreynes@users.noreply.github.com> Co-authored-by: Jonathan Reynes <joreynes@microsoft.com> Co-authored-by: Wei Wei <weiwei@microsoft.com> Co-authored-by: Chris Eggert <pilor@users.noreply.github.com> Co-authored-by: LucasYao93 <53558334+LucasYao93@users.noreply.github.com> Co-authored-by: Tiander Turpijn <tiandert@microsoft.com> Co-authored-by: srozemuller <43162899+srozemuller@users.noreply.github.com> Co-authored-by: strehan1993 <70013163+strehan1993@users.noreply.github.com> Co-authored-by: Mikhail <mitryakh@microsoft.com> Co-authored-by: digot007 <digot@microsoft.com> Co-authored-by: aim-for-better <zhenyu.zhou@microsoft.com> Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com> Co-authored-by: viparek <78561564+viparek@users.noreply.github.com> Co-authored-by: Adam Sandor <adsandor@microsoft.com> Co-authored-by: basharg <basharg@microsoft.com> Co-authored-by: Bashar Gharaibeh <basharghar@live.com> Co-authored-by: William Ehrich <wdehrich@gmail.com> Co-authored-by: Will Ehrich <william.ehrich@microsoft.com> Co-authored-by: Dongwei Wang <bean0idear@163.com> Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> Co-authored-by: Ashley Roll <ash@digitalnemesis.com> Co-authored-by: fenwickt <69487545+fenwickt@users.noreply.github.com> Co-authored-by: makharch <makharch@microsoft.com> Co-authored-by: Rishabh Jain <73586309+rishjai-msft@users.noreply.github.com> Co-authored-by: Mikey Bronowski <MikeyBronowski@gmail.com>

Khushboo Baheti added 6 commits March 31, 2021 17:00

workingCode

debf8f5

VNGCommands

86108ab

ConnChanges

8478f47

Format

80636ea

helpFiles

597e261

tests

6f04587

Khushboo-Baheti requested a review from MikhailTryakhov as a code owner April 5, 2021 18:07

Khushboo Baheti added 3 commits April 5, 2021 11:15

changeLog

8dbb8a2

Revert "changeLog"

7f69613

This reverts commit 8dbb8a2.

ChangeLogMd

4e24323

Khushboo-Baheti changed the base branch from master to network-february April 5, 2021 18:20

fixing csProj

567b549

Khushboo Baheti added 3 commits April 8, 2021 11:52

Merge branch 'network-february' into NatVng

2f1be53

Revert "Revert "changeLog""

1f5dc38

This reverts commit 7f69613.

Fixing nupkg

bc3874b

TestCsProj

14f8ed5

Khushboo-Baheti requested review from bilaakpan-ms, dkulkarni-ms, grizzlytheodore, haagha, madewithsmiles, MS-syh2qs and Sandido as code owners April 9, 2021 01:24

testRecords

0d3fda5

BethanyZhou requested changes Apr 12, 2021

View reviewed changes

fixing comments

d3f6adf

BethanyZhou requested changes Apr 14, 2021

View reviewed changes

Fixing Comments

6c9dd87

BethanyZhou approved these changes Apr 14, 2021

View reviewed changes

BethanyZhou self-assigned this Apr 14, 2021

erich-wang merged commit d294154 into network-february Apr 15, 2021

Khushboo-Baheti mentioned this pull request Apr 20, 2021

Minor Fix Virtual Network Gateway NAT feature changes #14685 #14791

Merged

8 tasks

wyunchi-ms deleted the NatVng branch January 10, 2024 01:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Virtual Network Gateway NAT feature changes #14685

Virtual Network Gateway NAT feature changes #14685

Khushboo-Baheti commented Apr 5, 2021

BethanyZhou commented Apr 6, 2021

Khushboo-Baheti commented Apr 6, 2021 •

edited

Loading

BethanyZhou commented Apr 7, 2021 •

edited

Loading

Khushboo-Baheti commented Apr 8, 2021

BethanyZhou commented Apr 9, 2021

Khushboo-Baheti commented Apr 10, 2021

BethanyZhou commented Apr 12, 2021

BethanyZhou left a comment

Khushboo-Baheti commented Apr 13, 2021

Khushboo-Baheti commented Apr 13, 2021

BethanyZhou Apr 14, 2021

Khushboo-Baheti Apr 14, 2021

BethanyZhou commented Apr 14, 2021

BethanyZhou left a comment

Khushboo-Baheti commented Apr 14, 2021

BethanyZhou commented Apr 15, 2021

erich-wang commented Apr 15, 2021

Virtual Network Gateway NAT feature changes #14685

Virtual Network Gateway NAT feature changes #14685

Conversation

Khushboo-Baheti commented Apr 5, 2021

Description

Checklist

BethanyZhou commented Apr 6, 2021

Khushboo-Baheti commented Apr 6, 2021 • edited Loading

BethanyZhou commented Apr 7, 2021 • edited Loading

Khushboo-Baheti commented Apr 8, 2021

BethanyZhou commented Apr 9, 2021

Khushboo-Baheti commented Apr 10, 2021

BethanyZhou commented Apr 12, 2021

BethanyZhou left a comment

Choose a reason for hiding this comment

Khushboo-Baheti commented Apr 13, 2021

Khushboo-Baheti commented Apr 13, 2021

BethanyZhou Apr 14, 2021

Choose a reason for hiding this comment

Khushboo-Baheti Apr 14, 2021

Choose a reason for hiding this comment

BethanyZhou commented Apr 14, 2021

BethanyZhou left a comment

Choose a reason for hiding this comment

Khushboo-Baheti commented Apr 14, 2021

BethanyZhou commented Apr 15, 2021

erich-wang commented Apr 15, 2021

Khushboo-Baheti commented Apr 6, 2021 •

edited

Loading

BethanyZhou commented Apr 7, 2021 •

edited

Loading