Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use multiapi instead of all-api-versions #1162

Merged
merged 10 commits into from
Sep 6, 2020
Merged

Conversation

leni-msft
Copy link
Contributor

Replaces #1148

@leni-msft leni-msft marked this pull request as ready for review August 31, 2020 10:47
@anthony-c-martin
Copy link
Member

@leni-msft - just wanted to confirm with you. When you re-run this, it successfully creates all the expected JSON files? If so, happy to sign off!

@leni-msft
Copy link
Contributor Author

@anthony-c-martin The four batch pipelines executed successfully, and from the logs(batch0, batch1, batch2, batch3) we can see all the generated resources. So yes, I believe all expected JSON files have been created.

@anthony-c-martin
Copy link
Member

@anthony-c-martin The four batch pipelines executed successfully, and from the logs(batch0, batch1, batch2, batch3) we can see all the generated resources. So yes, I believe all expected JSON files have been created.

Awesome, thanks for confirming. The speedup you were able to achieve with this is amazing by the way!

@leni-msft
Copy link
Contributor Author

@anthony-c-martin Thanks for approving the PR! Could any of you help compete the PR? @apclouds @jorgecotillo It seems I have no permission to do so.

@anthony-c-martin anthony-c-martin merged commit 7d93d9c into master Sep 6, 2020
@leni-msft leni-msft deleted the multiapi-work branch January 4, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants