Skip to content

Commit

Permalink
Microsoft.HanaOnAzure swagger: Update spec to add missing fields (#14879
Browse files Browse the repository at this point in the history 
)

* Microsoft.HanaOnAzure swagger: Update spec with missing fields from RP

Add HanaSID array to StorageProfile properties

* Update ListOperations API to include isDataAction field

* Add examples for HanaSID field

* correct bool to boolean

* Fix LintDiff error introduced by this PR
  • Loading branch information
@lagalbra
lagalbra committed Jul 5, 2021
1 parent cada6f8 commit 4503223
Show file tree
Hide file tree
Showing 5 changed files with 134 additions and 10 deletions.
18 changes: 17 additions & 1 deletion ...-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/examples/HanaInstances_Get.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,23 @@
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/expressRouteCircuit"
},
"storageProfile": {
"nfsIpAddress": "200.200.200.200"
"nfsIpAddress": "200.200.200.200",
"hanaSids": [
{
"gid": "1001",
"memoryAllocation": "60",
"sid": "mysid1",
"username": "myuser1",
"uid": "101010101"
},
{
"gid": "1002",
"memoryAllocation": "40",
"sid": "mysid2",
"username": "myuser2",
"uid": "101010102"
}
]
},
"osProfile": {
"computerName": "myComputerName",
Expand Down
51 changes: 47 additions & 4 deletions ...manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/examples/HanaInstances_List.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,23 @@
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/expressRouteCircuit"
},
"storageProfile": {
"nfsIpAddress": "200.200.200.200"
"nfsIpAddress": "200.200.200.200",
"hanaSids": [
{
"gid": "1001",
"memoryAllocation": "60",
"sid": "mysid1",
"username": "myuser1",
"uid": "101010101"
},
{
"gid": "1002",
"memoryAllocation": "40",
"sid": "mysid2",
"username": "myuser2",
"uid": "101010102"
}
]
},
"osProfile": {
"computerName": "myComputerName1",
Expand Down Expand Up @@ -70,7 +86,16 @@
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/expressRouteCircuit"
},
"storageProfile": {
"nfsIpAddress": "200.200.200.201"
"nfsIpAddress": "200.200.200.201",
"hanaSids": [
{
"gid": "1001",
"memoryAllocation": "100",
"sid": "mysid",
"username": "myuser",
"uid": "101010101"
}
]
},
"osProfile": {
"computerName": "myComputerName2",
Expand Down Expand Up @@ -105,7 +130,16 @@
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup2/providers/Microsoft.Network/expressRouteCircuit"
},
"storageProfile": {
"nfsIpAddress": "200.200.200.202"
"nfsIpAddress": "200.200.200.202",
"hanaSids": [
{
"gid": "1001",
"memoryAllocation": "100",
"sid": "mysid",
"username": "myuser",
"uid": "101010101"
}
]
},
"osProfile": {
"computerName": "myComputerName3",
Expand Down Expand Up @@ -140,7 +174,16 @@
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup2/providers/Microsoft.Network/expressRouteCircuit"
},
"storageProfile": {
"nfsIpAddress": "200.200.200.203"
"nfsIpAddress": "200.200.200.203",
"hanaSids": [
{
"gid": "1101",
"memoryAllocation": "100",
"sid": "mysid101",
"username": "myuser",
"uid": "10000101"
}
]
},
"osProfile": {
"computerName": "myComputerName4",
Expand Down
29 changes: 27 additions & 2 deletions ...ft.HanaOnAzure/preview/2017-11-03-preview/examples/HanaInstances_ListByResourceGroup.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,23 @@
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/expressRouteCircuit"
},
"storageProfile": {
"nfsIpAddress": "200.200.200.200"
"nfsIpAddress": "200.200.200.200",
"hanaSids": [
{
"gid": "1001",
"memoryAllocation": "60",
"sid": "mysid1",
"username": "myuser1",
"uid": "101010101"
},
{
"gid": "1002",
"memoryAllocation": "40",
"sid": "mysid2",
"username": "myuser2",
"uid": "101010102"
}
]
},
"osProfile": {
"computerName": "myComputerName1",
Expand Down Expand Up @@ -71,7 +87,16 @@
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/expressRouteCircuit"
},
"storageProfile": {
"nfsIpAddress": "200.200.200.201"
"nfsIpAddress": "200.200.200.201",
"hanaSids": [
{
"gid": "1100",
"memoryAllocation": "100",
"sid": "mysid100",
"username": "myuser",
"uid": "10000100"
}
]
},
"osProfile": {
"computerName": "myComputerName2",
Expand Down
6 changes: 4 additions & 2 deletions ...anager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/examples/HanaOperations_List.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"operation": "HanaOp1OperationName",
"description": "HanaOp1Description",
"origin": "HanaOp1Origin"
}
},
"isDataAction": false
},
{
"name": "HanaOp2",
Expand All @@ -24,7 +25,8 @@
"operation": "HanaOp2OperationName",
"description": "HanaOp2Description",
"origin": "HanaOp2Origin"
}
},
"isDataAction": false
}
]
}
Expand Down
40 changes: 39 additions & 1 deletion ...nazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,33 @@
"description": "Specifies the logical unit number of the data disk. This value is used to identify data disks within the VM and therefore must be unique for each data disk attached to a VM."
}
},
"description": "Specifies the disk information fo the HANA instance"
"description": "Specifies the disk information for the HANA instance"
},
"SAPSystemID": {
"type": "object",
"properties": {
"gid": {
"type": "string",
"description": "Group ID of the HANA database user."
},
"memoryAllocation": {
"type": "string",
"description": "Percent of memory to allocate to this SID."
},
"sid": {
"type": "string",
"description": "SAP system ID as database identifier."
},
"username": {
"type": "string",
"description": "Name of the HANA database user."
},
"uid": {
"type": "string",
"description": "User ID of the HANA database user."
}
},
"description": "Specifies information related to a SAP system ID"
},
"StorageProfile": {
"properties": {
Expand All @@ -722,6 +748,13 @@
"$ref": "#/definitions/Disk"
},
"description": "Specifies information about the operating system disk used by the hana instance."
},
"hanaSids": {
"type": "array",
"items": {
"$ref": "#/definitions/SAPSystemID"
},
"description": "Specifies information related to SAP system IDs for the hana instance."
}
},
"description": "Specifies the storage settings for the HANA instance disks."
Expand Down Expand Up @@ -796,6 +829,11 @@
"display": {
"$ref": "#/definitions/Display",
"description": "Displayed HANA operation information"
},
"isDataAction": {
"readOnly": true,
"type": "boolean",
"description": "Indicates whether the operation applies to data-plane."
}
},
"description": "HANA operation information"
Expand Down

0 comments on commit 4503223

Please sign in to comment.