Address review comments

Azure · Feb 11, 2022 · d5f7749
1 parent 02c719c
commit d5f7749
Show file tree

Hide file tree

Showing 6 changed files with 262 additions and 236 deletions.
diff --git a/...t.SignalRService/stable/2022-02-01/examples/SignalRCustomCertificates_CreateOrUpdate.json b/...t.SignalRService/stable/2022-02-01/examples/SignalRCustomCertificates_CreateOrUpdate.json
@@ -1,6 +1,6 @@
 {
   "parameters": {
-    "body": {
+    "parameters": {
       "properties": {
         "keyVaultBaseUri": "https://myvault.keyvault.azure.net/",
         "keyVaultSecretName": "mycert",

diff --git a/...rosoft.SignalRService/stable/2022-02-01/examples/SignalRCustomDomains_CreateOrUpdate.json b/...rosoft.SignalRService/stable/2022-02-01/examples/SignalRCustomDomains_CreateOrUpdate.json
@@ -1,25 +1,31 @@
 {
   "parameters": {
-    "body": {
+    "parameters": {
       "properties": {
-        "certificateName": "cert"
+        "domainName": "example.com",
+        "customCertificate": {
+          "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/customCertificates/myCert"
+        }
       }
     },
     "api-version": "2022-02-01",
     "subscriptionId": "00000000-0000-0000-0000-000000000000",
     "resourceGroupName": "myResourceGroup",
     "resourceName": "mySignalRService",
-    "domainName": "example.com"
+    "name": "myDomain"
   },
   "responses": {
     "201": {
       "body": {
         "properties": {
           "provisioningState": "Succeeded",
-          "certificateName": "cert"
+          "domainName": "example.com",
+          "customCertificate": {
+            "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/customCertificates/myCert"
+          }
         },
-        "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/customDomain/example.com",
-        "name": "example.com"
+        "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/customDomains/myDomain",
+        "name": "myDomain"
       },
       "headers": {
         "Location": "https://management.azure.com/subscriptions/subid/providers/Microsoft.SignalRService/...pathToOperationResult...",

diff --git a/...ager/Microsoft.SignalRService/stable/2022-02-01/examples/SignalRCustomDomains_Delete.json b/...ager/Microsoft.SignalRService/stable/2022-02-01/examples/SignalRCustomDomains_Delete.json
@@ -4,7 +4,7 @@
     "subscriptionId": "00000000-0000-0000-0000-000000000000",
     "resourceGroupName": "myResourceGroup",
     "resourceName": "mySignalRService",
-    "domainName": "example.com"
+    "name": "example"
   },
   "responses": {
     "200": {},

diff --git a/...manager/Microsoft.SignalRService/stable/2022-02-01/examples/SignalRCustomDomains_Get.json b/...manager/Microsoft.SignalRService/stable/2022-02-01/examples/SignalRCustomDomains_Get.json
@@ -4,17 +4,20 @@
     "subscriptionId": "00000000-0000-0000-0000-000000000000",
     "resourceGroupName": "myResourceGroup",
     "resourceName": "mySignalRService",
-    "domainName": "example.com"
+    "name": "example"
   },
   "responses": {
     "200": {
       "body": {
         "properties": {
           "provisioningState": "Succeeded",
-          "certificateName": "cert"
+          "domainName": "example.com",
+          "customCertificate": {
+            "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/customCertificates/myCert"
+          }
         },
-        "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/customDomain/example.com",
-        "name": "example.com"
+        "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/customDomains/myDomain",
+        "name": "myDomain"
       }
     }
   }

diff --git a/...anager/Microsoft.SignalRService/stable/2022-02-01/examples/SignalRCustomDomains_List.json b/...anager/Microsoft.SignalRService/stable/2022-02-01/examples/SignalRCustomDomains_List.json
@@ -4,7 +4,7 @@
     "subscriptionId": "00000000-0000-0000-0000-000000000000",
     "resourceGroupName": "myResourceGroup",
     "resourceName": "mySignalRService",
-    "domainName": "example.com"
+    "name": "myDomain"
   },
   "responses": {
     "200": {
@@ -13,10 +13,13 @@
           {
             "properties": {
               "provisioningState": "Succeeded",
-              "certificateName": "cert"
+              "domainName": "example.com",
+              "customCertificate": {
+                "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/customCertificates/myCert"
+              }
             },
-            "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/customDomain/example.com",
-            "name": "example.com"
+            "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/myResourceGroup/providers/Microsoft.SignalRService/SignalR/mySignalRService/customDomains/myDomain",
+            "name": "myDomain"
           }
         ]
       }