[Hub Generated] Review request for Microsoft.CustomerLockbox to add v…

…ersion preview/2018-02-28-preview (#15307) * Fixing incorrect contract details for customer lockbox RP. * Fixing validation errors * Fixing spell check failure * PR comments * Fixing go SDK issue. * removing sdks not requested by customeras
Azure · Aug 24, 2021 · d7bea65 · d7bea65
1 parent 09c9f24
commit d7bea65
Show file tree

Hide file tree

Showing 10 changed files with 70 additions and 184 deletions.
diff --git a/...esource-manager/Microsoft.CustomerLockbox/preview/2018-02-28-preview/customerlockbox.json b/...esource-manager/Microsoft.CustomerLockbox/preview/2018-02-28-preview/customerlockbox.json
@@ -332,16 +332,12 @@
           "readOnly": true
         },
         "duration": {
-          "format": "int32",
-          "type": "integer",
+          "type": "string",
           "description": "The duration of the request in hours.",
           "readOnly": true
         },
-        "requestedResourceIds": {
-          "type": "array",
-          "items": {
-            "type": "string"
-          },
+        "resourceIds": {
+          "type": "string",
           "description": "A list of resource IDs associated with the Lockbox request separated by ','.",
           "readOnly": true
         },
@@ -360,6 +356,11 @@
           "description": "The url of the support case.",
           "readOnly": true
         },
+        "workItemSource": {
+          "type": "string",
+          "description": "The support case system that was used to initiate the request.",
+          "readOnly": true
+        },
         "subscriptionId": {
           "type": "string",
           "description": "The subscription ID.",
@@ -394,15 +395,15 @@
       "description": "Request content object, in the use of Approve or Deny a Lockbox request.",
       "type": "object",
       "properties": {
-        "decision": {
+        "status": {
           "enum": [
             "Approve",
             "Deny"
           ],
           "type": "string",
           "description": "Approval decision to the Lockbox request.",
           "x-ms-enum": {
-            "name": "Decision",
+            "name": "Status",
             "modelAsString": true
           }
         },
@@ -417,7 +418,8 @@
       "description": "An error response from the Lockbox service.",
       "properties": {
         "error": {
-          "$ref": "#/definitions/ErrorBody"
+          "$ref": "#/definitions/ErrorBody",
+          "description": "Detailed information about the error encountered."
         }
       }
     },
@@ -456,6 +458,7 @@
         },
         "info": {
           "type": "object",
+          "description": "Additional information about the request that is in error state.",
           "properties": {
             "currentStatus": {
               "$ref": "#/definitions/LockboxRequestStatus",

diff --git a/...soft.CustomerLockbox/preview/2018-02-28-preview/examples/Requests_Get_InSubscription.json b/...soft.CustomerLockbox/preview/2018-02-28-preview/examples/Requests_Get_InSubscription.json
@@ -13,17 +13,15 @@
         "properties": {
           "requestId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
           "justification": "Microsoft Support Team is requesting access to your resource temporarily for troubleshooting.",
-          "status": "Pending",
-          "createdDateTime": "2019-10-07T16:52:33.47Z",
-          "expirationDateTime": "2019-10-11T16:52:33.47Z",
-          "duration": 8,
-          "requestedResourceIds": [
-            "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMO/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO",
-            "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMO/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO2"
-          ],
-          "resourceType": "Virtual Machine",
-          "supportRequest": "123",
-          "supportCaseUrl": "https://portal.azure.com/#resource/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/microsoft.support/supporttickets/123",
+          "status": "Expired",
+          "createdDateTime": "2020-06-17T23:15:42.031334Z",
+          "expirationDateTime": "2020-06-21T23:15:42.031334Z",
+          "duration": "8",
+          "resourceIds": "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMORG/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO",
+          "resourceType": "VMSS",
+          "supportRequest": "12345",
+          "supportCaseUrl": "https://portal.azure.com/#resource/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/microsoft.support/supporttickets/12345",
+          "workItemSource": "Other",
           "subscriptionId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
         }
       }

diff --git a/...-manager/Microsoft.CustomerLockbox/preview/2018-02-28-preview/examples/Requests_List.json b/...-manager/Microsoft.CustomerLockbox/preview/2018-02-28-preview/examples/Requests_List.json
@@ -16,17 +16,15 @@
             "properties": {
               "requestId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
               "justification": "Microsoft Support Team is requesting access to your resource temporarily for troubleshooting.",
-              "status": "Pending",
-              "createdDateTime": "2019-10-07T16:52:33.47Z",
-              "expirationDateTime": "2019-10-11T16:52:33.47Z",
-              "duration": 8,
-              "requestedResourceIds": [
-                "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMO/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO",
-                "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMO/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO2"
-              ],
-              "resourceType": "Virtual Machine",
-              "supportRequest": "123",
-              "supportCaseUrl": "https://portal.azure.com/#resource/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/microsoft.support/supporttickets/123",
+              "status": "Expired",
+              "createdDateTime": "2020-06-17T23:15:42.031334Z",
+              "expirationDateTime": "2020-06-21T23:15:42.031334Z",
+              "duration": "8",
+              "resourceIds": "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMORG/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO",
+              "resourceType": "VMSS",
+              "supportRequest": "12345",
+              "supportCaseUrl": "https://portal.azure.com/#resource/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/microsoft.support/supporttickets/12345",
+              "workItemSource": "Other",
               "subscriptionId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
             }
           },
@@ -37,17 +35,15 @@
             "properties": {
               "requestId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
               "justification": "Microsoft Support Team is requesting access to your resource temporarily for troubleshooting.",
-              "status": "Denied",
-              "createdDateTime": "2019-10-07T16:52:33.47Z",
-              "expirationDateTime": "2019-10-11T16:52:33.47Z",
-              "duration": 8,
-              "requestedResourceIds": [
-                "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMO/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO",
-                "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMO/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO2"
-              ],
-              "resourceType": "Virtual Machine",
-              "supportRequest": "123",
-              "supportCaseUrl": "https://portal.azure.com/#resource/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/microsoft.support/supporttickets/123",
+              "status": "Expired",
+              "createdDateTime": "2020-11-19T03:12:51.2672319Z",
+              "expirationDateTime": "2020-11-23T03:12:51.2672319Z",
+              "duration": "8",
+              "resourceIds": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
+              "resourceType": "Subscription",
+              "supportRequest": "120101324000234",
+              "supportCaseUrl": "https://portal.azure.com/#resource/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/microsoft.support/supporttickets/120101324000234",
+              "workItemSource": "SupportRequest",
               "subscriptionId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
             }
           },
@@ -58,17 +54,15 @@
             "properties": {
               "requestId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
               "justification": "Microsoft Support Team is requesting access to your resource temporarily for troubleshooting.",
-              "status": "Approved",
-              "createdDateTime": "2019-10-07T16:52:33.47Z",
-              "expirationDateTime": "2019-10-11T16:52:33.47Z",
-              "duration": 8,
-              "requestedResourceIds": [
-                "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMO/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO",
-                "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMO/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO2"
-              ],
-              "resourceType": "Virtual Machine",
-              "supportRequest": "123",
-              "supportCaseUrl": "https://portal.azure.com/#resource/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/microsoft.support/supporttickets/123",
+              "status": "Denied",
+              "createdDateTime": "2021-05-24T15:08:17.590109Z",
+              "expirationDateTime": "2021-05-28T15:08:17.590109Z",
+              "duration": "Support request lifetime",
+              "resourceIds": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
+              "resourceType": "Subscription",
+              "supportRequest": "120101324000234",
+              "supportCaseUrl": "https://portal.azure.com/#resource/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/microsoft.support/supporttickets/120101324000234",
+              "workItemSource": "SupportRequest",
               "subscriptionId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
             }
           }

diff --git a/...oft.CustomerLockbox/preview/2018-02-28-preview/examples/Requests_List_FilterByStatus.json b/...oft.CustomerLockbox/preview/2018-02-28-preview/examples/Requests_List_FilterByStatus.json
@@ -3,7 +3,7 @@
     "subscriptionId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
     "requestId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
     "api-version": "2018-02-28-preview",
-    "$filter": "properties/status eq 'Pending'"
+    "$filter": "properties/status eq 'Expired'"
   },
   "responses": {
     "200": {
@@ -16,17 +16,15 @@
             "properties": {
               "requestId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
               "justification": "Microsoft Support Team is requesting access to your resource temporarily for troubleshooting.",
-              "status": "Pending",
-              "createdDateTime": "2019-10-07T16:52:33.47Z",
-              "expirationDateTime": "2019-10-11T16:52:33.47Z",
-              "duration": 8,
-              "requestedResourceIds": [
-                "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMO/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO",
-                "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMO/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO2"
-              ],
-              "resourceType": "Virtual Machine",
-              "supportRequest": "123",
-              "supportCaseUrl": "https://portal.azure.com/#resource/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/microsoft.support/supporttickets/123",
+              "status": "Expired",
+              "createdDateTime": "2020-06-17T23:15:42.031334Z",
+              "expirationDateTime": "2020-06-21T23:15:42.031334Z",
+              "duration": "8",
+              "resourceIds": "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMORG/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO",
+              "resourceType": "VMSS",
+              "supportRequest": "12345",
+              "supportCaseUrl": "https://portal.azure.com/#resource/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/microsoft.support/supporttickets/12345",
+              "workItemSource": "Other",
               "subscriptionId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
             }
           },
@@ -37,17 +35,15 @@
             "properties": {
               "requestId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
               "justification": "Microsoft Support Team is requesting access to your resource temporarily for troubleshooting.",
-              "status": "Pending",
-              "createdDateTime": "2019-10-07T16:52:33.47Z",
-              "expirationDateTime": "2019-10-11T16:52:33.47Z",
-              "duration": 8,
-              "requestedResourceIds": [
-                "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMO/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO",
-                "SUBSCRIPTIONS/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/RESOURCEGROUPS/DEMO/PROVIDERS/MICROSOFT.COMPUTE/VIRTUALMACHINES/DEMO2"
-              ],
-              "resourceType": "Virtual Machine",
-              "supportRequest": "123",
-              "supportCaseUrl": "https://portal.azure.com/#resource/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/microsoft.support/supporttickets/123",
+              "status": "Expired",
+              "createdDateTime": "2020-11-19T03:12:51.2672319Z",
+              "expirationDateTime": "2020-11-23T03:12:51.2672319Z",
+              "duration": "8",
+              "resourceIds": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
+              "resourceType": "Subscription",
+              "supportRequest": "120101324000234",
+              "supportCaseUrl": "https://portal.azure.com/#resource/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/providers/microsoft.support/supporttickets/120101324000234",
+              "workItemSource": "SupportRequest",
               "subscriptionId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
             }
           }

diff --git a/.../Microsoft.CustomerLockbox/preview/2018-02-28-preview/examples/Requests_UpdateStatus.json b/.../Microsoft.CustomerLockbox/preview/2018-02-28-preview/examples/Requests_UpdateStatus.json
@@ -4,14 +4,14 @@
     "requestId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
     "api-version": "2018-10-11-preview",
     "approval": {
-      "decision": "Approve",
+      "status": "Approve",
       "reason": "Customer approve"
     }
   },
   "responses": {
     "200": {
       "body": {
-        "decision": "Approve",
+        "status": "Approve",
         "reason": "Customer approve"
       }
     }

diff --git a/specification/customerlockbox/resource-manager/readme.go.md b/specification/customerlockbox/resource-manager/readme.go.md
diff --git a/specification/customerlockbox/resource-manager/readme.md b/specification/customerlockbox/resource-manager/readme.md
@@ -42,39 +42,6 @@ input-file:
 
 # Code Generation
 
-## Swagger to SDK
-
-This section describes what SDK should be generated by the automatic system.
-This is not used by Autorest itself.
-
-```yaml $(swagger-to-sdk)
-swagger-to-sdk:
-  - repo: azure-sdk-for-python
-  - repo: azure-sdk-for-java
-  - repo: azure-sdk-for-go
-  - repo: azure-sdk-for-js
-  - repo: azure-sdk-for-ruby
-    after_scripts:
-      - bundle install && rake arm:regen_all_profiles['azure_mgmt_customerlockbox']
-  - repo: azure-resource-manager-schemas
-```
-
-## Go
-
-See configuration in [readme.go.md](./readme.go.md)
-
-## Python
-
-See configuration in [readme.python.md](./readme.python.md)
-
-## Ruby
-
-See configuration in [readme.ruby.md](./readme.ruby.md)
-
-## TypeScript
-
-See configuration in [readme.typescript.md](./readme.typescript.md)
-
 ## CSharp
 
 See configuration in [readme.csharp.md](./readme.csharp.md)

diff --git a/specification/customerlockbox/resource-manager/readme.python.md b/specification/customerlockbox/resource-manager/readme.python.md
diff --git a/specification/customerlockbox/resource-manager/readme.ruby.md b/specification/customerlockbox/resource-manager/readme.ruby.md
diff --git a/specification/customerlockbox/resource-manager/readme.typescript.md b/specification/customerlockbox/resource-manager/readme.typescript.md