Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmosdb enum type case changes from 2020-04-01 to 2021-01-15 #14051

Closed
yupwei68 opened this issue Apr 21, 2021 · 2 comments
Closed

Cosmosdb enum type case changes from 2020-04-01 to 2021-01-15 #14051

yupwei68 opened this issue Apr 21, 2021 · 2 comments
Labels
Cosmos Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 21, 2021
@jianyexi jianyexi added Cosmos Service Attention Workflow: This issue is responsible by Azure service team. labels Apr 21, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 21, 2021
@ghost
Copy link

ghost commented Apr 21, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @wmengmsft, @MehaKaushik, @shurd.

Issue Details
  1. "indexMode" in 2020-04-01 is
    "enum": [
    "Consistent",
    "Lazy",
    "None"
    ],
    in 2021-01-15 becomes:
    "enum": [
    "consistent",
    "lazy",
    "none"
    ],
    https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2020-04-01/cosmos-db.json#L6934

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2021-01-15/cosmos-db.json#L7108

  1. "order" in 2020-04-01 is:
    "enum": [
    "Ascending",
    "Descending"
    ],

in 2021-01-15 becomes:
"enum": [
"ascending",
"descending"
],
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2020-04-01/cosmos-db.json#L7059

https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2021-01-15/cosmos-db.json#L7233

Author: yupwei68
Assignees: jianyexi
Labels:

Cosmos, Service Attention, needs-triage

Milestone: -

@MehaKaushik
Copy link
Contributor

MehaKaushik commented Apr 22, 2021

Thanks for bringing this up. This change was made to match what our service actually returns. Unfortunately, our swagger documented it incorrectly earlier and now we have fixed it.
The original issue which brought this into light is here #11222

Apologies for this change since it would have broken the client sdks generated from swagger but this was the only way to correct the behavior. Please re-open the issue if you have more concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cosmos Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

3 participants