Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CosmosDB Compound Index Sort Order returns incorrect case for CompositePathSortOrder in Get #11222

Closed
jackofallops opened this issue Oct 15, 2020 · 5 comments · Fixed by #12261
Assignees
Labels
Cosmos feature-request This issue requires a new behavior in the product in order be resolved. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@jackofallops
Copy link
Contributor

API Version: 2020-04-01

Line Reference:

"enum": [
"Ascending",
"Descending"
],
"x-ms-enum": {
"name": "CompositePathSortOrder",
"modelAsString": true
}

The API call returns descending or ascending, which does not match the Enum values of Descending and Ascending respectively, resulting in the need to add additional comparison / conversion code that should not be necessary.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 15, 2020
@ghost
Copy link

ghost commented Oct 15, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @wmengmsft, @MehaKaushik, @shurd, @anfeldma-ms

@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 16, 2020
@xseeseesee xseeseesee added the Service Attention Workflow: This issue is responsible by Azure service team. label Oct 16, 2020
@ghost
Copy link

ghost commented Oct 16, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @wmengmsft, @MehaKaushik, @shurd.

@MehaKaushik
Copy link
Contributor

Thanks for reporting this, we are investigating it.

@MehaKaushik
Copy link
Contributor

Hi @jackofallops Many thanks for reporting this. We have found out that our service is intended to return the lower case values, our swagger is wrongly documented. The same issue holds for IndexingMode (related issue Azure/azure-sdk-for-go#6603)
Since changing the enum value in a stable version is considered a breaking change, we will take up this correction in our next API version.

I will keep this issue open and track it here until the next apiVersion is released.

@MehaKaushik MehaKaushik added the feature-request This issue requires a new behavior in the product in order be resolved. label Oct 29, 2020
@MehaKaushik MehaKaushik self-assigned this Oct 29, 2020
@MehaKaushik
Copy link
Contributor

Just to update the fix will be released as a part of our upcoming apiVersion 2020-01-15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cosmos feature-request This issue requires a new behavior in the product in order be resolved. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
3 participants