[Hub Generated] Review request for Microsoft.DocumentDB to add version stable/2021-01-15 #12261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @kristynhamasaki Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Swagger Generation Artifacts
|
This was referenced Dec 30, 2020
This was referenced Dec 30, 2020
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
Hi @kristynhamasaki, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
Update sql partition key kind and adds systemKey field
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
11 tasks
kristynhamasaki
removed
the
DoNotMerge
MehaKaushik
approved these changes
Feb 11, 2021
…into kristynh-0115
JeffreyRichter
approved these changes
Feb 11, 2021
This was referenced Feb 12, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…n stable/2021-01-15 (Azure#12261) * Adds base for updating Microsoft.DocumentDB from version stable/2020-09-01 to version 2021-01-15 * Updates readme * Updates API version in new specs and examples * Changes to examples * add real example to patcH * add to patch * Update sql partition key kind and adds systemKey field * Refactor cosmosdb.json + examples with updated property * Adds examples to list call * Fix partition key * Managed Service Identity Support * Fix pk version * Changes for private endpoint and enums * Update readme * Fixes for private endpoint * Fix api version * Add 4.0 to ApiProperties enum * Add suppression for RequiredSystemDataInNewApiVersions * Fix Managed Service Identity * Update examples * Managed Service Identity Fix * Add new version to other readmes * Fix output path for go version 01-15 * Fix output path for go version 01-15 again * msi fix * Fix examples for MSI * Change NetworkAclBypass to modelAsString=false * Remove duplicate ErrorResponse Co-authored-by: Akashdeep Goel <akgoe@microsoft.com> Co-authored-by: xujin-zhang <xujin_zhang@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
What's the purpose of the update?
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
Changes will be in Prod hopefully by end of January.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
End of January
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
N/A
Contribution checklist:
Please give us an exception for linting failure "RequiredSystemDataInNewApiVersions" We are committed to incorporate this change in Cobalt and many changes in this PR are time critical.
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.