-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API returns different result than what's show in the SDK. #6603
Comments
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @kushagraThapar @srinathnarayanan @southpolesteve @shurd |
1 similar comment
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @kushagraThapar @srinathnarayanan @southpolesteve @shurd |
Hi @SebRosander thanks for this issue. |
Hi @SebRosander thank you for opening this issue. We are still investigating the capitalization discrepancy. It looks like our service returns the indexing mode with the first letter capitalized and at some point it gets converted to lower-case. I will update once we decide how to proceed. |
@shurd : Do you have any updated ETA for this? |
Hey @SebRosander @rnagpal Apologies for the delay from our side. We are still investigating the issue. It looks like somewhere in the go sdk the capitalization is not being respected, we are working towards getting this triaged. |
No stress for me personally, I've have a workaround in place. Please just let me know when it's fixed and I'll be able to remove that workaround. Thanks for keeping us updated @MehaKaushik |
Thanks for your understanding @SebRosander. To provide with you an update: We have reached out to the team which generates this sdk (from the specs specified azure-rest-api-specs) to look into what is causing this behavior. I will update once I have any more leads. |
We have root caused the issue, a change at service end is needed. We plan to do so in the coming months. I dont have a fixed timeline yet, once I have it I will update here. |
Hey @SebRosander looks like our Service is coded to have Indexingmode to start with small. To remain consistent with our data plane sdks, we will not change the behavior of the Service, instead we will fix the Swagger. Strictly speaking, we made a mistake while documenting the swagger. Since this will be a breaking change,we will make this change in the next stable apiVersion. To track this issue at one place, I will close this issue. Please track it here Azure/azure-rest-api-specs#11222 In my opinion, as long as you don't update your SDK you would have to use the work around you are using right now, we don't want to break any existing behaviors, hence the fix would be in the next stable apiVersion. Please feel free to ask any follow-ups you might have. |
Just to update the fix will be released as a part of our upcoming apiVersion 2020-01-15 |
Bug Report
import path of package in question:
"github.com/Azure/azure-sdk-for-go/services/cosmos-db/mgmt/2015-04-08/documentdb"
SDK version:
v36.3.0
output of
go version
:go version go1.13.5 darwin/amd64
What happened?
The API returns "none" instead of "None"" as show in the SDK.
azure-sdk-for-go/services/cosmos-db/mgmt/2015-04-08/documentdb/models.go
Line 145 in 781d9fb
What did you expect or want to happen?
Expected a return of "None" not "none".
How can we reproduce it?
https://github.com/SebRosander/terraform-provider-azurerm/blob/cosmosdb_gremlin_graph/azurerm/internal/services/cosmos/resource_arm_cosmosdb_gremlin_graph.go
Just run the test for the code. Found here:
https://github.com/SebRosander/terraform-provider-azurerm/blob/cosmosdb_gremlin_graph/azurerm/internal/services/cosmos/tests/resource_arm_cosmosdb_gremlin_graph_test.go
The text was updated successfully, but these errors were encountered: