New Resource azurerm_cosmosdb_gremlin_graph
#5301
Conversation
There was a problem hiding this comment.
Thanks for the PR @SebRosander, this is off to a great start. I've left some minor comments that once addressed this should be good to merge.
| "indexing_mode": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| DiffSuppressFunc: suppress.CaseDifference, |
There was a problem hiding this comment.
Could we remove this and make it case sensitive?
We typically don't make things case insensitive unless there an API bug, in which case we open an issue on the SDK and link to it in a comment here
| DiffSuppressFunc: suppress.CaseDifference, |
There was a problem hiding this comment.
Seems like an API bug. Had a short discussion with @tombuildsstuff on Slack. Issue can be found here: Azure/azure-sdk-for-go#6603
There was a problem hiding this comment.
Could we add a comment here linking to the issue??
azurerm/internal/services/cosmos/resource_arm_cosmosdb_gremlin_graph.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/resource_arm_cosmosdb_gremlin_graph.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/resource_arm_cosmosdb_gremlin_graph.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/resource_arm_cosmosdb_gremlin_graph.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/resource_arm_cosmosdb_gremlin_graph.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/resource_arm_cosmosdb_gremlin_graph.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/tests/resource_arm_cosmosdb_gremlin_graph_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks @SebRosander, just a couple more comments to address and this should be good to merge!
| "indexing_mode": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| DiffSuppressFunc: suppress.CaseDifference, |
There was a problem hiding this comment.
Could we add a comment here linking to the issue??
| } else { | ||
| id, err := azure.CosmosGetIDFromResponse(existing.Response) | ||
| if err != nil { | ||
| return fmt.Errorf("Error generationg import ID for Cosmos Gremlin Graph '%s' (Account: %s, Database: %s)", name, account, database) |
There was a problem hiding this comment.
| return fmt.Errorf("Error generationg import ID for Cosmos Gremlin Graph '%s' (Account: %s, Database: %s)", name, account, database) | |
| return fmt.Errorf("Error getting import ID for Cosmos Gremlin Graph '%s' (Account: %s, Database: %s)", name, account, database) |
|
|
||
| An `index_policy` block supports the following: | ||
|
|
||
| * `automatic` - (Optional) Indicates if the indexing policy is automatic. Defaults to true |
There was a problem hiding this comment.
we quote booleans
| * `automatic` - (Optional) Indicates if the indexing policy is automatic. Defaults to true | |
| * `automatic` - (Optional) Indicates if the indexing policy is automatic. Defaults to `true`. |
|
|
||
| * `automatic` - (Optional) Indicates if the indexing policy is automatic. Defaults to true | ||
|
|
||
| * `indexing_mode` - (Required) Indicates the indexing mode. Possible values include: 'Consistent', 'Lazy', 'None' |
There was a problem hiding this comment.
Wrong quotes have been used
| * `indexing_mode` - (Required) Indicates the indexing mode. Possible values include: 'Consistent', 'Lazy', 'None' | |
| * `indexing_mode` - (Required) Indicates the indexing mode. Possible values include: `Consistent`, `Lazy`, `None`. |
|
|
||
| The following attributes are exported: | ||
|
|
||
| * `id` - the Cosmos DB Gremlin Graph ID. |
There was a problem hiding this comment.
| * `id` - the Cosmos DB Gremlin Graph ID. | |
| * `id` - The Cosmos DB Gremlin Graph ID. |
|
|
||
| * `indexing_mode` - (Required) Indicates the indexing mode. Possible values include: 'Consistent', 'Lazy', 'None' | ||
|
|
||
| * `included_paths` - (Optional) List of paths to include in the indexing. Required if `indexing_mode` is 'Consistent' or 'Lazy'. |
There was a problem hiding this comment.
Could we fix the rest of thes emis quoted blocks
| * `included_paths` - (Optional) List of paths to include in the indexing. Required if `indexing_mode` is 'Consistent' or 'Lazy'. | |
| * `included_paths` - (Optional) List of paths to include in the indexing. Required if `indexing_mode` is `Consistent` or `Lazy`. |
|
This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.41.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes last parts of #3692 & #4970
Tests:
=== RUN TestAccAzureRMCosmosDbGremlinGraph_basic
=== PAUSE TestAccAzureRMCosmosDbGremlinGraph_basic
=== CONT TestAccAzureRMCosmosDbGremlinGraph_basic
--- PASS: TestAccAzureRMCosmosDbGremlinGraph_basic (1264.20s)
PASS
=== RUN TestAccAzureRMCosmosDbGremlinGraph_customConflictResolutionPolicy
=== PAUSE TestAccAzureRMCosmosDbGremlinGraph_customConflictResolutionPolicy
=== CONT TestAccAzureRMCosmosDbGremlinGraph_customConflictResolutionPolicy
--- PASS: TestAccAzureRMCosmosDbGremlinGraph_customConflictResolutionPolicy (1286.11s)
PASS
=== RUN TestAccAzureRMCosmosDbGremlinGraph_indexPolicy
=== PAUSE TestAccAzureRMCosmosDbGremlinGraph_indexPolicy
=== CONT TestAccAzureRMCosmosDbGremlinGraph_indexPolicy
--- PASS: TestAccAzureRMCosmosDbGremlinGraph_indexPolicy (1250.10s)
PASS
=== RUN TestAccAzureRMCosmosDbGremlinGraph_complete
=== PAUSE TestAccAzureRMCosmosDbGremlinGraph_complete
=== CONT TestAccAzureRMCosmosDbGremlinGraph_complete
--- PASS: TestAccAzureRMCosmosDbGremlinGraph_complete (1413.13s)
PASS