Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The enum value of cipher of ExpressRouteLinkMacSecConfig that service returned didn't match spec's saying #7569

Open
haroldrandom opened this issue Oct 22, 2019 · 6 comments
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Network - ExpressRoute question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@haroldrandom
Copy link
Contributor

According to this file, the cipher value service returned should be in [ "gcm-aes-128", "gcm-aes-256" ], but instead: [ "GcmAes128", "GcmAes256" ].

"ExpressRouteLinkMacSecConfig": {
      "description": "ExpressRouteLink Mac Security Configuration.",
      "title": "Definition of ExpressRouteLink Mac Security configuration.",
      "properties": {
        "cknSecretIdentifier": {
          "type": "string",
          "description": "Keyvault Secret Identifier URL containing Mac security CKN key."
        },
        "cakSecretIdentifier": {
          "type": "string",
          "description": "Keyvault Secret Identifier URL containing Mac security CAK key."
        },
        "cipher": {
          "type": "string",
          "description": "Mac security cipher.",
          "enum": [
            "gcm-aes-128",
            "gcm-aes-256"
          ],
          "x-ms-enum": {
            "name": "ExpressRouteLinkMacSecCipher",
            "modelAsString": true
          }
        }
      }
    }

The problem also occurs when I tried to update the Port links with cipher value, either "gcm-aes-128", "gcm-aes-256" is not acceptable by the service, but "gcmaes128", "gcmaes256" is recognized only.

Please correct them ASAP, cause it's related to this issue.

@yungezz yungezz added the Service Attention Workflow: This issue is responsible by Azure service team. label Oct 22, 2019
@ArcturusZhang ArcturusZhang added customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Attention Workflow: This issue is responsible by Azure service team. and removed Service Attention Workflow: This issue is responsible by Azure service team. labels Oct 23, 2019
@haroldrandom
Copy link
Contributor Author

Any updates?

@KarenHammons KarenHammons added the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Jan 14, 2020
@naveenchekuri
Copy link
Contributor

Working on the fix. Should be checked in by Feb 28.

@haroldrandom
Copy link
Contributor Author

haroldrandom commented Feb 29, 2020

Working on the fix. Should be checked in by Feb 28.

Is it release now? If so, I need to modify the corresponding code. We need to align

@mialdrid
Copy link

@haroldrandom The changes to fix this are checked in and under review.

@ghost
Copy link

ghost commented Aug 12, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @exrsuppgithub.

@haroldrandom
Copy link
Contributor Author

@mialdrid Could link that PR here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Network - ExpressRoute question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

8 participants