Correct the enum value for express route port macsec cipher #12329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @magodo Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/stable/2020-05-01/network.json#L221 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/stable/2020-05-01/network.json#L221 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/stable/2020-05-01/network.json#L221 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/stable/2020-05-01/network.json#L221 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/stable/2020-05-01/network.json#L221 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces' Location: Microsoft.Network/stable/2020-05-01/vmssNetworkInterface.json#L37 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/networkInterfaces' Location: Microsoft.Network/stable/2020-05-01/vmssNetworkInterface.json#L97 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces/{networkInterfaceName}' Location: Microsoft.Network/stable/2020-05-01/vmssNetworkInterface.json#L150 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces/{networkInterfaceName}/ipConfigurations' Location: Microsoft.Network/stable/2020-05-01/vmssNetworkInterface.json#L221 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces/{networkInterfaceName}/ipConfigurations/{ipConfigurationName}' Location: Microsoft.Network/stable/2020-05-01/vmssNetworkInterface.json#L295 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"network/resource-manager/readme.md",
"tag":"package-2020-05",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"network/resource-manager/readme.md",
"tag":"package-2020-05",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| "readme":"network/resource-manager/readme.md", "tag":"package-2020-05", "details":"Schema 'ResourceNavigationLink' has a property 'id' that is already declared the parent schema 'SubResource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ResourceNavigationLink" |
|
| "readme":"network/resource-manager/readme.md", "tag":"package-2020-05", "details":"Schema 'VpnServerConfiguration' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from VpnServerConfiguration" |
|
| 💬 AutorestCore/Exception | "readme":"network/resource-manager/readme.md", "tag":"package-2020-05", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
This was referenced Jan 8, 2021
This was referenced Jan 8, 2021
|
@magodo is it a s360 issue? |
kairu-ms
approved these changes
Jan 11, 2021
|
@magodo could you attach the Swagger KPI ADO issue or links to error details, so that PR assignee can know the PR is addressing what issue. |
|
@josefree No ADO issue for this, how do I create one? |
|
Hi @magodo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@MikhailTryakhov Please ask service team to confirm and review this change. |
GET https://management.azure.com/subscriptions/x-x-x-x/resourceGroups/mgd-erp/providers/Microsoft.Network/ExpressRoutePorts/magodo-erp?api-version=2020-05-01 HTTP/2.0{
"id": "/subscriptions/x-x-x-x/resourceGroups/mgd-erp/providers/Microsoft.Network/expressRoutePorts/magodo-erp",
"identity": {
"type": "userAssigned",
"userAssignedIdentities": {
"/subscriptions/x-x-x-x/resourceGroups/mgd-erp/providers/Microsoft.ManagedIdentity/userAssignedIdentities/mgd-identity": {}
}
},
"location": "westus2",
"name": "magodo-erp",
"properties": {
"allocationDate": "Saturday, January 9, 2021",
"bandwidthInGbps": 10,
"encapsulation": "Dot1Q",
"etherType": "0x8100",
"links": [
{
"id": "/subscriptions/x-x-x-x/resourceGroups/mgd-erp/providers/Microsoft.Network/expressRoutePorts/magodo-erp/links/link1",
"name": "link1",
"properties": {
"adminState": "Disabled",
"connectorType": "LC",
"interfaceName": "xe-0/1/9:1",
"macSecConfig": {
"cakSecretIdentifier": "...",
"cipher": "GcmAes256",
"cknSecretIdentifier": "..."
},
"patchPanelId": "F1-C2-R13-A - P12",
"provisioningState": "Failed",
"rackId": "F01C01-AH115",
"routerName": "exr01.cbr20"
},
"type": "Microsoft.Network/expressRoutePorts/links"
},
{
"id": "/subscriptions/x-x-x-x/resourceGroups/mgd-erp/providers/Microsoft.Network/expressRoutePorts/magodo-erp/links/link2",
"name": "link2",
"properties": {
"adminState": "Disabled",
"connectorType": "LC",
"interfaceName": "xe-0/1/9:1",
"macSecConfig": {
"cipher": "GcmAes128"
},
"patchPanelId": "F1-C3-R3-A - P12",
"provisioningState": "Failed",
"rackId": "F01C01-AH116",
"routerName": "exr02.cbr20"
},
"type": "Microsoft.Network/expressRoutePorts/links"
}
],
"mtu": "1500",
"peeringLocation": "CDC-Canberra",
"provisionedBandwidthInGbps": 0.0,
"provisioningState": "Failed",
"resourceGuid": "x-x-x-x"
},
"tags": {},
"type": "Microsoft.Network/expressRoutePorts"
}
The problematic field is |
kairu-ms
requested changes
Jan 12, 2021
|
@kairu-ms The newer versions have the correct enum values. |
JeffreyRichter
approved these changes
Jan 12, 2021
JeffreyRichter
added
the
Approved-BreakingChange
|
@MikhailTryakhov Can you ask service team to verify the response value in different api-versions. Thanks. It's already fixed in new api-versions. But for previous api-versions the value is still 'gcm-aes-128' |
|
I fond someone already create a issue for this. Hi @naveenchekuri, can your checkout it? |
This was referenced May 6, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.