Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last access time and smb multichannel feature into Aug2020 preview #10993

Merged
merged 3 commits into from
Oct 14, 2020

Conversation

zfchen95
Copy link
Contributor

@zfchen95 zfchen95 commented Sep 30, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 30, 2020

[Staging] Swagger Validation Report

BreakingChange: 10 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1041 - AddedPropertyInResponse The new version has a new property 'lastAccessTimeTrackingPolicy' in response that was not found in the old version.
New: Microsoft.Storage/preview/2020-08-01-preview/blob.json#L1178:11
Old: Microsoft.Storage/preview/2020-08-01-preview/blob.json#L1175:11
1041 - AddedPropertyInResponse The new version has a new property 'protocolSettings' in response that was not found in the old version.
New: Microsoft.Storage/preview/2020-08-01-preview/file.json#L524:11
Old: Microsoft.Storage/preview/2020-08-01-preview/file.json#L521:11
1041 - AddedPropertyInResponse The new version has a new property 'lastAccessTimeTrackingPolicy' in response that was not found in the old version.
New: Microsoft.Storage/preview/2020-08-01-preview/blob.json#L1178:11
Old: Microsoft.Storage/preview/2020-08-01-preview/blob.json#L1175:11
1041 - AddedPropertyInResponse The new version has a new property 'lastAccessTimeTrackingPolicy' in response that was not found in the old version.
New: Microsoft.Storage/preview/2020-08-01-preview/blob.json#L1178:11
Old: Microsoft.Storage/preview/2020-08-01-preview/blob.json#L1175:11
1041 - AddedPropertyInResponse The new version has a new property 'daysAfterLastAccessTimeGreaterThan' in response that was not found in the old version.
New: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L3580:7
Old: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L3573:7
1041 - AddedPropertyInResponse The new version has a new property 'protocolSettings' in response that was not found in the old version.
New: Microsoft.Storage/preview/2020-08-01-preview/file.json#L524:11
Old: Microsoft.Storage/preview/2020-08-01-preview/file.json#L521:11
1041 - AddedPropertyInResponse The new version has a new property 'enableAutoTierToHotFromCool' in response that was not found in the old version.
New: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L3550:7
Old: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L3547:7
1041 - AddedPropertyInResponse The new version has a new property 'protocolSettings' in response that was not found in the old version.
New: Microsoft.Storage/preview/2020-08-01-preview/file.json#L524:11
Old: Microsoft.Storage/preview/2020-08-01-preview/file.json#L521:11
1041 - AddedPropertyInResponse The new version has a new property 'daysAfterLastAccessTimeGreaterThan' in response that was not found in the old version.
New: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L3580:7
Old: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L3573:7
1041 - AddedPropertyInResponse The new version has a new property 'daysAfterLastAccessTimeGreaterThan' in response that was not found in the old version.
New: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L3580:7
Old: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L3573:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 30, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 5aaacd5 with merge commit 1568435. SDK Automation 13.0.17.20200918.2
  • ⚠️preview/storage/mgmt/2015-05-01-preview [View full logs
    No file is changed.
  • ⚠️preview/storage/mgmt/2018-03-01-preview [View full logs
    No file is changed.
  • ️✔️preview/storage/mgmt/2018-07-01-preview [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 20:10:00 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:5339:3C82D15:646041D:5F875B18","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️preview/storage/mgmt/2020-08-preview [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 20:10:12 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:6075:4303055:6C962AA:5F875B24","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ⚠️storage/mgmt/2015-06-15 [View full logs
    No file is changed.
  • ⚠️storage/mgmt/2016-01-01 [View full logs
    No file is changed.
  • ⚠️storage/mgmt/2016-05-01 [View full logs
    No file is changed.
  • ⚠️storage/mgmt/2016-12-01 [View full logs
    No file is changed.
  • ⚠️storage/mgmt/2017-06-01 [View full logs
    No file is changed.
  • ⚠️storage/mgmt/2017-10-01 [View full logs
    No file is changed.
  • ⚠️storage/mgmt/2018-02-01 [View full logs
    No file is changed.
  • ⚠️storage/mgmt/2018-11-01 [View full logs
    No file is changed.
  • ⚠️storage/mgmt/2019-04-01 [View full logs
    No file is changed.
  • ⚠️storage/mgmt/2019-06-01 [View full logs
    No file is changed.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 30, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 30, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 5aaacd5 with merge commit 1568435. SDK Automation 13.0.17.20200918.2
  • ️✔️sdk/storage/mgmt-v2016_01_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:56:14 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0440:2534:1FF5838:468E86A:5F8757DE","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/storage/mgmt-v2017_10_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:56:24 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0442:422A:1B18F3:406CC2:5F8757E8","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/storage/mgmt-v2018_02_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:56:34 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0442:16FA:EB4ADA:267EF85:5F8757F2","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/storage/mgmt-v2018_03_01_preview [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:56:47 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0442:F31B:11CC6D31:14BD5ED2:5F8757FF","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/storage/mgmt-v2018_07_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:56:57 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0444:2F1F:11158B09:13DDBCD3:5F875809","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ️✔️sdk/storage/mgmt-v2019_04_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:57:09 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0442:16FC:3E2DD8F:6655996:5F875815","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ⚠️sdk/storage/mgmt-v2019_06_01 [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[78,5] cannot find symbol
      [mvn]   symbol:   class SkuInner
      [mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
      [mvn]   symbol:   class SkuInner
      [mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-storage: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[78,5] cannot find symbol
      [mvn] [ERROR]   symbol:   class SkuInner
      [mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
      [mvn] [ERROR]   symbol:   class SkuInner
      [mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:57:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0440:624A:99CE468:B2BE843:5F87581E","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    • ⚠️sdk/storage/mgmt-v2019_08_01_preview [View full logs]  [Release SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_08_01_preview/src/main/java/com/microsoft/azure/management/storage/v2019_08_01_preview/BlobServiceProperties.java:[83,5] cannot find symbol
        [mvn]   symbol:   class SkuInner
        [mvn]   location: interface com.microsoft.azure.management.storage.v2019_08_01_preview.BlobServiceProperties
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_08_01_preview/src/main/java/com/microsoft/azure/management/storage/v2019_08_01_preview/FileServiceProperties.java:[53,5] cannot find symbol
        [mvn]   symbol:   class SkuInner
        [mvn]   location: interface com.microsoft.azure.management.storage.v2019_08_01_preview.FileServiceProperties
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-storage: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_08_01_preview/src/main/java/com/microsoft/azure/management/storage/v2019_08_01_preview/BlobServiceProperties.java:[83,5] cannot find symbol
        [mvn] [ERROR]   symbol:   class SkuInner
        [mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_08_01_preview.BlobServiceProperties
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_08_01_preview/src/main/java/com/microsoft/azure/management/storage/v2019_08_01_preview/FileServiceProperties.java:[53,5] cannot find symbol
        [mvn] [ERROR]   symbol:   class SkuInner
        [mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_08_01_preview.FileServiceProperties
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:57:28 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0442:16FB:1DC422E:482AAFA:5F875828","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Sep 30, 2020

      azure-sdk-for-net - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from 5aaacd5 with merge commit 1568435. SDK Automation 13.0.17.20200918.2
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
      • ️✔️Microsoft.Azure.Management.Storage [View full logs]  [Release SDK Changes]
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:52:52 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0781:13330:8BCFF55:A27AA9D:5F875714","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Sep 30, 2020

      azure-sdk-for-js - Release

      ⚠️ warning [Logs] [Expand Details]
      • ⚠️ Generate from 5aaacd5 with merge commit 1568435. SDK Automation 13.0.17.20200918.2
        Failed to find any diff after autorest so no changed packages was found.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Sep 30, 2020

      azure-sdk-for-python - Release

      - Breaking Change detected in SDK

      ⚠️ warning [Logs] [Expand Details]
      • ⚠️ Generate from 5aaacd5 with merge commit 1568435. SDK Automation 13.0.17.20200918.2
        [azure-mgmt-storage][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-03-01-preview', '2018-07-01'} in label v2018_07_01
        [azure-mgmt-storage][after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
      • ⚠️azure-mgmt-storage [View full logs]  [Release SDK Changes] Breaking Change Detected
        [build_conf] INFO:packaging_tools:Building template azure-mgmt-storage
        [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
        [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
        [build_conf] INFO:packaging_tools:Template done azure-mgmt-storage
        [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-03-01-preview', '2018-07-01'} in label v2018_07_01
        [after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
        [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
        [build_package]   warnings.warn(msg)
        [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
        [build_package]   warnings.warn(msg)
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:50:48 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"04C2:2B23:F8230:263B44:5F875698","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
        [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
        [ChangeLog] Size of delta 6.026% size of original (original: 93591 chars, delta: 5640 chars)
        [ChangeLog] **Features**
        [ChangeLog] 
        [ChangeLog]   - Model NetworkRuleSet has a new parameter resource_access_rules
        [ChangeLog]   - Model StorageAccountCreateParameters has a new parameter extended_location
        [ChangeLog]   - Model FileServiceProperties has a new parameter protocol_settings
        [ChangeLog]   - Model StorageAccount has a new parameter extended_location
        [ChangeLog]   - Model DateAfterModification has a new parameter days_after_last_access_time_greater_than
        [ChangeLog]   - Model ManagementPolicyBaseBlob has a new parameter enable_auto_tier_to_hot_from_cool
        [ChangeLog]   - Model BlobServiceProperties has a new parameter last_access_time_tracking_policy
        [ChangeLog]   - Added operation group DeletedAccountsOperations
        [ChangeLog] 
        [ChangeLog] **Breaking changes**
        [ChangeLog] 
        [ChangeLog]   - Operation FileServicesOperations.set_service_properties has a new signature
        [ChangeLog]   - Model ErrorResponse has a new signature

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Sep 30, 2020

      azure-sdk-for-python-track2 - Release

      - Breaking Change detected in SDK

      ⚠️ warning [Logs] [Expand Details]
      • ⚠️ Generate from 5aaacd5 with merge commit 1568435. SDK Automation 13.0.17.20200918.2
        Only show 100 items here, please refer to log for details.
        Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/2254: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:48:49 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0646:21B9:9D021D:C2B7B9:5F875621","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4506","x-ratelimit-reset":"1602705220","x-ratelimit-used":"494","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/track2_azure-mgmt-storage@10993","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
        Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/2253: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:48:50 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0648:6C5D:AAAB37:D18283:5F875622","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4502","x-ratelimit-reset":"1602705220","x-ratelimit-used":"498","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-storage@10993","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
        [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ProxyResource' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ServiceSpecification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MetricSpecification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Dimension' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccountCheckNameAvailabilityParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SKUCapability' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Restriction' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageSkuListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CheckNameAvailabilityResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SkuInformation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CustomDomain' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'EncryptionService' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'EncryptionServices' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'KeyVaultProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Encryption' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceAccessRule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'VirtualNetworkRule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IPRule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'NetworkRuleSet' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AzureFilesIdentityBasedAuthentication' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActiveDirectoryProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccountPropertiesCreateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Identity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ExtendedLocation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccountCreateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Endpoints' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccountMicrosoftEndpoints' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccountInternetEndpoints' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GeoReplicationStats' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RoutingPreference' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BlobRestoreStatus' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DeletedAccountProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccountProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DeletedAccount' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccount' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccountKey' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccountListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DeletedAccountListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccountListKeysResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccountRegenerateKeyParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccountPropertiesUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageAccountUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BlobRestoreParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BlobRestoreRange' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'UsageName' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Usage' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'UsageListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AccountSasParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ListAccountSasResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ServiceSasParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ListServiceSasResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementPolicyProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementPolicySchema' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementPolicyRule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementPolicyDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementPolicyFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TagFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementPolicyAction' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementPolicyBaseBlob' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ManagementPolicySnapShot' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DateAfterModification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DateAfterCreation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'EncryptionScope' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'EncryptionScopeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'EncryptionScopeKeyVaultProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'EncryptionScopeListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ObjectReplicationPolicies' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ObjectReplicationPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ObjectReplicationPolicyProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ObjectReplicationPolicyRule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ObjectReplicationPolicyFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponseBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ContainerProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BlobContainer' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ImmutabilityPolicyProperty' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ImmutabilityPolicyProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ImmutabilityPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'UpdateHistoryProperty' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'LegalHoldProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TagProperty' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'LegalHold' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ListContainerItem' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ListContainerItems' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BlobServiceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BlobServiceProperties-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BlobServiceItems' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ChangeFeed' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'RestorePolicyProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'LastAccessTimeTrackingPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'LeaseContainerRequest' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'LeaseContainerResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'FileServiceItems' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'FileServiceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      • ⚠️azure-mgmt-storage [View full logs]  [Release SDK Changes] Breaking Change Detected
        [build_conf_init]   Cache entry deserialization failed, entry ignored
        [build_conf_init]   Cache entry deserialization failed, entry ignored
        [build_conf] INFO:packaging_tools:Building template azure-mgmt-storage
        [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
        [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
        [build_conf] INFO:packaging_tools:Template done azure-mgmt-storage
        [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
        [build_package]   warnings.warn(msg)
        [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
        [build_package]   warnings.warn(msg)
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:53:23 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0684:97FA:324445:3F595A:5F875732","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
        [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
        [ChangeLog] Size of delta 6.153% size of original (original: 94893 chars, delta: 5839 chars)
        [ChangeLog] **Features**
        [ChangeLog] 
        [ChangeLog]   - Model NetworkRuleSet has a new parameter resource_access_rules
        [ChangeLog]   - Model BlobServiceProperties has a new parameter last_access_time_tracking_policy
        [ChangeLog]   - Model StorageAccountCreateParameters has a new parameter extended_location
        [ChangeLog]   - Model StorageAccount has a new parameter extended_location
        [ChangeLog]   - Model DateAfterModification has a new parameter days_after_last_access_time_greater_than
        [ChangeLog]   - Model FileServiceProperties has a new parameter protocol_settings
        [ChangeLog]   - Model ManagementPolicyBaseBlob has a new parameter enable_auto_tier_to_hot_from_cool
        [ChangeLog]   - Added operation group DeletedAccountsOperations
        [ChangeLog] 
        [ChangeLog] **Breaking changes**
        [ChangeLog] 
        [ChangeLog]   - Model ErrorResponse has a new signature

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Sep 30, 2020

      azure-resource-manager-schemas - Release

      failed [Logs] [Expand Details]
      • Generate from 5aaacd5 with merge commit 1568435. Schema Automation 13.0.17.20200918.2
        [AutoRest] WARNING: Found duplicate definition for variable-named type Microsoft.Storage/storageAccounts/managementPolicies. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/managementPolicies/{managementPolicyName}'.
        [AutoRest] WARNING: Found duplicate definition for variable-named type Microsoft.Storage/storageAccounts/managementPolicies. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Storage/storageAccounts/{accountName}/managementPolicies/{managementPolicyName}'.
        [storage][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
        [storage][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
        [storage][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
      • storage [View full logs
          [after_scripts|node] PostProcessor finished successfully.
          [after_scripts|node]   5775 passing (1m)
          AzureResourceSchema has no registered package commands.
          Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 19:55:45 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0640:6C5D:AB11BA:D201E9:5F8757C1","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
          SDK Repository Package Error: Error: git push --set-upstream integration sdkAutomation/storage --force To https://github.com/AzureSDKAutomation/azure-resource-manager-schemas
           ! [remote rejected]   sdkAutomation/storage -> sdkAutomation/storage (refusing to allow a GitHub App to create or update workflow `.github/workflows/main.yml` without `workflows` permission)
          error: failed to push some refs to 'https://x-access-token:v1.65752ca165397347579b5cf8f57b75c3e769bfab@github.com/AzureSDKAutomation/azure-resource-manager-schemas'
          , {}

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Sep 30, 2020

        Trenton Generation - Release

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @markcowl
        Copy link
        Member

        markcowl commented Oct 1, 2020

        @ZFChen Please fill out the checkboxes in the issue after you have followed the instructions. You will need to clear linter errors and determine if asn ARM review is warranted.

        @markcowl markcowl added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Oct 1, 2020
        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @zfchen95
        Copy link
        Contributor Author

        zfchen95 commented Oct 5, 2020

        @ZFChen Please fill out the checkboxes in the issue after you have followed the instructions. You will need to clear linter errors and determine if asn ARM review is warranted.

        Fixed

        @markcowl
        Copy link
        Member

        markcowl commented Oct 6, 2020

        @zfchen95 Per the breaing change errors, these changes require a new api-version (breaking changes are allowed in preview APIs that are < 1 year old, but only in a new api-version).

        @zfchen95
        Copy link
        Contributor Author

        zfchen95 commented Oct 6, 2020

        @zfchen95 Per the breaing change errors, these changes require a new api-version (breaking changes are allowed in preview APIs that are < 1 year old, but only in a new api-version).

        Please note that the new properties are added under a preview API version. There are two types of breaking changes. For additive breaking change, from what I learned, can always be added to a preview API version that was released within a year.

        @markcowl
        Copy link
        Member

        @zfchen95 Is this a p[ublic preview or private preview? If public preview, then a new api-version is required. If private preview, then it seems this should go in the private repo (although if the current version is also a private preview, we cna make an exception in this case, let me know).

        @zfchen95
        Copy link
        Contributor Author

        @zfchen95 Is this a p[ublic preview or private preview? If public preview, then a new api-version is required. If private preview, then it seems this should go in the private repo (although if the current version is also a private preview, we cna make an exception in this case, let me know).

        Based on what I learned from the Microsoft Rest API guideline (https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#preview-versions), it is not a requirement to bump the version for adding evolutionary change.
        "Evolutionary changes may be added as needed, as long as the change is communicated broadly."
        We have been using merge model for years and haven't heard any complaint from the customers about adding new properties.

        @markcowl markcowl added BreakingChangeReviewRequired and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Oct 14, 2020
        @markcowl
        Copy link
        Member

        @zfchen95 These are not evolutionary changes, they are listed as breaking changes, which require a version change for public preview APIs. from the REST API Guidlines:

        The X integer (indicating the revision of the preview) must be incremented for all breaking changes (resulting in a new API version). Evolutionary changes may be added as needed, as long as the change is communicated broadly.

        Per the breaking changes mentioned above, this is a breaking change and so, would require a version update. I believe we can provide an exception in this case, but these rules will soon be strictly enforced, and you should take this into account when pl;anning API changes in the future.

        @markcowl markcowl added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed BreakingChangeReviewRequired labels Oct 14, 2020
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Labels
        Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python
        Projects
        None yet
        Development

        Successfully merging this pull request may close these issues.

        2 participants