Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating_the_managedVirtualNetworkSettings_property #11300

Conversation

abhishekbhol
Copy link
Contributor

@abhishekbhol abhishekbhol commented Oct 20, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 20, 2020

[Staging] Swagger Validation Report

BreakingChange: 2 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'managedVirtualNetworkSettings' renamed or removed?
New: Microsoft.Synapse/preview/2019-06-01-preview/workspace.json#L832:7
Old: Microsoft.Synapse/preview/2019-06-01-preview/workspace.json#L832:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'managedVirtualNetworkSettings' renamed or removed?
New: Microsoft.Synapse/preview/2019-06-01-preview/workspace.json#L832:7
Old: Microsoft.Synapse/preview/2019-06-01-preview/workspace.json#L832:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @abhishekbhol Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    1 similar comment
    @openapi-workflow-bot
    Copy link

    Hi, @abhishekbhol Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 20, 2020

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from e82b25d with merge commit f42bd83. SDK Automation 13.0.17.20200918.2
    • ️✔️azure-mgmt-synapse [View full logs]  [Release SDK Changes]
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-synapse
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-synapse
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 27 Oct 2020 07:09:41 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:13D0:11511CE:2A50877:5F97C7B5","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 10.753% size of original (original: 132462 chars, delta: 14243 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model WorkspacePatchInfo has a new parameter managed_virtual_network_settings
      [ChangeLog]   - Model Workspace has a new parameter managed_virtual_network_settings
      [ChangeLog]   - Model BigDataPoolResourceInfo has a new parameter custom_libraries
      [ChangeLog]   - Model BigDataPoolResourceInfo has a new parameter spark_config_properties
      [ChangeLog]   - Model BigDataPoolResourceInfo has a new parameter session_level_packages_enabled
      [ChangeLog]   - Added operation SqlPoolTablesOperations.get
      [ChangeLog]   - Added operation SqlPoolSchemasOperations.get
      [ChangeLog]   - Added operation SqlPoolSensitivityLabelsOperations.get
      [ChangeLog]   - Added operation SqlPoolVulnerabilityAssessmentRuleBaselinesOperations.get
      [ChangeLog]   - Added operation SqlPoolVulnerabilityAssessmentScansOperations.get
      [ChangeLog]   - Added operation SqlPoolBlobAuditingPoliciesOperations.list_by_sql_pool
      [ChangeLog]   - Added operation group DataMaskingRulesOperations
      [ChangeLog]   - Added operation group DataMaskingPoliciesOperations
      [ChangeLog]   - Added operation group SqlPoolColumnsOperations
      [ChangeLog]   - Added operation group ExtendedSqlPoolBlobAuditingPoliciesOperations

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 20, 2020

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from e82b25d with merge commit f42bd83. SDK Automation 13.0.17.20200918.2
    • ️✔️preview/synapse/mgmt/2019-06-01-preview [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 27 Oct 2020 07:14:03 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0782:5B4C:6A43A:7E76C:5F97C8BB","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 20, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 20, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from e82b25d with merge commit f42bd83. SDK Automation 13.0.17.20200918.2
    • ️✔️@azure/arm-synapse [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js...
      [npmPack] created ./dist/arm-synapse.js in 985ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-synapse@2.1.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 595.0kB dist/arm-synapse.js                                                   
      [npmPack] npm notice 224.7kB dist/arm-synapse.min.js                                               
      [npmPack] npm notice 10.4kB  esm/operations/bigDataPools.js                                        
      [npmPack] npm notice 2.3kB   esm/models/bigDataPoolsMappers.js                                     
      [npmPack] npm notice 3.5kB   esm/operations/dataMaskingPolicies.js                                 
      [npmPack] npm notice 2.2kB   esm/models/dataMaskingPoliciesMappers.js                              
      [npmPack] npm notice 3.7kB   esm/operations/dataMaskingRules.js                                    
      [npmPack] npm notice 2.2kB   esm/models/dataMaskingRulesMappers.js                                 
      [npmPack] npm notice 5.8kB   esm/operations/extendedSqlPoolBlobAuditingPolicies.js                 
      [npmPack] npm notice 2.3kB   esm/models/extendedSqlPoolBlobAuditingPoliciesMappers.js              
      [npmPack] npm notice 263B    esm/models/index.js                                                   
      [npmPack] npm notice 2.1kB   esm/operations/index.js                                               
      [npmPack] npm notice 3.7kB   esm/operations/integrationRuntimeAuthKeysOperations.js                
      [npmPack] npm notice 436B    esm/models/integrationRuntimeAuthKeysOperationsMappers.js             
      [npmPack] npm notice 2.2kB   esm/operations/integrationRuntimeConnectionInfos.js                   
      [npmPack] npm notice 396B    esm/models/integrationRuntimeConnectionInfosMappers.js                
      [npmPack] npm notice 2.1kB   esm/operations/integrationRuntimeCredentials.js                       
      [npmPack] npm notice 358B    esm/models/integrationRuntimeCredentialsMappers.js                    
      [npmPack] npm notice 2.3kB   esm/operations/integrationRuntimeMonitoringDataOperations.js          
      [npmPack] npm notice 443B    esm/models/integrationRuntimeMonitoringDataOperationsMappers.js       
      [npmPack] npm notice 2.4kB   esm/operations/integrationRuntimeNodeIpAddressOperations.js           
      [npmPack] npm notice 403B    esm/models/integrationRuntimeNodeIpAddressOperationsMappers.js        
      [npmPack] npm notice 5.0kB   esm/operations/integrationRuntimeNodes.js                             
      [npmPack] npm notice 423B    esm/models/integrationRuntimeNodesMappers.js                          
      [npmPack] npm notice 3.6kB   esm/operations/integrationRuntimeObjectMetadata.js                    
      [npmPack] npm notice 587B    esm/models/integrationRuntimeObjectMetadataMappers.js                 
      [npmPack] npm notice 13.9kB  esm/operations/integrationRuntimes.js                                 
      [npmPack] npm notice 2.6kB   esm/models/integrationRuntimesMappers.js                              
      [npmPack] npm notice 2.2kB   esm/operations/integrationRuntimeStatusOperations.js                  
      [npmPack] npm notice 657B    esm/models/integrationRuntimeStatusOperationsMappers.js               
      [npmPack] npm notice 10.9kB  esm/operations/ipFirewallRules.js                                     
      [npmPack] npm notice 2.4kB   esm/models/ipFirewallRulesMappers.js                                  
      [npmPack] npm notice 159.7kB esm/models/mappers.js                                                 
      [npmPack] npm notice 5.1kB   esm/operations/operations.js                                          
      [npmPack] npm notice 681B    esm/models/operationsMappers.js                                       
      [npmPack] npm notice 9.8kB   esm/models/parameters.js                                              
      [npmPack] npm notice 8.8kB   esm/operations/privateEndpointConnections.js                          
      [npmPack] npm notice 2.3kB   esm/models/privateEndpointConnectionsMappers.js                       
      [npmPack] npm notice 8.8kB   esm/operations/privateLinkHubs.js                                     
      [npmPack] npm notice 2.3kB   esm/models/privateLinkHubsMappers.js                                  
      [npmPack] npm notice 3.9kB   esm/operations/privateLinkResources.js                                
      [npmPack] npm notice 2.2kB   esm/models/privateLinkResourcesMappers.js                             
      [npmPack] npm notice 901B    rollup.config.js                                                      
      [npmPack] npm notice 5.6kB   esm/operations/sqlPoolBlobAuditingPolicies.js                         
      [npmPack] npm notice 2.3kB   esm/models/sqlPoolBlobAuditingPoliciesMappers.js                      
      [npmPack] npm notice 2.2kB   esm/operations/sqlPoolColumns.js                                      
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolColumnsMappers.js                                   
      [npmPack] npm notice 2.1kB   esm/operations/sqlPoolConnectionPolicies.js                           
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolConnectionPoliciesMappers.js                        
      [npmPack] npm notice 2.2kB   esm/operations/sqlPoolDataWarehouseUserActivities.js                  
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolDataWarehouseUserActivitiesMappers.js               
      [npmPack] npm notice 2.1kB   esm/operations/sqlPoolGeoBackupPolicies.js                            
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolGeoBackupPoliciesMappers.js                         
      [npmPack] npm notice 3.5kB   esm/operations/sqlPoolMetadataSyncConfigs.js                          
      [npmPack] npm notice 2.3kB   esm/models/sqlPoolMetadataSyncConfigsMappers.js                       
      [npmPack] npm notice 2.3kB   esm/operations/sqlPoolOperationResults.js                             
      [npmPack] npm notice 352B    esm/models/sqlPoolOperationResultsMappers.js                          
      [npmPack] npm notice 2.8kB   esm/operations/sqlPoolOperations.js                                   
      [npmPack] npm notice 2.3kB   esm/models/sqlPoolOperationsMappers.js                                
      [npmPack] npm notice 2.8kB   esm/operations/sqlPoolReplicationLinks.js                             
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolReplicationLinksMappers.js                          
      [npmPack] npm notice 5.4kB   esm/operations/sqlPoolRestorePoints.js                                
      [npmPack] npm notice 2.3kB   esm/models/sqlPoolRestorePointsMappers.js                             
      [npmPack] npm notice 15.5kB  esm/operations/sqlPools.js                                            
      [npmPack] npm notice 3.9kB   esm/operations/sqlPoolSchemas.js                                      
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolSchemasMappers.js                                   
      [npmPack] npm notice 3.7kB   esm/operations/sqlPoolSecurityAlertPolicies.js                        
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolSecurityAlertPoliciesMappers.js                     
      [npmPack] npm notice 12.8kB  esm/operations/sqlPoolSensitivityLabels.js                            
      [npmPack] npm notice 2.3kB   esm/models/sqlPoolSensitivityLabelsMappers.js                         
      [npmPack] npm notice 2.3kB   esm/models/sqlPoolsMappers.js                                         
      [npmPack] npm notice 3.1kB   esm/operations/sqlPoolTableColumns.js                                 
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolTableColumnsMappers.js                              
      [npmPack] npm notice 4.2kB   esm/operations/sqlPoolTables.js                                       
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolTablesMappers.js                                    
      [npmPack] npm notice 3.8kB   esm/operations/sqlPoolTransparentDataEncryptions.js                   
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolTransparentDataEncryptionsMappers.js                
      [npmPack] npm notice 2.7kB   esm/operations/sqlPoolUsages.js                                       
      [npmPack] npm notice 380B    esm/models/sqlPoolUsagesMappers.js                                    
      [npmPack] npm notice 5.6kB   esm/operations/sqlPoolVulnerabilityAssessmentRuleBaselines.js         
      [npmPack] npm notice 2.2kB   esm/models/sqlPoolVulnerabilityAssessmentRuleBaselinesMappers.js      
      [npmPack] npm notice 6.9kB   esm/operations/sqlPoolVulnerabilityAssessments.js                     
      [npmPack] npm notice 8.3kB   esm/operations/sqlPoolVulnerabilityAssessmentScans.js                 
      [npmPack] npm notice 2.3kB   esm/models/sqlPoolVulnerabilityAssessmentScansMappers.js              
      [npmPack] npm notice 2.3kB   esm/models/sqlPoolVulnerabilityAssessmentsMappers.js                  
      [npmPack] npm notice 5.1kB   esm/synapseManagementClient.js                                        
      [npmPack] npm notice 2.5kB   esm/synapseManagementClientContext.js                                 

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 20, 2020

    azure-sdk-for-java - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from e82b25d with merge commit f42bd83. SDK Automation 13.0.17.20200918.2
    • ⚠️sdk/synapse/mgmt-v2019_06_01_preview [View full logs]  [Release SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/BigDataPoolsInner.java:[17,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/OperationsInner.java:[15,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IpFirewallRulesInner.java:[16,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolsInner.java:[16,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolMetadataSyncConfigsInner.java:[13,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspacesInner.java:[19,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceAadAdminsInner.java:[15,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceManagedIdentitySqlControlSettingsInner.java:[13,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateEndpointConnectionsInner.java:[15,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateLinkHubsInner.java:[19,66] cannot find symbol
        [mvn]   symbol:   class ErrorContractInnerException
        [mvn]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolSensitivityLabelsImpl.java:[60,175] cannot find symbol
        [mvn]   symbol:   class SensitivityLabelSource
        [mvn]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolSensitivityLabelsImpl
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[55,159] cannot find symbol
        [mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
        [mvn]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[71,119] cannot find symbol
        [mvn]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
        [mvn]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[24,50] cannot find symbol
        [mvn]   symbol: class ManagedIntegrationRuntime
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[25,53] cannot find symbol
        [mvn]   symbol: class SelfHostedIntegrationRuntime
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-synapse: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/BigDataPoolsInner.java:[17,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/OperationsInner.java:[15,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IpFirewallRulesInner.java:[16,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolsInner.java:[16,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolMetadataSyncConfigsInner.java:[13,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspacesInner.java:[19,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceAadAdminsInner.java:[15,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/WorkspaceManagedIdentitySqlControlSettingsInner.java:[13,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateEndpointConnectionsInner.java:[15,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/PrivateLinkHubsInner.java:[19,66] cannot find symbol
        [mvn] [ERROR]   symbol:   class ErrorContractInnerException
        [mvn] [ERROR]   location: package com.microsoft.azure.management.synapse.v2019_06_01_preview
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolSensitivityLabelsImpl.java:[60,175] cannot find symbol
        [mvn] [ERROR]   symbol:   class SensitivityLabelSource
        [mvn] [ERROR]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolSensitivityLabelsImpl
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[55,159] cannot find symbol
        [mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
        [mvn] [ERROR]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/SqlPoolVulnerabilityAssessmentRuleBaselinesImpl.java:[71,119] cannot find symbol
        [mvn] [ERROR]   symbol:   class VulnerabilityAssessmentPolicyBaselineName
        [mvn] [ERROR]   location: class com.microsoft.azure.management.synapse.v2019_06_01_preview.implementation.SqlPoolVulnerabilityAssessmentRuleBaselinesImpl
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[24,50] cannot find symbol
        [mvn] [ERROR]   symbol: class ManagedIntegrationRuntime
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/synapse/mgmt-v2019_06_01_preview/src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/implementation/IntegrationRuntimeInner.java:[25,53] cannot find symbol
        [mvn] [ERROR]   symbol: class SelfHostedIntegrationRuntime
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 27 Oct 2020 07:14:23 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0481:1627:109307:1B9323:5F97C8CF","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 20, 2020

      azure-sdk-for-net - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from e82b25d with merge commit f42bd83. SDK Automation 13.0.17.20200918.2
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
      • ️✔️Microsoft.Azure.Management.Synapse [View full logs]  [Release SDK Changes]
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 27 Oct 2020 07:12:52 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0644:7E81:3C6712:9CF6D5:5F97C874","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 20, 2020

      Trenton Generation - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 20, 2020

      azure-resource-manager-schemas - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from e82b25d with merge commit f42bd83. Schema Automation 13.0.17.20200918.2
        [synapse][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
        [synapse][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
        [synapse][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
      • ️✔️synapse [View full logs]  [Release Schema Changes]
          [after_scripts|node] PostProcessor finished successfully.
          [after_scripts|node]   5790 passing (1m)
          AzureResourceSchema has no registered package commands.
          Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 27 Oct 2020 07:15:19 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C2:0E06:F43B45:1910E08:5F97C907","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

        @abhishekbhol
        Copy link
        Contributor Author

        This is not a breaking change for service. This PR is an extension of #10964

        @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 21, 2020
        @openapi-workflow-bot
        Copy link

        Hi, @abhishekbhol your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @akning-ms

        @akning-ms akning-ms added BreakingChangeReviewRequired and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 26, 2020
        @openapi-workflow-bot
        Copy link

        openapi-workflow-bot bot commented Oct 26, 2020

        Hi @abhishekbhol, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
        If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

        @abhishekbhol
        Copy link
        Contributor Author

        Hi, as stated above This is not a breaking change for service. This PR is an extension of #10964
        @idear1203 can you please approve in help in merging it ?

        Copy link
        Contributor

        @idear1203 idear1203 left a comment

        Choose a reason for hiding this comment

        The reason will be displayed to describe this comment to others. Learn more.

        The previous Swagger spec is not used to generate any public SDKs. So I think this change is okay

        @akning-ms
        Copy link
        Contributor

        Service is not GA, so approved the breaking change.

        @akning-ms akning-ms added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 27, 2020
        @akning-ms akning-ms merged commit f42bd83 into Azure:master Oct 27, 2020
        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Oct 27, 2020

        azure-sdk-for-python-track2 - Release

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
        Co-authored-by: Abhishek Bhol <abhol@microsoft.com>
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Labels
        Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
        Projects
        None yet
        Development

        Successfully merging this pull request may close these issues.

        3 participants