Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert: spec changes for Library Management in bigDataPool (#… #12118

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

navneet35
Copy link
Contributor

…11612)"

This reverts commit 7c8fd7f.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@idear1203 idear1203 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 15, 2020
@ghost
Copy link

ghost commented Jan 3, 2021

Hi, @navneet35. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@ghost ghost added the no-recent-activity label Jan 3, 2021
@idear1203 idear1203 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 5, 2021
@ghost ghost removed the no-recent-activity label Jan 5, 2021
@mentat9 mentat9 self-assigned this Jan 12, 2021
@mentat9 mentat9 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 12, 2021
@mentat9 mentat9 added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 12, 2021
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 22, 2021

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Rule Message
1041 - AddedPropertyInResponse The new version has a new property 'customLibraries' in response that was not found in the old version.
New: Microsoft.Synapse/preview/2019-06-01-preview/bigDataPool.json#L397:7
Old: Microsoft.Synapse/preview/2019-06-01-preview/bigDataPool.json#L397:7
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 22, 2021

Swagger Generation Artifacts

️❌ azure-sdk-for-go failed [Detail]
  • Failed [Logs]Release - Generate from c95619e. SDK Automation 14.0.0
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
    HttpError: Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
        at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/request@5.4.9/node_modules/@octokit/request/dist-node/index.js:66:23
        at processTicksAndRejections (internal/process/task_queues.js:93:5)
        at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:305:21)
        at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:40:5)
        at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:170:9)
        at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
        at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
        at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:18:20
  • ️✔️synapse/mgmt/2020-12-01/synapse [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️preview/synapse/mgmt/2019-06-01-preview/synapse [View full logsBreaking Change Detected
    Only show 60 items here, please refer to log for details.
    info	[Changelog] - New function `SQLPoolMaintenanceWindowOptionsClient.Get(context.Context, string, string, string, string) (MaintenanceWindowOptions, error)`
    info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.CreateOrUpdate(context.Context, string, string, string, string, MaintenanceWindows) (autorest.Response, error)`
    info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.ListResponder(*http.Response) (PrivateLinkResourceListResult, error)`
    info	[Changelog] - New function `SQLPoolGeoBackupPoliciesClient.CreateOrUpdateResponder(*http.Response) (GeoBackupPolicy, error)`
    info	[Changelog] - New function `SQLPoolGeoBackupPoliciesClient.CreateOrUpdate(context.Context, string, string, string, GeoBackupPolicy) (GeoBackupPolicy, error)`
    info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.CreateOrUpdatePreparer(context.Context, string, string, string, string, MaintenanceWindows) (*http.Request, error)`
    info	[Changelog] - New function `SQLPoolRecommendedSensitivityLabelsClient.Update(context.Context, string, string, string, RecommendedSensitivityLabelUpdateList) (autorest.Response, error)`
    info	[Changelog] - New function `DataMaskingRulesClient.GetSender(*http.Request) (*http.Response, error)`
    info	[Changelog] - New function `SQLPoolSensitivityLabelsClient.Update(context.Context, string, string, string, SensitivityLabelUpdateList) (autorest.Response, error)`
    info	[Changelog] - New function `PossibleSensitivityLabelRankValues() []SensitivityLabelRank`
    info	[Changelog] - New function `SQLPoolSensitivityLabelsClient.UpdateResponder(*http.Response) (autorest.Response, error)`
    info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.GetResponder(*http.Response) (MaintenanceWindows, error)`
    info	[Changelog] - New function `NewPrivateLinkHubPrivateLinkResourcesClient(string) PrivateLinkHubPrivateLinkResourcesClient`
    info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.Get(context.Context, string, string, string, string) (MaintenanceWindows, error)`
    info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.CreateOrUpdateResponder(*http.Response) (autorest.Response, error)`
    info	[Changelog] - New function `SQLPoolMaintenanceWindowsClient.GetPreparer(context.Context, string, string, string, string) (*http.Request, error)`
    info	[Changelog] - New function `SQLPoolMaintenanceWindowOptionsClient.GetResponder(*http.Response) (MaintenanceWindowOptions, error)`
    info	[Changelog] - New function `SQLPoolGeoBackupPoliciesClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)`
    info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.ListComplete(context.Context, string, string) (PrivateLinkResourceListResultIterator, error)`
    info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.Get(context.Context, string, string, string) (PrivateLinkResource, error)`
    info	[Changelog] - New function `*MaintenanceWindows.UnmarshalJSON([]byte) error`
    info	[Changelog] - New function `PrivateLinkHubPrivateLinkResourcesClient.GetSender(*http.Request) (*http.Response, error)`
    info	[Changelog] - New function `MaintenanceWindowOptions.MarshalJSON() ([]byte, error)`
    info	[Changelog] - New function `DataMaskingRulesClient.Get(context.Context, string, string, string, string) (DataMaskingRule, error)`
    info	[Changelog] - New struct `DynamicExecutorAllocation`
    info	[Changelog] - New struct `LibraryResourceProperties`
    info	[Changelog] - New struct `MaintenanceWindowOptions`
    info	[Changelog] - New struct `MaintenanceWindowOptionsProperties`
    info	[Changelog] - New struct `MaintenanceWindowTimeRange`
    info	[Changelog] - New struct `MaintenanceWindows`
    info	[Changelog] - New struct `MaintenanceWindowsProperties`
    info	[Changelog] - New struct `PrivateLinkHubPrivateLinkResourcesClient`
    info	[Changelog] - New struct `RecommendedSensitivityLabelUpdate`
    info	[Changelog] - New struct `RecommendedSensitivityLabelUpdateList`
    info	[Changelog] - New struct `RecommendedSensitivityLabelUpdateProperties`
    info	[Changelog] - New struct `SQLPoolMaintenanceWindowOptionsClient`
    info	[Changelog] - New struct `SQLPoolMaintenanceWindowsClient`
    info	[Changelog] - New struct `SQLPoolRecommendedSensitivityLabelsClient`
    info	[Changelog] - New struct `SensitivityLabelUpdate`
    info	[Changelog] - New struct `SensitivityLabelUpdateList`
    info	[Changelog] - New struct `SensitivityLabelUpdateProperties`
    info	[Changelog] - New field `ManagedBy` in struct `SensitivityLabel`
    info	[Changelog] - New field `CacheSize` in struct `BigDataPoolResourceProperties`
    info	[Changelog] - New field `CustomLibraries` in struct `BigDataPoolResourceProperties`
    info	[Changelog] - New field `DynamicExecutorAllocation` in struct `BigDataPoolResourceProperties`
    info	[Changelog] - New field `LastCommitID` in struct `WorkspaceRepositoryConfiguration`
    info	[Changelog] - New field `TenantID` in struct `WorkspaceRepositoryConfiguration`
    info	[Changelog] - New field `AdlaResourceID` in struct `WorkspaceProperties`
    info	[Changelog] - New field `IsComputed` in struct `SQLPoolColumnProperties`
    info	[Changelog] - New field `SchemaName` in struct `SensitivityLabelProperties`
    info	[Changelog] - New field `TableName` in struct `SensitivityLabelProperties`
    info	[Changelog] - New field `ColumnName` in struct `SensitivityLabelProperties`
    info	[Changelog] - New field `Rank` in struct `SensitivityLabelProperties`
    info	[Changelog]
    info	[Changelog] Total 1 breaking change(s), 114 additive change(s).
    info	[Changelog]
    error	Fatal error: Validation Failed: {"resource":"PullRequest","field":"head","code":"invalid"}
    error	The following packages are still pending:
    error		synapse/mgmt/2020-12-01/synapse
    error		preview/synapse/mgmt/2019-06-01-preview/synapse
️❌ azure-sdk-for-net failed [Detail]
  • Failed [Logs]Release - Generate from c95619e. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-5.0
    command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • Microsoft.Azure.Management.Synapse [View full logs]  [Release SDK Changes]
    cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/synapse/Microsoft.Azure.Management.Synapse/tests/ScenarioTests/FirewallRuleOperationTests.cs(63,36): error CS0246: The type or namespace name 'ErrorContractException' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/synapse/Microsoft.Azure.Management.Synapse/tests/Microsoft.Azure.Management.Synapse.Tests.csproj]
    cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/synapse/Microsoft.Azure.Management.Synapse/tests/ScenarioTests/FirewallRuleOperationTests.cs(63,36): error CS0246: The type or namespace name 'ErrorContractException' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/synapse/Microsoft.Azure.Management.Synapse/tests/Microsoft.Azure.Management.Synapse.Tests.csproj]
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from c95619e. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
  • ️✔️@azure/arm-synapse [View full logs]  [Release SDK Changes]
    cmderr	[npmPack] loaded rollup.config.js with warnings
    cmderr	[npmPack] (!) Unused external imports
    cmderr	[npmPack] default imported from external module 'rollup' but never used
    cmderr	[npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js...
    cmderr	[npmPack] created ./dist/arm-synapse.js in 1.3s
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from c95619e. Schema Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
  • ️✔️synapse [View full logs]  [Release Schema Changes]
    cmderr	[resource-manager] node-pre-gyp
    cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
    cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
    cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
    cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from c95619e. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
    cmderr	[automation_init.sh]   Failed building wheel for yarl
    cmderr	[automation_init.sh]   Failed building wheel for wrapt
    cmderr	[automation_init.sh]   Failed building wheel for multidict
    cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
    cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmdout	[automation_generate.sh] [Autorest]../azure-sdk-for-python_tmp/generateOutput.json does not exist!!!
    warn	File azure-sdk-for-python_tmp/generateOutput.json not found to read
    warn	No file changes detected after generation
    warn	No package detected after generation
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from c95619e. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] 2021-02-02 07:20:23 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-synapse"
    cmderr	[generate.py] 2021-02-02 07:20:23 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
    cmderr	[generate.py] 2021-02-02 07:20:23 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/synapse/azure-resourcemanager-synapse --java.namespace=com.azure.resourcemanager.synapse   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
    cmderr	[generate.py] 2021-02-02 07:21:45 INFO [CI][Success] Write to ci.yml
    cmderr	[generate.py] 2021-02-02 07:21:45 INFO [POM][Process] dealing with pom.xml
    cmderr	[generate.py] 2021-02-02 07:21:45 INFO [POM][Success] Write to pom.xml
    cmderr	[generate.py] 2021-02-02 07:21:45 INFO [POM][Process] dealing with root pom
    cmderr	[generate.py] 2021-02-02 07:21:45 INFO [POM][Skip] pom already has module sdk/synapse
    cmderr	[generate.py] 2021-02-02 07:21:45 INFO [POM][Success] Write to root pom
    cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
    cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
    cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
    cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
    cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
  • ️✔️azure-resourcemanager-synapse [View full logs]  [Release SDK Changes]
    cmderr	[Inst] 2021-02-02 07:25:29 DEBUG Got artifact_id: azure-resourcemanager-synapse
    cmderr	[Inst] 2021-02-02 07:25:29 DEBUG Got artifact: pom.xml
    cmderr	[Inst] 2021-02-02 07:25:29 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.1-sources.jar
    cmderr	[Inst] 2021-02-02 07:25:29 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.1.jar
    cmderr	[Inst] 2021-02-02 07:25:29 DEBUG Match jar package: azure-resourcemanager-synapse-1.0.0-beta.1.jar
    cmderr	[Inst] 2021-02-02 07:25:29 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12118/azure-sdk-for-java/azure-resourcemanager-synapse/azure-resourcemanager-synapse-1.0.0-beta.1.jar\" -o azure-resourcemanager-synapse-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-synapse -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-synapse-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
    ```"}
️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

@pilor
Copy link
Contributor

pilor commented Jan 27, 2021

@mentat9 can you clear your "requested changes" status on this PR?

@navneet35 navneet35 changed the title Revert "Revert: spec changes for Libmary Management in bigDataPool (#… Revert "Revert: spec changes for Library Management in bigDataPool (#… Jan 29, 2021
@ruowan ruowan added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 1, 2021
@ruowan
Copy link
Member

ruowan commented Feb 2, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@msyyc
Copy link
Member

msyyc commented Feb 2, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants