Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Synapse GA API Version #12502

Merged
merged 12 commits into from
Jan 23, 2021
Merged

Azure Synapse GA API Version #12502

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
646190b
Base commit - Copied 2019-06-01-preview api version to stable version…
Jan 19, 2021
db8119d
GA API Version changes.
Jan 19, 2021
0de6792
updated response property to readOnly and fixed example file.
Jan 19, 2021
017176c
Fixed spell check error.
Jan 19, 2021
43eeeae
Fixed review comments.
Jan 20, 2021
9d41891
Fixed review comment.
Jan 20, 2021
68b60cd
Resolved conflict.
Jan 22, 2021
d8ae55f
Fixed review comments.
Jan 22, 2021
74adb06
Fixed review comments.
Jan 22, 2021
f9d3af8
Fixed lint errors.
Jan 22, 2021
6d343ad
Fixed go readme. file.
Jan 22, 2021
3176dce
Fixed review comments and added JEDI requirement swagger.
Jan 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .../synapse/resource-manager/Microsoft.Synapse/stable/2020-12-01/examples/CreateSqlPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,14 @@
"tier": "",
"name": ""
},
"location": "West US 2",
"location": "Southeast Asia",
"properties": {
"maxSizeBytes": 0,
"collation": "",
"sourceDatabaseId": "",
"recoverableDatabaseId": "",
"createMode": ""
"createMode": "",
"storageAccountType": "LRS"
}
}
},
Expand All @@ -27,7 +28,7 @@
"id": "/subscriptions/01234567-89ab-4def-0123-456789abcdef/resourceGroups/ExampleResourceGroup/providers/Microsoft.Synapse/workspaces/ExampleWorkspaces/sqlPools/ExampleSqlPool",
"type": "Microsoft.Synapse/workspaces/sqlPools",
"name": "ExampleSqlPool",
"location": "West US 2",
"location": "Southeast Asia",
"tags": {},
"sku": {
"tier": "",
Expand All @@ -42,7 +43,8 @@
"status": "Paused",
"restorePointInTime": "1970-01-01T00:00:00.000Z",
"createMode": "",
"creationDate": "1970-01-01T00:00:00.000Z"
"creationDate": "1970-01-01T00:00:00.000Z",
"storageAccountType": "LRS"
}
}
},
Expand Down
3 changes: 2 additions & 1 deletion ...ion/synapse/resource-manager/Microsoft.Synapse/stable/2020-12-01/examples/GetSqlPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
"maxSizeBytes": 268435456000,
"creationDate": "2017-02-10T00:56:19.2Z",
"provisioningState": "Succeeded",
"restorePointInTime": "0001-01-01T00:00:00Z"
"restorePointInTime": "0001-01-01T00:00:00Z",
"storageAccountType": "GRS"
},
"sku": {
"name": "DW100c"
Expand Down
2 changes: 1 addition & 1 deletion ...ft.Synapse/stable/2020-12-01/examples/GetWorkspaceManagedSqlServerRecoverableSqlPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "wsg-7398",
"workspaceName": "testWorkspace",
"sqlComputeName": "recoverableSqlpools-1235",
"sqlPoolName": "recoverableSqlpools-1235",
"api-version": "2020-12-01"
},
"responses": {
Expand Down
17 changes: 11 additions & 6 deletions ...esource-manager/Microsoft.Synapse/stable/2020-12-01/examples/ListSqlPoolsInWorkspace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"maxSizeBytes": 32212254720,
"creationDate": "2017-02-10T00:59:33.483Z",
"provisioningState": "Succeeded",
"restorePointInTime": "0001-01-01T00:00:00Z"
"restorePointInTime": "0001-01-01T00:00:00Z",
"storageAccountType": "GRS"
},
"sku": {
"name": "GP_Gen5_2"
Expand All @@ -37,7 +38,8 @@
"maxSizeBytes": 268435456000,
"creationDate": "2017-02-10T01:03:34.04Z",
"provisioningState": "Succeeded",
"restorePointInTime": "0001-01-01T00:00:00Z"
"restorePointInTime": "0001-01-01T00:00:00Z",
"storageAccountType": "GRS"
},
"sku": {
"name": "DW100c"
Expand All @@ -54,7 +56,8 @@
"maxSizeBytes": 268435456000,
"creationDate": "2017-02-10T01:00:21.067Z",
"provisioningState": "Succeeded",
"restorePointInTime": "0001-01-01T00:00:00Z"
"restorePointInTime": "0001-01-01T00:00:00Z",
"storageAccountType": "GRS"
},
"sku": {
"name": "DW100c"
Expand All @@ -64,14 +67,15 @@
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/sqlcrudtest-6845/providers/Microsoft.Synapse/workspaces/sqlcrudtest-7177/sqlPools/sqlcrudtest-6877",
"name": "sqlcrudtest-6877",
"type": "Microsoft.Synapse/workspaces/sqlPools",
"location": "Japan East",
"location": "Southeast Asia",
"properties": {
"status": "Online",
"collation": "SQL_Latin1_General_CP1_CI_AS",
"maxSizeBytes": 268435456000,
"creationDate": "2017-02-10T01:02:28.853Z",
"provisioningState": "Succeeded",
"restorePointInTime": "0001-01-01T00:00:00Z"
"restorePointInTime": "0001-01-01T00:00:00Z",
"storageAccountType": "LRS"
},
"sku": {
"name": "DW100c"
Expand All @@ -88,7 +92,8 @@
"maxSizeBytes": 268435456000,
"creationDate": "2017-02-10T01:01:25.347Z",
"provisioningState": "Succeeded",
"restorePointInTime": "0001-01-01T00:00:00Z"
"restorePointInTime": "0001-01-01T00:00:00Z",
"storageAccountType": "GRS"
},
"sku": {
"name": "DW100c"
Expand Down
3 changes: 2 additions & 1 deletion ...nager/Microsoft.Synapse/stable/2020-12-01/examples/ListSqlPoolsInWorkspaceWithFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"maxSizeBytes": 32212254720,
"creationDate": "2017-02-10T00:59:33.483Z",
"provisioningState": "Succeeded",
"restorePointInTime": "0001-01-01T00:00:00Z"
"restorePointInTime": "0001-01-01T00:00:00Z",
"storageAccountType": "GRS"
},
"sku": {
"name": "GP_Gen5_2"
Expand Down
3 changes: 2 additions & 1 deletion .../synapse/resource-manager/Microsoft.Synapse/stable/2020-12-01/examples/UpdateSqlPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
"status": "Paused",
"restorePointInTime": "1970-01-01T00:00:00.000Z",
"createMode": "",
"creationDate": "1970-01-01T00:00:00.000Z"
"creationDate": "1970-01-01T00:00:00.000Z",
"storageAccountType": "GRS"
}
}
},
Expand Down
13 changes: 13 additions & 0 deletions specification/synapse/resource-manager/Microsoft.Synapse/stable/2020-12-01/sqlPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5353,6 +5353,19 @@
"type": "string",
"description": "Date the SQL pool was created",
"format": "date-time"
},
"storageAccountType": {
"description": "The storage account type used to store backups for this sql pool.",
"enum": [
"GRS",
"LRS",
"ZRS"
],
"type": "string",
"x-ms-enum": {
"name": "StorageAccountType",
"modelAsString": true
}
}
}
},
Expand Down
12 changes: 6 additions & 6 deletions specification/synapse/resource-manager/Microsoft.Synapse/stable/2020-12-01/sqlServer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1089,13 +1089,13 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/recoverableSqlpools": {
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/recoverableSqlPools": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you let me know why change this case issue? as it will cause SDK breaking change, specially for operation id change. if not special reason. suggest to revert.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK's have not yet been generated for this api version. This is a new API version we're adding and there are NO SDKs right now. So nothing would fail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akning-ms Is there anything pending for merging this PR?

"get": {
"tags": [
"WorkspaceManagedSqlServer",
"recoverableSqlpools"
"recoverableSqlPools"
],
"operationId": "WorkspaceManagedSqlServerRecoverableSqlpools_List",
"operationId": "WorkspaceManagedSqlServerRecoverableSqlPools_List",
"summary": "Get list of recoverable sql pools for the server.",
"description": "Get list of recoverable sql pools for workspace managed sql server.",
"parameters": [
Expand Down Expand Up @@ -1137,7 +1137,7 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/recoverableSqlPools/{sqlComputeName}": {
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/recoverableSqlPools/{sqlPoolName}": {
"get": {
"tags": [
"WorkspaceManagedSqlServer",
Expand All @@ -1160,11 +1160,11 @@
"$ref": "./workspace.json#/parameters/workspaceNameParameter"
},
{
"name": "sqlComputeName",
"name": "sqlPoolName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the sql compute"
"description": "The name of the sql pool"
}
],
"responses": {
Expand Down