-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update blob auditing spec from swagger generator #1251
Conversation
@yaakoviyun , @ayeletshpigelman , @nathannfan FYI |
"enum": [ | ||
"Enabled", | ||
"Disabled" | ||
], | ||
"x-ms-enum":{ | ||
"type": "string", | ||
"x-ms-enum": { | ||
"name": "BlobAuditingPolicyState" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, but are you on the latest? Generator should be adding "modelAsString": "false" here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is from yesterday :) I'll fix it
Validations to fix:
The rest are noise |
Thanks @jaredmoo . I'll take a look. |
All the remaining warnings are noise. Ready to review now. |
Hey @jaredmoo - Regarding this error:
are you saying this is a red-herring or it doesn't apply to your case or you don't want to fix it now ? |
Operations for sql is implemented in a different file - https://github.com/Azure/azure-rest-api-specs/blob/master/arm-sql/2014-04-01/swagger/operations.json |
So... red herring I guess? :) We have a 2015-05-01-preview version of /operations coming online very soon, and we plan to consolidate all 2015-01-01-preview version apis including operations into a single swagger file which will fix this warning. |
Thanks @jaredmoo . Starting an internal thread to investigate this potential false error. I'm okay with the changes, will sign-off. |
No modification for NodeJS |
Used SQL swagger generator to regenerate the blob auditing spec. The path is represented in a different way (blob auditing policy parameter with single enum value, instead of hardcoded in path) but otherwise there should be no functional difference.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger