[Service Fabric Managed Clusters] 2021-01-01-preview #12639

a-santamaria · 2021-01-26T07:26:41Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

We already had a previous APIversion for managed clusters here: 2020-01-01-preview But we want to move it to its own swagger folder so we can manage APIs and SDKs independently and not face conflicts with models.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
Target Date for new api version: 2/8/2021
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
2/5/2021
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-26T07:26:44Z

Hi, @a-santamaria Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-26T07:26:46Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- servicefabricmanagedclusters/resource-manager/readme.md tag:package-2021-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- servicefabricmanagedclusters/resource-manager/readme.md tag:default

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-26T07:26:47Z

Hi, @a-santamaria your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @

openapi-pipeline-app · 2021-01-26T07:26:47Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0630625. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/servicefabricmanagedclusters/resource-manager/readme.md

️✔️servicefabricmanagedclusters [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0630625. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/servicefabricmanagedclusters/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ServiceFabricManagedClusters [View full logs] [Release SDK Changes]
```
warn	Skip artifact folder because it doesn't exist: artifacts/packages
```

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 0630625. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-servicefabricmanagedclusters [View full logs] [Release SDK Changes] Breaking Change Detected
- azure_mgmt_servicefabricmanagedclusters-2021_01_01_preview-py2.py3-none-any.whl
- azure-mgmt-servicefabricmanagedclusters-2021-01-01-preview.zip
```
info	[Changelog]   - Initial Release
```

️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` RestBuild error	"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=192574&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 "

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-26T07:30:40Z

Hi @a-santamaria, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-01-26T20:26:05Z

Hi, @a-santamaria your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ChenTanyi

...eFabricManagedClusters/preview/2021-01-01-preview/examples/NodeTypeGetOperation_example.json

...agedClusters/preview/2021-01-01-preview/examples/ManagedClusterVersionsListByOS_example.json

...FabricManagedClusters/preview/2021-01-01-preview/examples/NodeTypeListOperation_example.json

pilor

A few comments. Up to @ChenTanyi how they feel about splitting out APIs that exist in the service fabric SDK to another SDK

...anager/Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedcluster.json

...er/Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json

ChenTanyi · 2021-01-28T02:36:18Z

A few comments. Up to @ChenTanyi how they feel about splitting out APIs that exist in the service fabric SDK to another SDK

@akning-ms @josefree @PhoenixHe-msft @jianyexi Would you take a look at it?

a-santamaria · 2021-01-28T21:04:37Z

@ChenTanyi I can't figure out what is the issue with the python SDK generation, can you help, please?
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=708047&view=logs&j=b7f68bce-9df8-5468-1c9f-74766cfc9a39&t=25fc8ae6-51ed-58e2-b772-f4d054412fe3

ChenTanyi · 2021-01-29T01:46:14Z

@ChenTanyi I can't figure out what is the issue with the python SDK generation, can you help, please?
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=708047&view=logs&j=b7f68bce-9df8-5468-1c9f-74766cfc9a39&t=25fc8ae6-51ed-58e2-b772-f4d054412fe3

@msyyc @PhoenixHe-msft Could you take a look at the python generation error?

...anagedClusters/preview/2021-01-01-preview/examples/ManagedClusterPatchOperation_example.json

a-santamaria · 2021-02-01T23:26:53Z

@ChenTanyi I can't figure out what is the issue with the python SDK generation, can you help, please?
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=708047&view=logs&j=b7f68bce-9df8-5468-1c9f-74766cfc9a39&t=25fc8ae6-51ed-58e2-b772-f4d054412fe3

@msyyc @PhoenixHe-msft Could you take a look at the python generation error?

@msyyc @PhoenixHe-msft did you get a chance to look at the issue? I don't think its related to the changes its saying that it can't find bundle:

09:09:41.198 cmdout [automation_generate.sh] INFO:packaging_tools.swaggertosdk.SwaggerToSdkNewCLI:Execute after script: bundle install && rake arm:regen_all_profiles['azure_mgmt_service_fabric_managed_clusters'] 09:09:41.777 cmdout [automation_generate.sh] INFO:packaging_tools.swaggertosdk.autorest_tools:==[autorest]/bin/sh: 1: bundle: not found 09:09:41.778 cmdout [automation_generate.sh] ERROR:packaging_tools.swaggertosdk.autorest_tools:Command 'bundle install && rake arm:regen_all_profiles['azure_mgmt_service_fabric_managed_clusters']' returned non-zero exit status 127.

PhoenixHe-NV · 2021-02-02T02:54:40Z

/azp run

azure-pipelines · 2021-02-02T02:54:53Z

Azure Pipelines successfully started running 2 pipeline(s).

a-santamaria · 2021-02-03T19:05:29Z

@ChenTanyi I fixed the issue with the python sdk generation and it's signed off by ARM. Can we merge the pr?

* add servicefabricmanagedclusters folder with 2020-01-01-preview specs * update swagger with version 2021-01-01-preview * fix validation errors * add required systemData param in resources and add missing formats * fix formats * add ipv4Address, fix clusterCertificateThumbprints and descriptions * fix patch (only tags), remvoe clusterVersions, fix nsg * remove unnecessary example * fix patch descriptions and full arm resource id for type version * fix sdk profile name * fix lastModifiedAt description and python sdk path * add missing applicationTypeVersionsCleanupPolicy * fix location description and app example params * remove after_scripts for python sdk Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>

Alfredo Santamaria Gomez added 2 commits January 25, 2021 22:25

add servicefabricmanagedclusters folder with 2020-01-01-preview specs

aca76c1

update swagger with version 2021-01-01-preview

ca863c4

openapi-assignment-bot bot assigned ChenTanyi Jan 26, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 26, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 26, 2021

fix validation errors

962cb5c

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Jan 26, 2021

add required systemData param in resources and add missing formats

094f6c2

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jan 26, 2021

Alfredo Santamaria Gomez added 2 commits January 26, 2021 12:37

fix formats

c2e6790

add ipv4Address, fix clusterCertificateThumbprints and descriptions

75d5d0f

pilor self-requested a review January 27, 2021 00:38

zcxcasd reviewed Jan 27, 2021

View reviewed changes

...eFabricManagedClusters/preview/2021-01-01-preview/examples/NodeTypeGetOperation_example.json Outdated Show resolved Hide resolved

zcxcasd reviewed Jan 27, 2021

View reviewed changes

...agedClusters/preview/2021-01-01-preview/examples/ManagedClusterVersionsListByOS_example.json Outdated Show resolved Hide resolved

zcxcasd reviewed Jan 27, 2021

View reviewed changes

...FabricManagedClusters/preview/2021-01-01-preview/examples/NodeTypeListOperation_example.json Outdated Show resolved Hide resolved

pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 27, 2021

pilor reviewed Jan 27, 2021

View reviewed changes

fix patch (only tags), remvoe clusterVersions, fix nsg

cb85b3d

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 28, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jan 28, 2021

Alfredo Santamaria Gomez added 2 commits January 27, 2021 20:29

remove unnecessary example

e7e1593

fix patch descriptions and full arm resource id for type version

58cf37b

a-santamaria removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 28, 2021

Alfredo Santamaria Gomez added 2 commits January 28, 2021 12:23

fix sdk profile name

aef3935

fix lastModifiedAt description and python sdk path

f28e856

add missing applicationTypeVersionsCleanupPolicy

d09bc24

a-santamaria commented Jan 29, 2021

View reviewed changes

...anagedClusters/preview/2021-01-01-preview/examples/ManagedClusterPatchOperation_example.json Show resolved Hide resolved

fix location description and app example params

2218bd4

pilor self-requested a review January 29, 2021 22:44

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 29, 2021

remove after_scripts for python sdk

12cb520

openapi-pipeline-app bot added the CI-BreakingChange-Python label Feb 3, 2021

ChenTanyi approved these changes Feb 4, 2021

View reviewed changes

ChenTanyi merged commit 0630625 into Azure:master Feb 4, 2021

a-santamaria mentioned this pull request Feb 4, 2021

[Service Fabric Managed Clusters] Adding missing property ClusterUpgradeCadence #12858

Merged

25 tasks

a-santamaria mentioned this pull request Feb 19, 2021

Service Fabric Managed Clusters - initial skd with api version 2021-01-01-preview Azure/azure-sdk-for-net#18875

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Service Fabric Managed Clusters] 2021-01-01-preview #12639

[Service Fabric Managed Clusters] 2021-01-01-preview #12639

a-santamaria commented Jan 26, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 26, 2021

openapi-pipeline-app bot commented Jan 26, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 26, 2021

openapi-pipeline-app bot commented Jan 26, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 26, 2021

openapi-workflow-bot bot commented Jan 26, 2021

pilor left a comment

ChenTanyi commented Jan 28, 2021

a-santamaria commented Jan 28, 2021 •

edited

Loading

ChenTanyi commented Jan 29, 2021

a-santamaria commented Feb 1, 2021

PhoenixHe-NV commented Feb 2, 2021

azure-pipelines bot commented Feb 2, 2021

a-santamaria commented Feb 3, 2021

[Service Fabric Managed Clusters] 2021-01-01-preview #12639

[Service Fabric Managed Clusters] 2021-01-01-preview #12639

Conversation

a-santamaria commented Jan 26, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 26, 2021

openapi-pipeline-app bot commented Jan 26, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Jan 26, 2021

openapi-pipeline-app bot commented Jan 26, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 26, 2021

openapi-workflow-bot bot commented Jan 26, 2021

pilor left a comment

Choose a reason for hiding this comment

ChenTanyi commented Jan 28, 2021

a-santamaria commented Jan 28, 2021 • edited Loading

ChenTanyi commented Jan 29, 2021

a-santamaria commented Feb 1, 2021

PhoenixHe-NV commented Feb 2, 2021

azure-pipelines bot commented Feb 2, 2021

a-santamaria commented Feb 3, 2021

a-santamaria commented Jan 26, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 26, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 26, 2021 •

edited

Loading

a-santamaria commented Jan 28, 2021 •

edited

Loading