[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2021-03-01 #12765

worldhello126 · 2021-02-01T19:06:11Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…e/2020-11-01 to version 2021-03-01

openapi-workflow-bot · 2021-02-01T19:06:14Z

Hi, @worldhello126 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-02-01T19:06:14Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- containerinstance/resource-manager/readme.md tag:package-2021-03
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- containerinstance/resource-manager/readme.md tag:default

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 14 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2018-02-01-preview/containerInstance.json <---> new: stable/2021-03-01/containerInstance.json

Rule	Message
⚠️ 1008 - ModifiedOperationId	The operation id has been changed from 'ContainerGroupUsage_List' to 'Location_ListUsage'. This will impact generated code. New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L452:7 Old: Microsoft.ContainerInstance/preview/2018-02-01-preview/containerInstance.json#L290:7
⚠️ 1008 - ModifiedOperationId	The operation id has been changed from 'ContainerLogs_List' to 'Containers_ListLogs'. This will impact generated code. New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L491:7 Old: Microsoft.ContainerInstance/preview/2018-02-01-preview/containerInstance.json#L320:7
⚠️ 1008 - ModifiedOperationId	The operation id has been changed from 'StartContainer_LaunchExec' to 'Containers_ExecuteCommand'. This will impact generated code. New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L550:7 Old: Microsoft.ContainerInstance/preview/2018-02-01-preview/containerInstance.json#L367:7
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L61:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L101:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L147:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L200:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L248:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L286:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.ContainerInstance/stable/2021-03-01/containerInstance.json#L292:11

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-11-01/containerInstance.json <---> new: stable/2021-03-01/containerInstance.json

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-01T19:06:15Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1f2f490. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md

️✔️@azure/arm-containerinstance [View full logs] [Release SDK Changes]

azure-arm-containerinstance-6.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/containerInstanceManagementClient.js → ./dist/arm-containerinstance.js...
cmderr	[npmPack] created ./dist/arm-containerinstance.js in 351ms

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 1f2f490. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-containerinstance [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model LogAnalytics has a new parameter workspace_resource_id
info	[Changelog]   - Model ContainerHttpGet has a new parameter http_headers
info	[Changelog]   - Added operation ContainersOperations.attach
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation ContainersOperations.list_logs has a new signature

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1f2f490. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ContainerInstance [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.ContainerInstance.3.0.0.nupkg
- Microsoft.Azure.Management.ContainerInstance.3.0.0.snupkg

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1f2f490. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md

️✔️containerinstance [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1f2f490. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️containerinstance/mgmt/2020-11-01/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️containerinstance/mgmt/2019-12-01/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️containerinstance/mgmt/2018-10-01/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️containerinstance/mgmt/2018-09-01/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️containerinstance/mgmt/2018-06-01/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️containerinstance/mgmt/2018-04-01/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/containerinstance/mgmt/2018-02-01-preview/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/containerinstance/mgmt/2017-12-01-preview/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/containerinstance/mgmt/2017-10-01-preview/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/containerinstance/mgmt/2017-08-01-preview/containerinstance [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 1f2f490. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-04 01:23:13 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-containerinstance-generated"
cmderr	[generate.py] 2021-02-04 01:23:13 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-04 01:23:13 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/containerinstance/azure-resourcemanager-containerinstance-generated --java.namespace=com.azure.resourcemanager.containerinstance.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/containerinstance/resource-manager/readme.md
cmderr	[generate.py] 2021-02-04 01:23:57 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-04 01:23:57 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-04 01:23:57 INFO [POM][Skip] pom already has module azure-resourcemanager-containerinstance-generated
cmderr	[generate.py] 2021-02-04 01:23:57 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-04 01:23:57 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-04 01:23:57 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-containerinstance-generated [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-04 01:26:58 DEBUG Got artifact_id: azure-resourcemanager-containerinstance-generated
cmderr	[Inst] 2021-02-04 01:26:58 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-04 01:26:58 DEBUG Got artifact: azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-04 01:26:58 DEBUG Match jar package: azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-04 01:26:58 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12765/azure-sdk-for-java/azure-resourcemanager-containerinstance-generated/azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-containerinstance-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-containerinstance-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

worldhello126 · 2021-02-01T19:12:12Z

/azp run unifiedPipeline

azure-pipelines · 2021-02-01T19:12:17Z

No pipelines are associated with this pull request.

openapi-workflow-bot · 2021-02-01T19:23:48Z

Hi, @worldhello126 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @PhoenixHe-msft

… version stable/2021-03-01 (Azure#12765) * Adds base for updating Microsoft.ContainerInstance from version stable/2020-11-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples

worldhello126 added 3 commits February 1, 2021 11:02

Adds base for updating Microsoft.ContainerInstance from version stabl…

6c6ab2b

…e/2020-11-01 to version 2021-03-01

Updates readme

fa91e08

Updates API version in new specs and examples

e2e73e9

openapi-pipeline-app bot added the CI-BreakingChange-Python label Feb 1, 2021

worldhello126 marked this pull request as ready for review February 1, 2021 19:22

worldhello126 requested a review from novinc as a code owner February 1, 2021 19:22

openapi-assignment-bot bot assigned PhoenixHe-NV Feb 1, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 1, 2021

jorgecotillo added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 2, 2021

PhoenixHe-NV approved these changes Feb 4, 2021

View reviewed changes

PhoenixHe-NV merged commit 1f2f490 into Azure:master Feb 4, 2021

novinc mentioned this pull request May 5, 2021

update azure container instance client to 2021-03-01 api version Azure/azure-sdk-for-net#20644

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2021-03-01 #12765

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2021-03-01 #12765

worldhello126 commented Feb 1, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 1, 2021

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

worldhello126 commented Feb 1, 2021

azure-pipelines bot commented Feb 1, 2021

openapi-workflow-bot bot commented Feb 1, 2021

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2021-03-01 #12765

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2021-03-01 #12765

Conversation

worldhello126 commented Feb 1, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 1, 2021

openapi-pipeline-app bot commented Feb 1, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 1, 2021 • edited Loading

Swagger Generation Artifacts

worldhello126 commented Feb 1, 2021

azure-pipelines bot commented Feb 1, 2021

openapi-workflow-bot bot commented Feb 1, 2021

worldhello126 commented Feb 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2021 •

edited

Loading