Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the Default Error Response for 2020-06-01-preview APIs #12800

Merged
merged 10 commits into from
Feb 7, 2021

Conversation

nichatur
Copy link
Contributor

@nichatur nichatur commented Feb 3, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Fixes Issue https://github.com/Azure/azure-rest-api-specs/issues/12820 under which the error message does not propagate correctly for preview APIs under 2020-06-01-preview. This is fixed by leveraging Microsoft.Azure.Rest.CloudError instead of creating a new model for DefaultErrorResponse. This is not a breaking change.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @nichatur Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 3, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 3, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2515952. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-cosmosdb [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model SqlContainerGetPropertiesResource has a new parameter analytical_storage_ttl
      info	[Changelog]   - Model SqlContainerResource has a new parameter analytical_storage_ttl
      info	[Changelog]   - Added operation MongoDBResourcesOperations.migrate_mongo_db_database_to_manual_throughput
      info	[Changelog]   - Added operation MongoDBResourcesOperations.migrate_mongo_db_collection_to_autoscale
      info	[Changelog]   - Added operation MongoDBResourcesOperations.migrate_mongo_db_database_to_autoscale
      info	[Changelog]   - Added operation MongoDBResourcesOperations.migrate_mongo_db_collection_to_manual_throughput
      info	[Changelog]   - Added operation SqlResourcesOperations.migrate_sql_container_to_manual_throughput
      info	[Changelog]   - Added operation SqlResourcesOperations.migrate_sql_container_to_autoscale
      info	[Changelog]   - Added operation SqlResourcesOperations.migrate_sql_database_to_autoscale
      info	[Changelog]   - Added operation SqlResourcesOperations.migrate_sql_database_to_manual_throughput
      info	[Changelog]   - Added operation TableResourcesOperations.migrate_table_to_autoscale
      info	[Changelog]   - Added operation TableResourcesOperations.migrate_table_to_manual_throughput
      info	[Changelog]   - Added operation GremlinResourcesOperations.migrate_gremlin_database_to_autoscale
      info	[Changelog]   - Added operation GremlinResourcesOperations.migrate_gremlin_graph_to_autoscale
      info	[Changelog]   - Added operation GremlinResourcesOperations.migrate_gremlin_database_to_manual_throughput
      info	[Changelog]   - Added operation GremlinResourcesOperations.migrate_gremlin_graph_to_manual_throughput
      info	[Changelog]   - Added operation CassandraResourcesOperations.migrate_cassandra_keyspace_to_autoscale
      info	[Changelog]   - Added operation CassandraResourcesOperations.migrate_cassandra_table_to_autoscale
      info	[Changelog]   - Added operation CassandraResourcesOperations.migrate_cassandra_keyspace_to_manual_throughput
      info	[Changelog]   - Added operation CassandraResourcesOperations.migrate_cassandra_table_to_manual_throughput
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model CassandraTableCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model MongoDBCollectionGetResults no longer has parameter identity
      info	[Changelog]   - Model SqlStoredProcedureGetResults no longer has parameter identity
      info	[Changelog]   - Model SqlTriggerGetResults no longer has parameter identity
      info	[Changelog]   - Model DatabaseAccountGetResults no longer has parameter create_mode
      info	[Changelog]   - Model DatabaseAccountGetResults no longer has parameter instance_id
      info	[Changelog]   - Model DatabaseAccountGetResults no longer has parameter identity
      info	[Changelog]   - Model DatabaseAccountGetResults no longer has parameter restore_parameters
      info	[Changelog]   - Model DatabaseAccountGetResults no longer has parameter system_data
      info	[Changelog]   - Model GremlinGraphGetResults no longer has parameter identity
      info	[Changelog]   - Model ThroughputSettingsGetResults no longer has parameter identity
      info	[Changelog]   - Model DatabaseAccountUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model ARMResourceProperties no longer has parameter identity
      info	[Changelog]   - Model MongoDBDatabaseGetResults no longer has parameter identity
      info	[Changelog]   - Model SqlUserDefinedFunctionGetResults no longer has parameter identity
      info	[Changelog]   - Model SqlContainerGetResults no longer has parameter identity
      info	[Changelog]   - Model CassandraTableGetResults no longer has parameter identity
      info	[Changelog]   - Model CassandraKeyspaceCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model SqlTriggerCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model SqlDatabaseGetResults no longer has parameter identity
      info	[Changelog]   - Model SqlContainerCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model GremlinDatabaseCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model TableGetResults no longer has parameter identity
      info	[Changelog]   - Model MongoDBDatabaseCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model CassandraKeyspaceGetResults no longer has parameter identity
      info	[Changelog]   - Model TableCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model SqlDatabaseCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model MongoDBCollectionCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model GremlinGraphCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model SqlUserDefinedFunctionCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model ThroughputSettingsUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model SqlStoredProcedureCreateUpdateParameters no longer has parameter identity
      info	[Changelog]   - Model GremlinDatabaseGetResults no longer has parameter identity
      info	[Changelog]   - Model DatabaseAccountCreateUpdateParameters has a new signature
      info	[Changelog]   - Removed operation SqlResourcesOperations.get_sql_role_definition
      info	[Changelog]   - Removed operation SqlResourcesOperations.list_sql_role_assignments
      info	[Changelog]   - Removed operation SqlResourcesOperations.create_update_sql_role_definition
      info	[Changelog]   - Removed operation SqlResourcesOperations.list_sql_role_definitions
      info	[Changelog]   - Removed operation SqlResourcesOperations.delete_sql_role_assignment
      info	[Changelog]   - Removed operation SqlResourcesOperations.get_sql_role_assignment
      info	[Changelog]   - Removed operation SqlResourcesOperations.delete_sql_role_definition
      info	[Changelog]   - Removed operation SqlResourcesOperations.create_update_sql_role_assignment
      info	[Changelog]   - Removed operation group RestorableSqlContainersOperations
      info	[Changelog]   - Removed operation group RestorableDatabaseAccountsOperations
      info	[Changelog]   - Removed operation group RestorableSqlResourcesOperations
      info	[Changelog]   - Removed operation group RestorableMongodbResourcesOperations
      info	[Changelog]   - Removed operation group RestorableSqlDatabasesOperations
      info	[Changelog]   - Removed operation group RestorableMongodbCollectionsOperations
      info	[Changelog]   - Removed operation group RestorableMongodbDatabasesOperations
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2515952. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-02-18 09:55:29 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-cosmos-generated"
      cmderr	[generate.py] 2021-02-18 09:55:29 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-02-18 09:55:29 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.16 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/cosmos/azure-resourcemanager-cosmos-generated --java.namespace=com.azure.resourcemanager.cosmos.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md
      cmderr	[generate.py] 2021-02-18 09:56:33 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-02-18 09:56:33 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-02-18 09:56:33 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-02-18 09:56:33 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-02-18 09:56:33 INFO [POM][Skip] pom already has module sdk/cosmos
      cmderr	[generate.py] 2021-02-18 09:56:33 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-cosmos-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-02-18 10:00:49 DEBUG Got artifact_id: azure-resourcemanager-cosmos-generated
      cmderr	[Inst] 2021-02-18 10:00:49 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-02-18 10:00:49 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-02-18 10:00:49 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-02-18 10:00:49 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-18 10:00:49 DEBUG Match jar package: azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-18 10:00:49 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12800/azure-sdk-for-java/azure-resourcemanager-cosmos-generated/azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-cosmos-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2515952. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️cosmos-db/mgmt/2019-08-01/documentdb [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️cosmos-db/mgmt/2015-04-08/documentdb [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2020-09-01-preview/documentdb [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] This package was removed
    • ️✔️preview/cosmos-db/mgmt/2020-06-01-preview/documentdb [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - Field `Location` of struct `RestorableSQLContainerGetResult` has been removed
      info	[Changelog] - Field `Tags` of struct `RestorableSQLContainerGetResult` has been removed
      info	[Changelog] - Field `Identity` of struct `RestorableSQLContainerGetResult` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `Local`
      info	[Changelog] - New const `Zone`
      info	[Changelog] - New const `Geo`
      info	[Changelog] - New function `PossibleBackupStorageRedundancyValues() []BackupStorageRedundancy`
      info	[Changelog] - New struct `CloudError`
      info	[Changelog] - New field `BackupStorageRedundancy` in struct `PeriodicModeProperties`
      info	[Changelog]
      info	[Changelog] Total 7 breaking change(s), 7 additive change(s).
      info	[Changelog]
    • ️✔️preview/cosmos-db/mgmt/2020-04-01-preview/documentdb [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2020-03-01-preview/documentdb [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2019-12-12-preview/documentdb [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/cosmos-db/mgmt/2019-08-01-preview/documentdb [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2515952. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md
    • ️✔️@azure/arm-cosmosdb [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/cosmosDBManagementClient.js → ./dist/arm-cosmosdb.js...
      cmderr	[npmPack] created ./dist/arm-cosmosdb.js in 892ms
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2515952. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/mongodb/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/gremlin/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/sql/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/mongodb/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/gremlin/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/sql/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/mongodb/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/gremlin/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/sql/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/mongodb/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/gremlin/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/sql/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/mongodb/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/gremlin/databases/{databaseName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.DocumentDB/databaseAccounts/apis/databases. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/apis/sql/databases/{databaseName}'.
    • ️✔️cosmos-db [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
      cmderr	[resource-manager]  ELIFECYCLE
      cmderr	[resource-manager] npm ERR! errno 3
      cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 test: `mocha -r ts-node/register tests.ts`
      cmderr	[resource-manager] npm ERR! Exit status 3
      cmderr	[resource-manager] npm ERR!
      cmderr	[resource-manager] npm ERR! Failed at the template-schema-validation-tools@1.0.0 test script.
      cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
      cmderr	[resource-manager]  A complete log of this run can be found in:
      cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-02-18T09_57_04_421Z-debug.log
      cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
      cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
      cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
      cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
      cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
      cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
      cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
      cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
      cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
      cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
      cmderr	[resource-manager]   status: 3,
      cmderr	[resource-manager]   signal: null,
      cmderr	[resource-manager]   output: [ null, null, null ],
      cmderr	[resource-manager]   pid: 3174,
      cmderr	[resource-manager]   stdout: null,
      cmderr	[resource-manager]   stderr: null
      cmderr	[resource-manager] }
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @nichatur, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @openapi-workflow-bot
    Copy link

    Hi @nichatur, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @zhenglaizhang
    Copy link
    Contributor

    zhenglaizhang commented Feb 5, 2021

    Hi @nichatur for SDK Track2 validation issues #12800 (comment) its recommended to fix otherwise this may block future SDK track2 generation, here is the doc https://github.com/Azure/autorest/blob/master/docs/openapi/prechecker.md

    And for ApiDocPreview failure you can ignore this as current this task doesn't support same operation id prefix SqlResources across different swagger files.

    @zhenglaizhang zhenglaizhang merged commit 2515952 into Azure:master Feb 7, 2021
    This was referenced Feb 7, 2021
    @00Kai0
    Copy link
    Contributor

    00Kai0 commented Feb 18, 2021

    /azp run

    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    …12800)
    
    * Fixing the Default Error Response for 2020-06-01-preview APIs
    
    * Removing refs to ErrorResponse and removing new props from CloudErrorBody
    
    * Revert "Removing refs to ErrorResponse and removing new props from CloudErrorBody"
    
    This reverts commit a955700.
    
    * Adding ErrorResponse back to avoid breaking change
    
    * Removing CloudErrorBody
    
    * Making change as minimal as possible
    
    * Trigger Build
    
    * Adding model duplication leniency
    
    * Lenient Dedup
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Error Message does not propagate correctly for CosmosDB API Version 2020-06-01-preview
    4 participants