Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Devices to add version stable/2020-03-01 #12914

Merged
merged 11 commits into from
Mar 1, 2021
Merged

[Hub Generated] Review request for Microsoft.Devices to add version stable/2020-03-01 #12914

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b05842e
fixing existing api version swagger correctness
sudeepmsft Feb 9, 2021
c40022b
fixing the example
sudeepmsft Feb 9, 2021
f5d99f0
fixing arm error in validation - reverting changes as needs to be
sudeepmsft Feb 9, 2021
6cde24d
moving the breaking changes to new version
sudeepmsft Feb 10, 2021
87d479b
changing example file and bringing api spec in parity with the existing
sudeepmsft Feb 15, 2021
4524de0
adding prettier check validation fix
sudeepmsft Feb 18, 2021
3d3b5af
fixing model validation
sudeepmsft Feb 19, 2021
f7b3613
cert or pem content is byte format
sudeepmsft Feb 19, 2021
4daa01c
prettier validation fix
sudeepmsft Feb 19, 2021
3ac939a
removing lintdiff errors
sudeepmsft Feb 27, 2021
89fe1a4
adding a format type for cert
sudeepmsft Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ce-manager/Microsoft.Devices/stable/2020-03-01/examples/DPSCertificateCreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"properties": {
"subject": "CN=testdevice1",
"expiry": "Sat, 31 Dec 2039 23:59:59 GMT",
"certificate": "############################################",
"thumbprint": "97388663832D0393C9246CAB4FBA2C8677185A25",
"isVerified": false,
"created": "Thu, 12 Oct 2017 19:23:50 GMT",
Expand Down
2 changes: 2 additions & 0 deletions ...ningservices/resource-manager/Microsoft.Devices/stable/2020-03-01/examples/DPSCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
"type": "Microsoft.Devices/ProvisioningServices",
"id": "/subscriptions/91d12660-3dec-467a-be2a-213b5544ddc0/resourceGroups//providers/Microsoft.Devices/ProvisioningServices/myFirstProvisioningService",
"tags": {},
"resourceGroup": "myResourceGroup",
"subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0",
"sku": {
"name": "S1",
"tier": "Standard",
Expand Down
1 change: 1 addition & 0 deletions ...rce-manager/Microsoft.Devices/stable/2020-03-01/examples/DPSGenerateVerificationCode.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"subject": "CN=andbucdevice1",
"expiry": "Sat, 31 Dec 2039 23:59:59 GMT",
"thumbprint": "##############################",
"certificate": "###########################",
"isVerified": false,
"created": "Thu, 12 Oct 2017 19:23:50 GMT",
"updated": "Thu, 12 Oct 2017 19:26:56 GMT"
Expand Down
2 changes: 2 additions & 0 deletions ...sioningservices/resource-manager/Microsoft.Devices/stable/2020-03-01/examples/DPSGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
"type": "Microsoft.Devices/ProvisioningServices",
"id": "/subscriptions/91d12660-3dec-467a-be2a-213b5544ddc0/resourceGroups/myResourceGroup/providers/Microsoft.Devices/ProvisioningServices/myFirstProvisioningService",
"tags": {},
"subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0",
"resourceGroup": "myResourceGroup",
"sku": {
"name": "S1",
"tier": "Standard",
Expand Down
5 changes: 4 additions & 1 deletion ...ices/resource-manager/Microsoft.Devices/stable/2020-03-01/examples/DPSGetCertificate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,17 @@
"subject": "CN=testdevice1",
"expiry": "Sat, 31 Dec 2039 23:59:59 GMT",
"thumbprint": "97388663832D0393C9246CAB4FBA2C8677185A25",
"certificate": "######################################",
"isVerified": false,
"created": "Thu, 12 Oct 2017 19:23:50 GMT",
"updated": "Thu, 12 Oct 2017 19:23:50 GMT"
},
"id": "/subscriptions/91d12660-3dec-467a-be2a-213b5544ddc0/resourceGroups/myResourceGroup/providers/Microsoft.Devices/IotHubs/andbuc-hub/certificates/cert",
"name": "cert",
"type": "Microsoft.Devices/ProvisioningServices/Certificates",
"etag": "AAAAAAExpNs="
"etag": "AAAAAAExpNs=",
"resourceGroup": "myResourceGroup",
"subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0"
}
}
}
Expand Down
5 changes: 5 additions & 0 deletions .../resource-manager/Microsoft.Devices/stable/2020-03-01/examples/DPSGetOperationResult.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
"body": {
"status": "Succeeded"
}
},
"202": {
"body": {
"status": "Accepted"
}
}
}
}
2 changes: 2 additions & 0 deletions ...resource-manager/Microsoft.Devices/stable/2020-03-01/examples/DPSListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
},
{
"etag": "AAAAAAAADGk=",
"resourceGroup": "myResourceGroup",
"subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0",
"name": "mySecondProvisioningService",
"location": "eastus",
"properties": {
Expand Down
2 changes: 2 additions & 0 deletions .../resource-manager/Microsoft.Devices/stable/2020-03-01/examples/DPSListBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
},
{
"etag": "AAAAAAAADGk=",
"resourceGroup": "myResourceGroup",
"subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0",
"name": "mySecondProvisioningService",
"location": "eastus",
"properties": {
Expand Down
2 changes: 2 additions & 0 deletions ...oningservices/resource-manager/Microsoft.Devices/stable/2020-03-01/examples/DPSPatch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
"tags": {
"foo": "bar"
},
"subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0",
"resourceGroup": "myResourceGroup",
"sku": {
"name": "S1",
"tier": "Standard",
Expand Down
1 change: 1 addition & 0 deletions ...s/resource-manager/Microsoft.Devices/stable/2020-03-01/examples/DPSVerifyCertificate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"properties": {
"subject": "CN=andbucdevice1",
"expiry": "Sat, 31 Dec 2039 23:59:59 GMT",
"certificate": "#####################################",
"thumbprint": "97388663832D0393C9246CAB4FBA2C8677185A25",
"isVerified": true,
"created": "Thu, 12 Oct 2017 19:23:50 GMT",
Expand Down
20 changes: 19 additions & 1 deletion ...viceprovisioningservices/resource-manager/Microsoft.Devices/stable/2020-03-01/iotdps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1716,6 +1716,11 @@
"type": "boolean",
"readOnly": true
},
"certificate": {
"description": "base-64 representation of X509 certificate .cer file or just .pem file content.",
"type": "string",
"readOnly": true
markcowl marked this conversation as resolved.
Show resolved Hide resolved
},
"created": {
"description": "The certificate's creation date and time.",
"type": "string",
Expand Down Expand Up @@ -1765,6 +1770,14 @@
"description": "The Etag field is *not* required. If it is provided in the response body, it must also be provided as a header per the normal ETag convention.",
"type": "string"
},
"resourceGroup": {
"description": "The resource group name uniquely identifies the resource group within the user subscriptionId.",
"type": "string"
},
"subscriptionid": {
"description": "The subscriptionId for the Azure user",
"type": "string"
},
"properties": {
"description": "Service specific properties for a provisioning service",
"$ref": "#/definitions/IotDpsPropertiesDescription"
Expand Down Expand Up @@ -2252,7 +2265,8 @@
"properties": {
"code": {
"description": "The error code.",
"type": "string",
"type": "integer",
"format": "int32",
"readOnly": true
},
"httpStatusCode": {
Expand Down Expand Up @@ -2440,6 +2454,10 @@
"type": "boolean",
"description": "Indicate if the certificate is verified by owner of private key."
},
"certificate": {
"description": "base-64 representation of X509 certificate .cer file or just .pem file content.",
"type": "string"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is always base64-encoded, need to add "format": "byte"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a .cer or pem content. Added a fix.

},
"created": {
"type": "string",
"description": "Certificate created time."
Expand Down