Update Synapse with ADF swagger changes/2019-06-01-preview #12924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @drosales57 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: type Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2950 |
|
| The enum types should have x-ms-enum type extension set with appropriate options. Property name: type Location: Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json#L2950 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️❌SemanticValidation: 7 Errors, 0 Warnings failed [Detail]
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 4 Errors, 67 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:812" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:816" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.id.$ref: undefined => "#/components/schemas/schemas:1109", properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Error: Plugin prechecker reported failure." |
| "readme":"synapse/data-plane/readme.md", "tag":"package-artifacts-2019-06-01-preview", "details":"The schema 'SubResource' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/data-plane/readme.md", "tag":"package-artifacts-2019-06-01-preview", "details":"The schema 'ScheduleTrigger' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/data-plane/readme.md", "tag":"package-artifacts-2019-06-01-preview", "details":"The schema 'ScheduleTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/data-plane/readme.md", "tag":"package-artifacts-2019-06-01-preview", "details":"The schema 'BlobTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/data-plane/readme.md", "tag":"package-artifacts-2019-06-01-preview", "details":"The schema 'BlobEventsTrigger' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/data-plane/readme.md", "tag":"package-artifacts-2019-06-01-preview", "details":"The schema 'BlobEventsTrigger-typeProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️❌[Staging] PrettierCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Code style issues found path: preview/2019-06-01-preview/entityTypes/Dataset.json |
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @drosales57, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
ajay-arora
approved these changes
Feb 10, 2021
drosales57
changed the title
idear1203
reviewed
Feb 19, 2021
| @@ -335,12 +335,55 @@ | |||
| "Microsoft.Storage.BlobDeleted" | |||
| ], | |||
| "x-ms-enum": { | |||
| "name": "BlobEventType", | |||
| "name": "BlobEventTypes", | |||
There was a problem hiding this comment.
BlobEventTypes [](start = 19, length = 14)
Can we keep the previous BlobEventType ? I made that change before to fix the CI pipeline issue:
"readme":"synapse/data-plane/readme.md",
"tag":"package-artifacts-2019-06-01-preview",
"details":"Duplicate Schema named BlobEventTypes -- type: undefined => "string",
items: "$ref":"#/components/schemas/BlobEventTypes" =>,
enum: undefined => ["Microsoft.Storage.BlobCreated",
"Microsoft.Storage.BlobDeleted"],
x-ms-enum: undefined => "name":"BlobEventTypes",
"modelAsString":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
…apse Fix CI pipeline issues
|
Hi @drosales57, Your PR has some issues. Please fix the CI sequentially by following the order of
|
….com/drosales57/azure-rest-api-specs into darosale/refreshAdfSwaggerForSynapse
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
added 2 commits
February 23, 2021 20:31
idear1203
reviewed
Mar 11, 2021
| @@ -624,6 +650,7 @@ | |||
| }, | |||
| "DynamicsCrmLinkedServiceTypeProperties": { | |||
| "description": "Dynamics CRM linked service properties.", | |||
| "type": "object", | |||
There was a problem hiding this comment.
"type": "object", [](start = 6, length = 17)
string
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
NewApiVersionRequired
and removed
CI-FixRequiredOnFailure
labels
|
NewApiVersionRequired reason: |
joheredi
reviewed
Mar 11, 2021
...ion/synapse/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/entityTypes/Dataset.json
Show resolved
Hide resolved
joheredi
reviewed
Mar 11, 2021
...ion/synapse/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/entityTypes/Dataset.json
Show resolved
Hide resolved
joheredi
reviewed
Mar 11, 2021
...ion/synapse/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/entityTypes/Dataset.json
Show resolved
Hide resolved
joheredi
reviewed
Mar 11, 2021
...ion/synapse/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/entityTypes/Dataset.json
Show resolved
Hide resolved
@drosales57, @idear1203 I would like to understand better the scenario when |
Many fields in datasets, linkedservices, and pipeline activities can have an expresssion or static value like an integer or stirng. Here's the sample payload that we would publish Now say the customer wants to vary the wait time in the Wait activity based on a pipeline parameter value. Below we have pipeline parameter called "waitTimeParameter" We can reference this pipeline parameter value using the expression (type object): |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
lmazuel
approved these changes
Mar 17, 2021
This was referenced Mar 17, 2021
[ReleasePR synapse] [Synapse] - Remove x-ms-azure-resource
Azure/azure-resource-manager-schemas#1315
Merged
MirzaSikander
pushed a commit
to MirzaSikander/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2021
* initial changes * Fix CI pipeline issues * address comment * Fix CI pipeline errors * Fix syntax errors in example files * Fix CI pipeline errors * Resolve CI errors * Fix CI issues * Change dataFlow to dataflow * address review comments * address comment * fix enums that support expressions * Fix comment Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* initial changes * Fix CI pipeline issues * address comment * Fix CI pipeline errors * Fix syntax errors in example files * Fix CI pipeline errors * Resolve CI errors * Fix CI issues * Change dataFlow to dataflow * address review comments * address comment * fix enums that support expressions * Fix comment Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.