Add new sql pool resource properties #12977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @chzachar Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version has a new property 'maxServiceObjectiveName' in response that was not found in the old version. New: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L279:7 Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L279:7 |
|
The new version has a new property 'autoPauseTimer' in response that was not found in the old version. New: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L279:7 Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L279:7 |
|
The new version has a new property 'autoResume' in response that was not found in the old version. New: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L279:7 Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L279:7 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 5 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-sqlGen3-2020-04-01-preview", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-sqlGen3-2020-04-01-preview", "details":"The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-sqlGen3-2020-04-01-preview", "details":"The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-sqlGen3-2020-04-01-preview", "details":"The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-sqlGen3-2020-04-01-preview", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
markcowl
added
the
DoNotMerge
|
Breaking Change request is filed here: https://msazure.visualstudio.com/One/_workitems/edit/9349575 |
JeffreyRichter
approved these changes
Feb 18, 2021
JeffreyRichter
added
the
Approved-BreakingChange
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Feb 18, 2021
markcowl
approved these changes
Feb 24, 2021
|
@chzacar What is your intention with this PR, the title indicates it should not be merged. If you don't plan to merge it, please close or convert to a draft PR. |
Hi @markcowl, I have marked it [donotmerge] since the changes to the API source code are not yet deployed. My understanding is that we should not check in these changes until backend API changes are deployed worldwide, correct? |
|
@chzacar The service should definitely be deployed before we push changes to master. I will mark as 'OKToMerge' so you can merge quickly once the api is ready. |
markcowl
added
Approved-OkToMerge
chzachar
changed the title
|
This PR is now ready to be checked in, since underlying service deployment is completed in the MS_1506081_2021_04_21_hotfix train. |
This was referenced May 24, 2021
Merged
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
May 24, 2021
This was referenced May 24, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.