[Hub Generated] Review request for Microsoft.Synapse to add version stable/2021-03-01 #13070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @srinuthati Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response of operation:'Library_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-03-01/library.json#L25 |
|
The nested resource 'DataWarehouseUserActivities' does not have list operation, please add it. Location: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L5658 |
|
The nested resource 'SqlPoolConnectionPolicy' does not have list operation, please add it. Location: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L6596 |
|
The nested resource 'SqlPoolVulnerabilityAssessmentRuleBaseline' does not have list operation, please add it. Location: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L6960 |
|
The nested resource 'DataMaskingPolicy' does not have list operation, please add it. Location: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L7206 |
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Synapse/stable/2021-03-01/integrationRuntime.json#L2808 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Synapse/stable/2021-03-01/integrationRuntime.json#L2867 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Synapse/stable/2021-03-01/integrationRuntime.json#L2888 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Synapse/stable/2021-03-01/integrationRuntime.json#L780 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Synapse/stable/2021-03-01/integrationRuntime.json#L1059 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The JSON file has a circular reference. readme: specification/synapse/resource-manager/readme.md json: Microsoft.Synapse/stable/2021-03-01/workspace.json |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 163 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2019-06-01-preview/bigDataPool.json <---> new: stable/2021-03-01/bigDataPool.json
- original: preview/2019-06-01-preview/checkNameAvailability.json <---> new: stable/2021-03-01/checkNameAvailability.json
- original: preview/2019-06-01-preview/firewallRule.json <---> new: stable/2021-03-01/firewallRule.json
- original: preview/2019-06-01-preview/integrationRuntime.json <---> new: stable/2021-03-01/integrationRuntime.json
- original: preview/2019-06-01-preview/keys.json <---> new: stable/2021-03-01/keys.json
- original: preview/2020-04-01-preview/operations.json <---> new: stable/2021-03-01/operations.json
- original: preview/2019-06-01-preview/privateEndpointConnections.json <---> new: stable/2021-03-01/privateEndpointConnections.json
- original: preview/2019-06-01-preview/privateLinkResources.json <---> new: stable/2021-03-01/privateLinkResources.json
- original: preview/2019-06-01-preview/privatelinkhub.json <---> new: stable/2021-03-01/privatelinkhub.json
- original: preview/2020-04-01-preview/sqlPool.json <---> new: stable/2021-03-01/sqlPool.json
- original: preview/2019-06-01-preview/sqlServer.json <---> new: stable/2021-03-01/sqlServer.json
- original: preview/2019-06-01-preview/workspace.json <---> new: stable/2021-03-01/workspace.json
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/recoverableSqlpools' removed or restructured? Old: Microsoft.Synapse/preview/2019-06-01-preview/sqlServer.json#L848:5 |
|
| The new version is missing a definition that was found in the old version. Was 'SqlPoolProperties' removed or renamed? New: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L5230:3 Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L275:3 |
|
| The new version is missing a definition that was found in the old version. Was 'SqlPoolV3' removed or renamed? New: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L5230:3 Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L275:3 |
|
| The new version is missing a definition that was found in the old version. Was 'SqlPoolUpdate' removed or renamed? New: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L5230:3 Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L275:3 |
|
| The new version is missing a definition that was found in the old version. Was 'SystemData' removed or renamed? New: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L5230:3 Old: Microsoft.Synapse/preview/2020-04-01-preview/sqlPool.json#L275:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'WorkspaceNameParameter' removed or renamed? New: azure-rest-api-specs/blob/bf1b1286065a0cca6aa74cf9fead7dda956ea135/revision:1974:2 Old: azure-rest-api-specs/blob/master/revision:1818:2 |
|
| The new version is missing a client parameter that was found in the old version. Was 'WorkspaceNameParameter' removed or renamed? New: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L7604:3 Old: azure-rest-api-specs/blob/master/revision:844:2 |
|
| The new version is missing a client parameter that was found in the old version. Was 'SqlPoolNameParameter' removed or renamed? New: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L7604:3 Old: azure-rest-api-specs/blob/master/revision:844:2 |
|
| The operation id has been changed from 'SqlV3Operations_List' to 'Operations_List'. This will impact generated code. New: Microsoft.Synapse/stable/2021-03-01/operations.json#L25:7 Old: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L25:7 |
|
| The operation id has been changed from 'SqlV3Operations_GetLocationHeaderResult' to 'Operations_GetLocationHeaderResult'. This will impact generated code. New: Microsoft.Synapse/stable/2021-03-01/operations.json#L62:7 Old: Microsoft.Synapse/preview/2020-04-01-preview/operations.json#L62:7 |
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 2 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-12-01/bigDataPool.json <---> new: stable/2021-03-01/bigDataPool.json
- original: stable/2020-12-01/checkNameAvailability.json <---> new: stable/2021-03-01/checkNameAvailability.json
- original: stable/2020-12-01/firewallRule.json <---> new: stable/2021-03-01/firewallRule.json
- original: stable/2020-12-01/integrationRuntime.json <---> new: stable/2021-03-01/integrationRuntime.json
- original: stable/2020-12-01/keys.json <---> new: stable/2021-03-01/keys.json
- original: stable/2020-12-01/library.json <---> new: stable/2021-03-01/library.json
- original: stable/2020-12-01/operations.json <---> new: stable/2021-03-01/operations.json
- original: stable/2020-12-01/privateEndpointConnections.json <---> new: stable/2021-03-01/privateEndpointConnections.json
- original: stable/2020-12-01/privateLinkResources.json <---> new: stable/2021-03-01/privateLinkResources.json
- original: stable/2020-12-01/privatelinkhub.json <---> new: stable/2021-03-01/privatelinkhub.json
- original: stable/2020-12-01/sqlPool.json <---> new: stable/2021-03-01/sqlPool.json
- original: stable/2020-12-01/sqlServer.json <---> new: stable/2021-03-01/sqlServer.json
- original: stable/2020-12-01/workspace.json <---> new: stable/2021-03-01/workspace.json
| Rule | Message |
|---|---|
| The new version adds a response code '204'. New: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L4679:11 |
|
| The new version has a different format than the previous one. New: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L5347:9 Old: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L5344:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 2 Errors, 46 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.id.$ref: undefined => "#/components/schemas/schemas:1193", properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"Error: Plugin prechecker reported failure." |
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'SubResource' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'ManagedIntegrationRuntimeOperationResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'ManagedIntegrationRuntimeNode' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'ManagedIntegrationRuntimeError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'SelfHostedIntegrationRuntimeNode' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'IntegrationRuntimeResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'IntegrationRuntimeStatusResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2021-03", "details":"The schema 'LibraryResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @srinuthati, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Feb 20, 2021
|
Hi, @srinuthati your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ruowan |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
This was referenced Feb 20, 2021
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-03-01/workspace.json
Show resolved
Hide resolved
RamyasreeChakka
added
the
ARMChangesRequested
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
RamyasreeChakka
added
ARMSignedOff
ruowan
approved these changes
Feb 25, 2021
This was referenced Feb 25, 2021
[ReleasePR synapse] [Synapse] - Remove x-ms-azure-resource
Azure/azure-resource-manager-schemas#1315
Merged
11 tasks
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…table/2021-03-01 (Azure#13070) * Adds base for updating Microsoft.Synapse from version stable/2020-12-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * workspace resource api changes * adding 204 response * correcting example * updating enum * correcting restorepointintime format to datetime Co-authored-by: srinivas thatipamula <srthatip@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.