[Hub Generated] Review request for Microsoft.Insights to clean up 2019-11-01-preview (under "window to fix broken") #13139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
|
| Rule | Message |
|---|---|
| "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-11-01-preview-only", "details":"The schema 'DataCollectionRuleAssociationProxyOnlyResource-properties' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-11-01-preview-only", "details":"The schema 'DestinationsSpec-azureMonitorMetrics' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-11-01-preview-only", "details":"The schema 'DataCollectionRule-dataSources' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-11-01-preview-only", "details":"The schema 'DataCollectionRule-destinations' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-11-01-preview-only", "details":"The schema 'DataCollectionRuleResource-properties' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-11-01-preview-only", "details":"The schema 'ErrorDetail' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-11-01-preview-only", "details":"The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-11-01-preview-only", "details":"The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-11-01-preview-only", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
Hi, @TomMilos Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Generation Artifacts
|
|
Hi @TomMilos, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @TomMilos, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Feb 24, 2021
This was referenced Feb 24, 2021
|
In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details. |
TomMilos
changed the title
|
This PR includes some breaking changes to the preview API under the "Window to fix broken". The concrete list of changes includes:
Note that the service will still support payloads which use the values previously defined in the API schema and it will not break any existing data flows. This cleanup is in preparation for the first stable API release planned in coming months @weidongxu-microsoft - FYI |
|
@weidongxu-microsoft as the window to fix broken is coming to a close I'd appreciate quick feedback on these changes. Thanks |
|
This is pretty large PR with lots of breaking changes, you would need to have approval from JeffreyRichter. @ArcturusZhang @jsntcy @msyyc Any concern on Go and Python break changes? |
@weidongxu-microsoft based on the offline thread it looks like @JeffreyRichter is OK with this change |
|
@TomMilos BTW, when it is GAed, will this 2 json be added to other 10+ jsons (e.g. thoses under package-2020-03)? If so, there might be more naming conflict when you merge them, that could be hard to handle. |
|
Quote Jeffrey Richter
|
|
@ArcturusZhang @jsntcy @msyyc Any concern on Go and Python break changes? |
@weidongxu-microsoft yes, we'd want to do that. I just tried generating that and I do see conflicts, however the problem is broader as there are inconsistencies across other swaggers - e.g. some use Regardless, for our swagger we want to leave the full ErrorResponse definition as it accurately represents what the service returns so we want that to be documented. For SDK generation we may want to resolve conflict manually and settle for using one of the existing classes (even if it is missing some of the properties) |
|
@weidongxu-microsoft @ArcturusZhang @jsntcy @msyyc - can we move forward with this? |
|
@TomMilos Ok. Let me know when you need it merged. For combining with other JSONs, Maybe it best handled with a coordinated api-version upgrade to make all JSONs consistent. But I do not have a good consult on this. |
weidongxu-microsoft
added
the
Approved-BreakingChange
weidongxu-microsoft
approved these changes
Mar 9, 2021
This was referenced Mar 9, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…9-11-01-preview (under "window to fix broken") (Azure#13139) * [Monitor] Cleanup DataCollectionRules 2019-11-01-preview (under window to fix broken) * [Monitor] Cleanup DataCollectionRules 2019-11-01-preview - removed unused defs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.