Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/shamkh/feature send sms changes for removing default for required property. #13185

Merged
merged 53 commits into from
Feb 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
cff505f
SettingFolder Structure.
Shamkh Jan 12, 2021
1445b9e
Updating SMS communication Swagger json for 1:N , customer content fe…
Shamkh Jan 13, 2021
0500536
Updating with review comments.
Shamkh Jan 13, 2021
ce1a5e2
adding Idempotency header.
Shamkh Jan 13, 2021
1ff127b
Updating name for Idempodency field.
Shamkh Jan 13, 2021
60de17e
Merging N:1 Changes
Shamkh Jan 14, 2021
73ffb47
fixing integer issue
Shamkh Jan 14, 2021
4466f82
Updating Read me
Shamkh Jan 14, 2021
76f84c2
fixing lint issue.
Shamkh Jan 14, 2021
8636501
Reverting change
Shamkh Jan 14, 2021
83f24db
Fixing Model issue.
Shamkh Jan 14, 2021
be74716
Updating Case for repeatablity header.
Shamkh Jan 14, 2021
cdb3d5a
Example update in sendjson.
Shamkh Jan 15, 2021
1d794c0
Review comments.
Shamkh Jan 15, 2021
8f21ae7
camelCase issue in Send.json.
Shamkh Jan 15, 2021
248eba4
Fixing example Model.
Shamkh Jan 15, 2021
a9cb67f
Model issue fix.
Shamkh Jan 15, 2021
0cee45d
apiversion param issue
Shamkh Jan 15, 2021
3fde0f4
Model issue
Shamkh Jan 16, 2021
6f77bf4
Model validation.
Shamkh Jan 16, 2021
a540834
Review comments.
Shamkh Jan 20, 2021
9dcc8e5
Addressing API review comments: consolidating to 202Accepted response.
Jan 21, 2021
1e02d00
review comments.
Shamkh Jan 21, 2021
cc48444
review comments
Shamkh Jan 21, 2021
525892c
placing response header at right place.
Shamkh Jan 22, 2021
e5863f5
review comments
Shamkh Jan 22, 2021
dc652c9
Modifying wire objects to format [Resource][Method] and adding a flag…
Feb 2, 2021
72834f8
Review comments
Shamkh Feb 3, 2021
c52f834
Fixing swagger validations.
Shamkh Feb 3, 2021
b72ca6d
review comments.
Shamkh Feb 3, 2021
ba8bc6d
review comments.
Shamkh Feb 3, 2021
d4f2cf6
review comments.
Shamkh Feb 3, 2021
964f4bf
review comments.
Shamkh Feb 3, 2021
8c4e094
Swagger validation.
Shamkh Feb 3, 2021
8d026b5
review comments.
Shamkh Feb 3, 2021
4f29e2f
review comments
Shamkh Feb 4, 2021
8e122a2
Merge branch 'master' into users/shamkh/featureSendSmsChanges
Shamkh Feb 4, 2021
7719fa1
Fix Avocado
Shamkh Feb 4, 2021
57e2f26
Fixing endpoint stuff
Shamkh Feb 8, 2021
f2c5324
merge
Shamkh Feb 8, 2021
7c9e05a
review comments
Shamkh Feb 8, 2021
d943496
review comments
Shamkh Feb 9, 2021
cf30608
fix spell
Shamkh Feb 10, 2021
aae4fb0
fixes
Shamkh Feb 10, 2021
4d917ce
prettierfix
Shamkh Feb 10, 2021
341eaf6
fix
Shamkh Feb 10, 2021
a061e42
Revert "fix"
Shamkh Feb 10, 2021
83d782b
review comments
Shamkh Feb 10, 2021
be87c1b
review comments
Shamkh Feb 19, 2021
75c1fb7
removing acs
Shamkh Feb 19, 2021
d371347
Merge branch 'master' into users/shamkh/featureSendSmsChanges
Shamkh Feb 26, 2021
83da5da
Updating swagger for require EnableDelivery report option.
Shamkh Feb 26, 2021
ee9b950
prettier run.
Shamkh Feb 26, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@
"properties": {
"enableDeliveryReport": {
"description": "Enable this flag to receive a delivery report for this message on the Azure Resource EventGrid.",
"type": "boolean",
"default": false
"type": "boolean"
},
"tag": {
"description": "Use this field to provide metadata that will then be sent back in the corresponding Delivery Report.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
],
"message": "Hello world!",
"smsSendOptions": {
"enableDeliveryReport": true
"enableDeliveryReport": true,
"tag": "testSmsRequest"
}
},
"api-version": "2021-03-07",
Expand Down